From: Ranjani Sridharan Subject: Re: [PATCH v2 2/2] ASoC: SOF: Intel: fix reset of host_period_bytes Date: Wed, 03 Jul 2019 12:07:45 -0700 Message-ID: References: <20190703151023.30313-1-yang.jie@linux.intel.com> <20190703151023.30313-2-yang.jie@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 737DCF80058 for ; Wed, 3 Jul 2019 21:07:49 +0200 (CEST) In-Reply-To: <20190703151023.30313-2-yang.jie@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" To: Keyon Jie , alsa-devel@alsa-project.org Cc: pierre-louis.bossart@linux.intel.com, Marcin Rajwa List-Id: alsa-devel@alsa-project.org On Wed, 2019-07-03 at 23:10 +0800, Keyon Jie wrote: > From: Marcin Rajwa > > This patch prevents the reset of host period bytes. > The parameter has been used to keep information about > completion of period copy. Right now we keep this > information in period_irq. > > Signed-off-by: Marcin Rajwa > Signed-off-by: Keyon Jie Reviewed-by: Ranjani Sridharan > --- > sound/soc/sof/intel/hda-pcm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/soc/sof/intel/hda-pcm.c b/sound/soc/sof/intel/hda- > pcm.c > index 9b730f183529..c7022346aba0 100644 > --- a/sound/soc/sof/intel/hda-pcm.c > +++ b/sound/soc/sof/intel/hda-pcm.c > @@ -116,9 +116,9 @@ int hda_dsp_pcm_hw_params(struct snd_sof_dev > *sdev, > /* disable SPIB, to enable buffer wrap for stream */ > hda_dsp_stream_spib_config(sdev, stream, HDA_DSP_SPIB_DISABLE, > 0); > > - /* set host_period_bytes to 0 if no IPC position */ > + /* update no_period_irq flag for ipc params */ > if (hda && hda->no_ipc_position) > - ipc_params->host_period_bytes = 0; > + ipc_params->no_period_irq = 1; > > ipc_params->stream_tag = hstream->stream_tag; >