From: "plaisthos (Code Review)" Date: Wed, 1 Apr 2026 11:53:54 +0000 In-Reply-To: References: Reply-To: arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="dDjvmGVmyZM="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Do not access internals of ASN1_INTEGER to print hex of serial List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: flichtenheld , openvpn-devel --dDjvmGVmyZM= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld. plaisthos has posted comments on this change by plaisthos. ( http://gerrit.= openvpn.net/c/openvpn/+/1589?usp=3Demail ) Change subject: Do not access internals of ASN1_INTEGER to print hex of ser= ial ...................................................................... Patch Set 4: (1 comment) File src/openvpn/ssl_verify_openssl.c: http://gerrit.openvpn.net/c/openvpn/+/1589/comment/07c2a8e3_08873e9b?usp=3D= email : PS4, Line 320: char *ret =3D format_hex_ex(buf, len_serial, 0, 1, ":", = gc); > So why can't we use `BN_bn2hex` here? I changed this to use BN_bn2hex only to find out that then test fails since= we have : in the output and BN_bn2hex does not. [ ERROR ] --- "826BDDCCBDE55EB708F12D68003C24DE" !=3D "82:6b:dd:cc:bd:e5= :5e:b7:08:f1:2d:68:00:3c:24:de" -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1589?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I5158fbb0762443ea4954e5745f520e83e019ed30 Gerrit-Change-Number: 1589 Gerrit-PatchSet: 4 Gerrit-Owner: plaisthos Gerrit-CC: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Wed, 01 Apr 2026 11:53:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld --dDjvmGVmyZM= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: flichtenheld.

View = Change

1 comment:

    =
  • File src/openvpn/ssl_verify_openssl= .c:

    • Pa= tch Set #4, Line 320: = char *ret =3D format_hex_ex(buf, len_serial, 0, 1, ":", gc);

      So why can't we use `BN_bn2hex` here?
      =

      I changed this to use BN_bn2hex only to find out that then test fails = since we have : in the output and BN_bn2hex does not.

      [ ERROR ] --- = "826BDDCCBDE55EB708F12D68003C24DE" !=3D "82:6b:dd:cc:bd:e5:5= e:b7:08:f1:2d:68:00:3c:24:de"

To view, visit= change = 1589. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I5158fbb0762443ea4954e5745f5= 20e83e019ed30
Gerrit-Change-Number: 1589
Gerrit-PatchSet: 4
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-CC: flichtenheld <frank@...2641...&g= t;
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Wed, 01 Apr 2026 11:53:54= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <frank@...1186...= .2641...>
= --dDjvmGVmyZM=--