From: Maarten Lankhorst Subject: Re: [PATCH] drm/i915: Unset legacy_cursor_update early in intel_atomic_commit, v2. Date: Tue, 19 Sep 2017 11:06:52 +0200 Message-ID: References: <20170918101250.6076-1-maarten.lankhorst@linux.intel.com> <20170918150312.GC4914@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5E05D6E0FC for ; Tue, 19 Sep 2017 09:07:11 +0000 (UTC) In-Reply-To: <20170918150312.GC4914@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T3AgMTgtMDktMTcgb20gMTc6MDMgc2NocmVlZiBWaWxsZSBTeXJqw6Rsw6Q6Cj4gT24gTW9uLCBT ZXAgMTgsIDIwMTcgYXQgMTI6MTI6NTBQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9yc3Qgd3JvdGU6 Cj4+IENvbW1pdCBiNDRkNWMwYzEwNWEgKCJkcm0vaTkxNTogQWx3YXlzIHdhaXQgZm9yIGZsaXBf ZG9uZSwgdjIuIikgcmVtb3ZlZAo+PiB0aGUgY2FsbCB0byB3YWl0X2Zvcl92YmxhbmtzIGFuZCBy ZXBsYWNlZCBpdCB3aXRoIGZsaXBfZG9uZS4KPj4KPj4gVW5mb3J0dW5hdGVseSBsZWdhY3lfY3Vy c29yX3VwZGF0ZSB3YXMgdW5zZXQgdG9vIGxhdGUsIGFuZCB0aGUKPj4gcmVwbGFjZW1lbnQgY2Fs bCBkcm1fYXRvbWljX2hlbHBlcl93YWl0X2Zvcl9mbGlwX2RvbmUoKSB3YXMKPj4gYSBub29wLiBN YWtlIHN1cmUgdGhhdCBpdHMgdW5zZXQgYmVmb3JlIHNldHVwX2NvbW1pdCgpIGlzCj4+IGNhbGxl ZCB0byBmaXggdGhpcyBpc3N1ZS4KPj4KPj4gQ2hhbmdlcyBzaW5jZSB2MToKPj4gLSBGb3JjZSB2 Ymxhbmsgd2FpdCBmb3Igd2F0ZXJtYXJrcyBub3QgeWV0IGNvbnZlcnRlZCB0byBhdG9taWMgdG9v LiAoVmlsbGUpCj4+IC0gVXNlIGZvcl9lYWNoX25ld19pbnRlbF9jcnRjX2luX3N0YXRlLiAoVmls bGUpCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmto b3JzdEBsaW51eC5pbnRlbC5jb20+Cj4+IEZpeGVzOiBiNDRkNWMwYzEwNWEgKCJkcm0vaTkxNTog QWx3YXlzIHdhaXQgZm9yIGZsaXBfZG9uZSwgdjIuIikKPj4gQnVnemlsbGE6IGh0dHBzOi8vYnVn cy5mcmVlZGVza3RvcC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjY3NQo+PiBUZXN0Y2FzZToga21z X2N1cnNvcl9jcmMKPj4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+ Cj4+IENjOiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAbGludXguaW50ZWwuY29tPgo+PiBSZXBv cnRlZC1ieTogTWFydGEgTMO2ZnN0ZWR0IDxtYXJ0YS5sb2ZzdGVkdEBpbnRlbC5jb20+Cj4+IENj OiBNYXJ0YSBMw7Zmc3RlZHQgPG1hcnRhLmxvZnN0ZWR0QGludGVsLmNvbT4KPj4gVGVzdGVkLWJ5 OiBNYXJ0YSBMw7Zmc3RlZHQgPG1hcnRhLmxvZnN0ZWR0QGludGVsLmNvbT4KPj4gQ2M6IFZpbGxl IFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4+IC0tLQo+PiAgZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgNDUgKysrKysrKysrKysrKysrKysr KysrLS0tLS0tLS0tLS0tLS0tCj4+ICAxIGZpbGUgY2hhbmdlZCwgMjYgaW5zZXJ0aW9ucygrKSwg MTkgZGVsZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPj4g aW5kZXggODU5OWU0MjVhYmIxLi44ZDA1MTI1NmRhMWUgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kaXNwbGF5LmMKPj4gQEAgLTEyNTE3LDIxICsxMjUxNywxMCBAQCBzdGF0aWMgaW50 IGludGVsX2F0b21pY19jb21taXQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPj4gIAlzdHJ1Y3Qg ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGRldik7Cj4+ICAJaW50IHJldCA9 IDA7Cj4+ICAKPj4gLQlyZXQgPSBkcm1fYXRvbWljX2hlbHBlcl9zZXR1cF9jb21taXQoc3RhdGUs IG5vbmJsb2NrKTsKPj4gLQlpZiAocmV0KQo+PiAtCQlyZXR1cm4gcmV0Owo+PiAtCj4+ICAJZHJt X2F0b21pY19zdGF0ZV9nZXQoc3RhdGUpOwo+PiAgCWk5MTVfc3dfZmVuY2VfaW5pdCgmaW50ZWxf c3RhdGUtPmNvbW1pdF9yZWFkeSwKPj4gIAkJCSAgIGludGVsX2F0b21pY19jb21taXRfcmVhZHkp Owo+PiAgCj4+IC0JcmV0ID0gaW50ZWxfYXRvbWljX3ByZXBhcmVfY29tbWl0KGRldiwgc3RhdGUp Owo+PiAtCWlmIChyZXQpIHsKPj4gLQkJRFJNX0RFQlVHX0FUT01JQygiUHJlcGFyaW5nIHN0YXRl IGZhaWxlZCB3aXRoICVpXG4iLCByZXQpOwo+PiAtCQlpOTE1X3N3X2ZlbmNlX2NvbW1pdCgmaW50 ZWxfc3RhdGUtPmNvbW1pdF9yZWFkeSk7Cj4+IC0JCXJldHVybiByZXQ7Cj4+IC0JfQo+PiAtCj4+ ICAJLyoKPj4gIAkgKiBUaGUgaW50ZWxfbGVnYWN5X2N1cnNvcl91cGRhdGUoKSBmYXN0IHBhdGgg dGFrZXMgY2FyZQo+PiAgCSAqIG9mIGF2b2lkaW5nIHRoZSB2Ymxhbmsgd2FpdHMgZm9yIHNpbXBs ZSBjdXJzb3IKPj4gQEAgLTEyNTQwLDE5ICsxMjUyOSwzNyBAQCBzdGF0aWMgaW50IGludGVsX2F0 b21pY19jb21taXQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPj4gIAkgKiB1cGRhdGVzIGhhcHBl biBkdXJpbmcgdGhlIGNvcnJlY3QgZnJhbWVzLiBHZW45KyBoYXZlCj4+ICAJICogZG91YmxlIGJ1 ZmZlcmVkIHdhdGVybWFya3MgYW5kIHNvIHNob3VsZG4ndCBuZWVkIHRoaXMuCj4+ICAJICoKPj4g LQkgKiBEbyB0aGlzIGFmdGVyIGRybV9hdG9taWNfaGVscGVyX3NldHVwX2NvbW1pdCgpIGFuZAo+ PiAtCSAqIGludGVsX2F0b21pY19wcmVwYXJlX2NvbW1pdCgpIGJlY2F1c2Ugd2Ugc3RpbGwgd2Fu dAo+PiAtCSAqIHRvIHNraXAgdGhlIGZsaXAgYW5kIGZiIGNsZWFudXAgd2FpdHMuIEFsdGhvdWdo IHRoYXQKPj4gLQkgKiBkb2VzIHJpc2sgeWFua2luZyB0aGUgbWFwcGluZyBmcm9tIHVuZGVyIHRo ZSBkaXNwbGF5Cj4+IC0JICogZW5naW5lLgo+PiArCSAqIFVuc2V0IHN0YXRlLT5sZWdhY3lfY3Vy c29yX3VwZGF0ZSBiZWZvcmUgdGhlIGNhbGwgdG8KPj4gKwkgKiBkcm1fYXRvbWljX2hlbHBlcl9z ZXR1cF9jb21taXQoKSBiZWNhdXNlIG90aGVyd2lzZQo+PiArCSAqIGRybV9hdG9taWNfaGVscGVy X3dhaXRfZm9yX2ZsaXBfZG9uZSgpIGlzIGEgbm9vcCBhbmQKPj4gKwkgKiB3ZSBnZXQgRklGTyB1 bmRlcnJ1bnMgYmVjYXVzZSB3ZSBkaWRuJ3Qgd2FpdAo+PiArCSAqIGZvciB2YmxhbmsuCj4+ICAJ ICoKPj4gIAkgKiBGSVhNRSBkb2luZyB3YXRlcm1hcmtzIGFuZCBmYiBjbGVhbnVwIGZyb20gYSB2 Ymxhbmsgd29ya2VyCj4+ICAJICogKGFzc3VtaW5nIHdlIGhhZCBhbnkpIHdvdWxkIHNvbHZlIHRo ZXNlIHByb2JsZW1zLgo+PiAgCSAqLwo+PiAtCWlmIChJTlRFTF9HRU4oZGV2X3ByaXYpIDwgOSkK Pj4gLQkJc3RhdGUtPmxlZ2FjeV9jdXJzb3JfdXBkYXRlID0gZmFsc2U7Cj4+ICsJaWYgKElOVEVM X0dFTihkZXZfcHJpdikgPCA5ICYmIHN0YXRlLT5sZWdhY3lfY3Vyc29yX3VwZGF0ZSkgewo+PiAr CQlzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqbmV3X2NydGNfc3RhdGU7Cj4+ICsJCXN0cnVjdCBp bnRlbF9jcnRjICpjcnRjOwo+PiArCQlpbnQgaTsKPj4gKwo+PiArCQlmb3JfZWFjaF9uZXdfaW50 ZWxfY3J0Y19pbl9zdGF0ZShpbnRlbF9zdGF0ZSwgY3J0YywgbmV3X2NydGNfc3RhdGUsIGkpCj4+ ICsJCQlpZiAobmV3X2NydGNfc3RhdGUtPndtLm5lZWRfcG9zdHZibF91cGRhdGUgfHwKPj4gKwkJ CSAgICBuZXdfY3J0Y19zdGF0ZS0+dXBkYXRlX3dtX3Bvc3QpCj4+ICsJCQkJc3RhdGUtPmxlZ2Fj eV9jdXJzb3JfdXBkYXRlID0gZmFsc2U7Cj4gSG1tLiBJIGd1ZXNzIHRoYXQncyBiZXR0ZXIuIEJ1 dCBJIHN0aWxsIGRvbid0IHNlZSB3aHkgeW91IHdhbnQgdG8gY2hhbmdlCj4gdGhpcyBiaXQgb2Yg Y29kZSBpbiB0aGlzIHBhdGNoLiBBRkFJQ1MgaXQncyBnb3Qgbm90aGluZyB0byBkbyB3aXRoIHRo ZSBmaXgKPiBpdHNlbGYsIGFuZCBpbnN0ZWFkIGl0J3MganVzdCB0cnlpbmcgdG8gb3B0aW1pemUg c29tZSBjdXJzb3IgdXBkYXRlcwo+IHRoYXQgd2VyZSBraWNrZWQgb3ZlciB0byB0aGUgc2xvdyBw YXRoLiBPciBhbSBJIG1pc3Npbmcgc29tZXRoaW5nPwoKV2UgYWNjaWRlbnRhbGx5IHJlbW92ZWQg dGhlIHZibGFuayB3YWl0IGZvciB0aGUgc2xvd3BhdGgsIGJ1dCBJIGRvbid0IHRoaW5rIHdlIHNo b3VsZCByZWludHJvZHVjZSB0aGUgdmJsYW5rIGV4Y2VwdCB3aGVyZSB3ZSBuZWVkIGl0Li4KCn5N YWFydGVuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK