Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4EAFC43461 for ; Mon, 7 Sep 2020 07:22:41 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 62F17207C3 for ; Mon, 7 Sep 2020 07:22:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 62F17207C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kFBTu-0001Qp-Dz; Mon, 07 Sep 2020 07:22:26 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kFBTt-0001Qk-TS for xen-devel@lists.xenproject.org; Mon, 07 Sep 2020 07:22:25 +0000 X-Inumbo-ID: 1e2ef1c7-a7ef-4ae3-b774-9b3cd445ab28 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1e2ef1c7-a7ef-4ae3-b774-9b3cd445ab28; Mon, 07 Sep 2020 07:22:25 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 47C51AF7F; Mon, 7 Sep 2020 07:22:25 +0000 (UTC) Subject: Re: [PATCH v3 1/8] x86/vmx: handle writes to MISC_ENABLE MSR To: "Tian, Kevin" , Roger Pau Monne Cc: "xen-devel@lists.xenproject.org" , "Nakajima, Jun" , Andrew Cooper , Wei Liu References: <20200901105445.22277-1-roger.pau@citrix.com> <20200901105445.22277-2-roger.pau@citrix.com> From: Jan Beulich Message-ID: Date: Mon, 7 Sep 2020 09:22:23 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 07.09.2020 05:25, Tian, Kevin wrote: >> From: Roger Pau Monne >> Sent: Tuesday, September 1, 2020 6:55 PM >> >> Such handling consist in checking that no bits have been changed from >> the read value, if that's the case silently drop the write, otherwise >> inject a fault. >> >> At least Windows guests will expect to write to the MISC_ENABLE MSR >> with the same value that's been read from it. > > for better readability could you also add this line to the code comment > below? > > with that: > > Reviewed-by: Kevin Tian I'll fold this in while committing. Jan