Reply-To: openvpn-devel@lists.sourceforge.net References: From: David Sommerseth Message-ID: Date: Wed, 4 Apr 2018 18:50:29 +0200 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB Subject: Re: [Openvpn-devel] [PATCH] Send authentication failure reason between plugins List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: Janito Vaqueiro Filho , openvpn-devel@lists.sourceforge.net On 04/04/18 16:43, Janito Vaqueiro Filho wrote: > This patch implements support for sending an authentication failure > reason from a server plugin to a client plugin. Currently this can only > be done using the management interface. To allow this to be done through > the use of plugins, two changes were made. > > The first change is to allow a plugin to set the failure reason through > an approach similar to how deferred authentication is done. The reason > should be written as a single line to an external file whose path is > specified in the plugin environment variable "auth_failure_reason_file". > > The second change introduces a new plugin event: "AUTH_FAILED". Plugins > running in the client that register to receive this event are notified > when an authentication failure is reported from the server. The > authentication failure reason, if one was received, is set to the > "auth_failed_reason" environment variable. > > Signed-off-by: Janito Vaqueiro Ferreira Filho Thanks for the patch ... but I don't trust the transport of this patch, I get a slightly different output when pulling the patch from patchwork: So I believe your GMail setup has corrupted this patch - and I see it is sent both as text/plain and text/html. Please try to resend it via 'git send-email' instead, that generally does not cause such corruptions. -- kind regards, David Sommerseth OpenVPN Inc