Return-Path: Message-ID: Date: Mon, 10 Oct 2022 13:14:33 +0200 MIME-Version: 1.0 To: Matthew Auld , igt-dev@lists.freedesktop.org References: <20221010104840.28026-1-matthew.auld@intel.com> Content-Language: en-US From: "Das, Nirmoy" In-Reply-To: <20221010104840.28026-1-matthew.auld@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [igt-dev] [Intel-gfx] [PATCH i-g-t] tests/i915/module_load: fix resize-bar on DG1 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, Nirmoy Das Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On 10/10/2022 12:48 PM, Matthew Auld wrote: > DG1, as expected only has a fixed sized bar, so attempting to force the > BAR size should fail. Update the test to account for such devices, and > perform a skip, instead of failing. > > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6458 > Signed-off-by: Matthew Auld > Cc: Nirmoy Das Tested-by:  Nirmoy Das Reviewed-by: Nirmoy Das > --- > tests/i915/i915_module_load.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/i915/i915_module_load.c b/tests/i915/i915_module_load.c > index 4c72157c..6d74de58 100644 > --- a/tests/i915/i915_module_load.c > +++ b/tests/i915/i915_module_load.c > @@ -422,7 +422,7 @@ igt_main > > /* Test for lmem_bar_size modparam support */ > lmem_bar_size = driver_load_with_lmem_bar_size(MIN_BAR_SIZE, true); > - igt_assert_eq(lmem_bar_size, MIN_BAR_SIZE); > + igt_skip_on_f(lmem_bar_size != MIN_BAR_SIZE, "Device lacks PCI resizeable BAR support.\n"); > > lmem_bar_size = driver_load_with_lmem_bar_size(0, false); >