Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 72EECC433F5 for ; Sun, 22 May 2022 02:06:21 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 803D583E60; Sun, 22 May 2022 04:06:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1653185178; bh=OM5BnAGGZZEF7SpfSo/wCUSVYnVLz3Vdk00BRrOK2/0=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=PrndBFkT0hg6zuzwBMwOO0MfrP58hyAIUbnR/MP4a15a2AtaRgEw8AKDrfGytPUoq HmQKlI9lLuTGZd4mmslosButeMWMOp/bu8PyEC9vJcJUasREGOX6IoviaSjZeW1k/O ybox5CxjK+IP4bYSGYutdNj9Un2H1ca8vhco0uK0CSLEqrLAEfuvOSPe18/npp2Voo glzMbMox8MMKOMMSomvOlJYiFsK9FB2r9qhRAhHeHxftT5dxKSavFKdu/zjP3O+7cZ eayqGorOGLVPnuv2+vW5cz9YC/8aSMFZ3bkTh7t4FpYFIov0lAyu3SLjupXMJlihhx yjsjbHnTnmXcQ== Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id C2C28805FE; Sun, 22 May 2022 04:06:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1653185177; bh=OM5BnAGGZZEF7SpfSo/wCUSVYnVLz3Vdk00BRrOK2/0=; h=Date:Subject:To:References:From:In-Reply-To:From; b=WMyTUf2Gv9pEPJzoJ/cbFCixJqfWB4b1/6bzTMwIr/oxN1V8ew0muh9aKFIW6jNn6 hatY+9Fxm4BA+gcp0F+SI2FiudYU/JaIThLZpLRbls5fnvTpBkpWTeNDFdEA7MZVXe 62mLwCqUNFpWhL2eb4+o1oDcqWz5uD1taXl/bVzxVv9Yj8cXdFm4yw3zKcALoq3CYc ci6R3GUEnVpEz5AZRmcowwmFoMsgwCbNqM5dK7vM/Ruy2dv1EC+oXKfr9wcwsoTf2w XM6VHKd9X9yHFptHW+1n8KfDMZfMmtIluKvG1Z0V051eZaqfxmt8ICs8q31ey8bFxA TEH//p69m1Gxg== Message-ID: Date: Sun, 22 May 2022 04:06:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] arm: socfpga: Add the terasic de10-standard board Content-Language: en-US To: Humberto Naves , u-boot@lists.denx.de References: <20220521173221.6425-1-hsnaves@gmail.com> From: Marek Vasut In-Reply-To: <20220521173221.6425-1-hsnaves@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 5/21/22 19:32, Humberto Naves wrote: > Used the de10-nano files as templates for the de10-standard board. > Changed the iocsr_config.h and pinmux_config.h based on the handoff > files generated by quartus. Finally, the pll_config.h was copied > from the altera cyclone5-socdk board. Doesn't the PLL config also come from quartus ? It should all come from it. See doc/README.socfpga > Signed-off-by: Humberto Naves > Cc: Marek Vasut I think a lot of those board/config-specific copyright messages could use an update, I think they should be assigned to you. Please do a quick V2 with that change. Besides that: Reviewed-by: Marek Vasut