From: Andrew Victor Subject: Re: [PATCH 2/3] ide: add at91_ide driver Date: Thu, 5 Feb 2009 22:00:30 +0200 Message-ID: References: <200902031147.22827.stf_xl@wp.pl> <200902041547.44149.stf_xl@wp.pl> <4989BC8B.4010105@ru.mvista.com> <200902051601.50822.stf_xl@wp.pl> <498B0F22.3090403@ru.mvista.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ew0-f20.google.com ([209.85.219.20]:42170 "EHLO mail-ew0-f20.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752948AbZBEUAd (ORCPT ); Thu, 5 Feb 2009 15:00:33 -0500 Received: by ewy13 with SMTP id 13so824090ewy.18 for ; Thu, 05 Feb 2009 12:00:30 -0800 (PST) In-Reply-To: <498B0F22.3090403@ru.mvista.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Sergei Shtylyov Cc: Stanislaw Gruszka , linux-ide@vger.kernel.org, Andrew Victor , linux-arm-kernel@lists.arm.linux.org.uk hi, >>>>> AT91SAM9. > >>>> Ok, currently only SAM9 can be used with driver. However I think adding >>>> support to AT91RM9200 to this driver will be not much effort. > >>> Can you answer the simple question: why we should try to support two >>> incompatible chips with a single driver? Because the driver name will be >>> shorter? :-) > >> Very funny. I think patch adding RM9200 support to this driver will have >> less >> than 50 lines changeset, whereas writing new driver would be about 500 >> lines. > > This approach is so broken-minded that I'm just out words to argue any > more. This driver should also work on the Atmel AT91CAP9 and AT572D940HF processors. So I see no valid reason why the driver cannot be called at91_ide. Regards, Andrew Victor