Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682392882; x=1684984882; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cN9/YUxWs5H/H9NnNZlPawYxmUNjA2eYoGXzFtDd0jQ=; b=q4DvTgB8xTQODYMGh+aNv52t8iIT1tL9IRPY9TQEqRhlkPwy0xJYUaWbq+UwrF38jh RPHAKSwdUFYzs3ZXtngrP1+ejepWYZUqjj4CdalzSu0Dj2mYFuW5MF7ZsxpDtFyd0ouu 7tsrqP8UxN29r288+mKUMXnhLonV6IF55aA9yo+CBKVJYtlNh8cQFbUW6rap6aq+hc1Z /8YNLMbJnXurbIMz+e5ZsujvE1DMtdSQWdEBCovKlx4jel9VTVHZTUc+ZRz5mbVFraRS Buwz6Asm2BKjKUjCkM7SnZSwicox7UY1KZ4PuXKjzmhFwXIFb9ZfZdvTPzUkg9goUdYZ s7nA== Message-ID: Date: Tue, 25 Apr 2023 12:21:17 +0900 MIME-Version: 1.0 Subject: Re: [PATCH -perfbook 2/2] memorder: Use desctiption list for PowerPC terminology References: <23dea7ea-6dda-bfdc-c0b5-50e0e841677b@gmail.com> <07f95142-2631-e0aa-f5a3-dbf669d5fcec@gmail.com> <20f67b11-09ed-404d-bf09-6d14f7b20f1d@paulmck-laptop> Content-Language: en-US From: Akira Yokosawa In-Reply-To: <20f67b11-09ed-404d-bf09-6d14f7b20f1d@paulmck-laptop> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit To: paulmck@kernel.org Cc: perfbook@vger.kernel.org, Akira Yokosawa List-ID: On Mon, 24 Apr 2023 08:56:36 -0700, Paul E. McKenney wrote: > On Sat, Apr 22, 2023 at 02:56:26PM +0900, Akira Yokosawa wrote: >> Using \paragraph under subsection level breaks normal document >> structure. >> >> A description list should be a better fit for the purpose of >> presenting PowerPC terminology. >> >> As a bonus, this change makes the end of the list of terminology >> becomes obvious to your eyes. >> >> Signed-off-by: Akira Yokosawa >> --- >> Hi Paul, >> >> I think this is what you wanted do. >> I changed the periods at the end of terms into colons. >> Do they look good to you? > > Looks good, queued and pushed, thank you! > > I did not know about "style=nextline", very nice! It is provided by the "enumitem" package. I think there are several lists which is already using it. There look to me other uses of \paragraph which can be converted to definition lists. I'll look in to them. > > Good catch on \FloatBarrier! The reason I moved it was that while I > was writing the new section, it was leaving most of a page blank. > But now that that section is complete, it doesn't seem to be having > much effect. So I removed it. > > Please let me know if this removal had bad effects somewhere that > I missed. Commit abf7086e7959 ("memorder: Remove \FloatBarrier") removed the one in front of Section 15.6.2. It has lost its relevance and, yes, you are right in removing it. The one I was moving in patch 1/2 is the one in front of Section 15.2.8. It spoils the -1c builds and results in an almost blank page at the end of Section 15.2.7. It turns out just removing the \FloatBarrier suffices. Will send a patch v2 for the removal. Thanks, Akira > > Thanx, Paul > >> Thanks, Akira >> -- >> memorder/memorder.tex | 16 ++++++++++------ >> 1 file changed, 10 insertions(+), 6 deletions(-) >> >> diff --git a/memorder/memorder.tex b/memorder/memorder.tex >> index 7d6153a1a67e..cbd772e4fde4 100644 >> --- a/memorder/memorder.tex >> +++ b/memorder/memorder.tex >> @@ -2571,15 +2571,17 @@ later \co{lwz} from \co{x} must precede \co{P0()}'s \co{stw} to \co{x}. >> Seeing how this can happen requires a rough understanding of the >> following PowerPC terminology. >> >> -\paragraph{Instruction commit.} >> +\begin{description}[style=nextline] >> + >> +\item[Instruction commit:] >> This can be thought of as the execution of that instruction as opposed >> to the memory-system consequences of having executed that instruction. >> >> -\paragraph{Write reaching coherence point.} >> +\item[Write reaching coherence point:] >> This can be thought of as the value written being deposited into the >> corresponding cache line. >> >> -\paragraph{Partial coherence commit.} >> +\item[Partial coherence commit:] >> This can be thought of as the system having worked out the order in which >> a pair of values written will be deposited into the corresponding cache >> line, but potentially well before that cache line arrives. >> @@ -2589,7 +2591,7 @@ suggests that real PowerPC hardware does in fact use partial coherence >> commits to handle concurrent stores by multiple hardware threads within >> a single core. >> >> -\paragraph{Write propagate to thread.} >> +\item[Write propagate to thread:] >> This occurs when a second hardware thread becomes aware of the first >> hardware thread's write. >> The time at which a write propagates to a given thread might not have >> @@ -2601,11 +2603,11 @@ the first thread's write's value might have been deposited into the >> corresponding cache line long before the second thread learns of that >> write. >> >> -\paragraph{Barrier propagate to thread.} >> +\item[Barrier propagate to thread:] >> Hardware threads make each other aware of memory-barrier instructions >> as needed by propagating them to each other. >> >> -\paragraph{Acknowledge \co{sync}.} >> +\item[Acknowledge \tco{sync}:] >> The PowerPC \co{sync} instruction implements the Linux kernel's >> \co{smp_mb()} full barrier. >> And one reason that the \co{sync} instruction provides such strong >> @@ -2614,6 +2616,8 @@ threads, but these other threads must also acknowledge each \co{sync}. >> This two-way communication allows the hardware threads to cooperate >> to produce the required strong global ordering. >> >> +\end{description} >> + >> \begin{figure*}[tbp] >> \centering >> \resizebox{\textwidth}{!}{\includegraphics{memorder/PPCMEM0.png}} >> -- >> 2.25.1 >> >>