From: Tvrtko Ursulin Subject: Re: [PATCH v2] drm/i915: Cleanup i915_gem_request_add_to_client Date: Thu, 29 Sep 2016 08:44:14 +0100 Message-ID: References: <0160927121915.GU28107@nuc-i3427.alporthouse.com> <1475081303-10821-1-git-send-email-tvrtko.ursulin@linux.intel.com> <20160928170930.GA28107@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 748EE6E1B9 for ; Thu, 29 Sep 2016 07:44:16 +0000 (UTC) In-Reply-To: <20160928170930.GA28107@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Tvrtko Ursulin , Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDI4LzA5LzIwMTYgMTg6MDksIENocmlzIFdpbHNvbiB3cm90ZToKPiBPbiBXZWQsIFNlcCAy OCwgMjAxNiBhdCAwNTo0ODoyM1BNICswMTAwLCBUdnJ0a28gVXJzdWxpbiB3cm90ZToKPj4gRnJv bTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPj4KPj4gU2V2ZXJh bCB0aGluZ3Mgd2UgY2FuIGNsZWFuIHVwIGluIHRoaXMgZnVuY3Rpb246Cj4+Cj4+ICAgKiBSZXF1 ZXN0IGFuZCBmaWxlIHBhc3NlZCBpbiBjYW5ub3QgYmUgTlVMTC4gVGhlcmUgaXMKPj4gICAgIGEg c2luZ2xlIGNhbGxlciB3aGljaCBtYWtlcyBpdCBpbXBvc3NpYmxlIHNvIGNoYW5nZQo+PiAgICAg dGhhdCBjb25kaXRpb24gdG8gYSBHRU1fQlVHX09OIGluc3RlYWQgb2YgYSBXQVJOCj4+ICAgICB3 aXRoIGEgcmV0dXJuIGNvZGUuCj4+Cj4+ICAgKiBTYW1lIGlzIHRydWUgZm9yIHJlcS0+ZmlsZV9w cml2IHdoaWNoIGlzIGFsd2F5cwo+PiAgICAgemVyb2VkIGJlZm9yZSB0aGlzIGZ1bmN0aW9uIGlz IGNhbGxlZC4KPj4KPj4gICAqIFdpdGggdGhlIGFib3ZlIHdlIGNhbiByZW1vdmUgdGhlIGVycm9y IHJldHVybgo+PiAgICAgZnJvbSB0aGUgZnVuY3Rpb24gbWFraW5nIGl0IHZvaWQuCj4+Cj4+ICAg KiBkZXZfcHJpdmF0ZSBsb2NhbCB2YXJpYWJsZSB3YXMgdW51c2VkLgo+Pgo+PiAgICogQ2FsbCBz aXRlIGluIGk5MTVfZ2VtX2RvX2V4ZWNidWZmZXIgY2FuIGJlCj4+ICAgICBzaW1wbGlmaWVkIHNp bmNlIHRoZXJlIGlzIG5vIGVycm9yIGhhbmRsaW5nIGFueQo+PiAgICAgbG9uZ2VyLgo+Pgo+PiB2 MjoKPj4gICAqIE1vdmUgbmV4dCB0byB0aGUgb25seSBjYWxsZXIuIChDaHJpcyBXaWxzb24pCj4+ ICAgKiBSZW1vdmUgdXNlbGVzcyBhc3NlcnRzLiAoSm9vbmFzIExhaHRpbmVuKQo+Pgo+PiBTaWdu ZWQtb2ZmLWJ5OiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+PiBS ZXZpZXdlZC1ieTogSm9vbmFzIExhaHRpbmVuIDxqb29uYXMubGFodGluZW5AbGludXguaW50ZWwu Y29tPiAodjEpCj4+IC0tLQo+PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2V4ZWNi dWZmZXIuYyB8IDIwICsrKysrKysrKysrKysrKy0tLS0tCj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9nZW1fcmVxdWVzdC5jICAgIHwgMjUgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3JlcXVlc3QuaCAgICB8ICAyIC0tCj4+ ICAgMyBmaWxlcyBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspLCAzMiBkZWxldGlvbnMoLSkKPj4K Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2V4ZWNidWZmZXIu YyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2V4ZWNidWZmZXIuYwo+PiBpbmRleCAz M2M4NTIyNzY0M2QuLjIwZGM3ZDkwY2VjZiAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9nZW1fZXhlY2J1ZmZlci5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZ2VtX2V4ZWNidWZmZXIuYwo+PiBAQCAtMTYxMiw2ICsxNjEyLDE5IEBAIGViX3NlbGVj dF9lbmdpbmUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+PiAgIAlyZXR1cm4g ZW5naW5lOwo+PiAgIH0KPj4gICAKPj4gK3N0YXRpYyB2b2lkIGk5MTVfZ2VtX3JlcXVlc3RfYWRk X3RvX2NsaWVudChzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcSwKPj4gKwkJCQkJICAg c3RydWN0IGRybV9maWxlICpmaWxlKQo+IEp1c3QgYWRkX3RvX2NsaWVudC4KCk9rLgoKPj4gK3sK Pj4gKwlzdHJ1Y3QgZHJtX2k5MTVfZmlsZV9wcml2YXRlICpmaWxlX3ByaXYgPSBmaWxlLT5kcml2 ZXJfcHJpdjsKPj4gKwo+PiArCUdFTV9CVUdfT04ocmVxLT5maWxlX3ByaXYpOwo+IFRoZSBlcnJv ciBpc24ndCBhc3NvY2lhdGVkIHdpdGggZXhlY2J1Zi4gVGhlIGV4cGxvc2lvbiB3aWxsIGhhcHBl bgo+IGVsc2V3aGVyZSBhbmQgd2lsbCBiZSBmcm9tIGEgcGF0aCB0aGF0IGRvZXNuJ3QgZ28gbmVh ciBleGVjYnVmLgoKSSBkaWQgbm90IGV2ZW4gc3BvdCBpdCB3aGlsZSBsb29raW5nLiBXaWxsIHJl bW92ZS4KCj4+ICsJc3Bpbl9sb2NrKCZmaWxlX3ByaXYtPm1tLmxvY2spOwo+PiArCXJlcS0+Zmls ZV9wcml2ID0gZmlsZV9wcml2Owo+PiArCWxpc3RfYWRkX3RhaWwoJnJlcS0+Y2xpZW50X2xpc3Qs ICZmaWxlX3ByaXYtPm1tLnJlcXVlc3RfbGlzdCk7Cj4+ICsJc3Bpbl91bmxvY2soJmZpbGVfcHJp di0+bW0ubG9jayk7Cj4+ICt9Cj4+ICsKPj4gICBzdGF0aWMgaW50Cj4+ICAgaTkxNV9nZW1fZG9f ZXhlY2J1ZmZlcihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB2b2lkICpkYXRhLAo+PiAgIAkJICAg ICAgIHN0cnVjdCBkcm1fZmlsZSAqZmlsZSwKPj4gQEAgLTE4MjQsOSArMTgzNyw3IEBAIGk5MTVf Z2VtX2RvX2V4ZWNidWZmZXIoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdm9pZCAqZGF0YSwKPj4g ICAJICovCj4+ICAgCXBhcmFtcy0+cmVxdWVzdC0+YmF0Y2ggPSBwYXJhbXMtPmJhdGNoOwo+PiAg IAo+PiAtCXJldCA9IGk5MTVfZ2VtX3JlcXVlc3RfYWRkX3RvX2NsaWVudChwYXJhbXMtPnJlcXVl c3QsIGZpbGUpOwo+PiAtCWlmIChyZXQpCj4+IC0JCWdvdG8gZXJyX3JlcXVlc3Q7Cj4+ICsJaTkx NV9nZW1fcmVxdWVzdF9hZGRfdG9fY2xpZW50KHBhcmFtcy0+cmVxdWVzdCwgZmlsZSk7Cj4+ICAg Cj4+ICAgCS8qCj4+ICAgCSAqIFNhdmUgYXNzb3J0ZWQgc3R1ZmYgYXdheSB0byBwYXNzIHRocm91 Z2ggdG8gKl9zdWJtaXNzaW9uKCkuCj4+IEBAIC0xODQxLDggKzE4NTIsNyBAQCBpOTE1X2dlbV9k b19leGVjYnVmZmVyKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHZvaWQgKmRhdGEsCj4+ICAgCXBh cmFtcy0+Y3R4ICAgICAgICAgICAgICAgICAgICAgPSBjdHg7Cj4+ICAgCj4+ICAgCXJldCA9IGV4 ZWNidWZfc3VibWl0KHBhcmFtcywgYXJncywgJmViLT52bWFzKTsKPj4gLWVycl9yZXF1ZXN0Ogo+ PiAtCV9faTkxNV9hZGRfcmVxdWVzdChwYXJhbXMtPnJlcXVlc3QsIHJldCA9PSAwKTsKPj4gKwlf X2k5MTVfYWRkX3JlcXVlc3QocGFyYW1zLT5yZXF1ZXN0LCB0cnVlKTsKPiBXZSBkb24ndCB3YW50 IHRvIGZvcmNlIHRoZSBmbHVzaCBpZiBzdWJtaXQgZmFpbHMgZWl0aGVyLgoKRW1iYXJyYXNzaW5n LiA6SQoKUmVnYXJkcywKClR2cnRrbwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vaW50ZWwtZ2Z4Cg==