From: Tvrtko Ursulin Subject: Re: [PATCH v5 2/2] drm/i915: Implement WaProgramMgsrForL3BankSpecificMmioReads Date: Wed, 28 Mar 2018 10:39:31 +0100 Message-ID: References: <1522080757-7118-1-git-send-email-yunwei.zhang@intel.com> <1522188879-10779-1-git-send-email-yunwei.zhang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8D0316E6B5 for ; Wed, 28 Mar 2018 09:39:35 +0000 (UTC) In-Reply-To: <1522188879-10779-1-git-send-email-yunwei.zhang@intel.com> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Yunwei Zhang , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDI3LzAzLzIwMTggMjM6MTQsIFl1bndlaSBaaGFuZyB3cm90ZToKPiBMM0JhbmsgY291bGQg YmUgZnVzZWQgb2ZmIGluIGhhcmR3YXJlIGZvciBkZWJ1ZyBwdXJwb3NlLCBhbmQgaXQKPiBpcyBw b3NzaWJsZSB0aGF0IHN1YnNsaWNlIGlzIGVuYWJsZWQgd2hpbGUgaXRzIGNvcnJlc3BvbmRpbmcg TDNCYW5rIHBhaXJzCj4gYXJlIGRpc2FibGVkLiBJbiBzdWNoIGNhc2UsIGlmIE1DUiBwYWNrZXQg Y29udHJvbCByZWdpc3RlcigweEZEQykgaXMKPiBwcm9ncmFtZWQgdG8gcG9pbnQgdG8gYSBkaXNh YmxlZCBiYW5rIHBhaXIsIGEgTU1JTyByZWFkIGludG8gTDNCYW5rIHJhbmdlCj4gd2lsbCByZXR1 cm4gMCBpbnN0ZWFkIG9mIGNvcnJlY3QgdmFsdWVzLgo+IAo+IEhvd2V2ZXIsIHRoaXMgaXMgbm90 IGdvaW5nIHRvIGJlIHRoZSBjYXNlIGluIGFueSBwcm9kdWN0aW9uIHNpbGljb24uCj4gVGhlcmVm b3JlLCB3ZSBvbmx5IGNoZWNrIGF0IGluaXRpYWxpemF0aW9uIGFuZCBpc3N1ZSBhIHdhcm5pbmcg c2hvdWxkCj4gdGhpcyByZWFsbHkgaGFwcGVuLgo+IAo+IFJlZmVyZW5jZXM6IEhTREVTIzE0MDU1 ODY4NDAKPiAKPiB2MjoKPiAgIC0gdXNlIGZscyBpbnN0ZWFkIG9mIGZpbmRfbGFzdF9iaXQgKENo cmlzKQo+ICAgLSB1c2UgaXNfcG93ZXJfb2ZfMigpIGluc3RlYWQgb2YgY291bnRpbmcgYml0IHNl dCAoQ2hyaXMpCj4gdjM6Cj4gICAtIHJlYmFzZSBvbiBsYXRlc3QgdGlwCj4gdjU6Cj4gICAtIEFk ZGVkIHJlZmVyZW5jZXMgKE1pa2EpCj4gICAtIE1vdmUgbG9jYWwgdmFyaWFibGUgaW50byBzY29w ZSB3aGVyZSB0aGV5IGFyZSB1c2VkIChVcnN1bGluKQo+ICAgLSB1c2UgYSBuZXcgbG9jYWwgdmFy aWFibGUgdG8gcmVkdWNlIGxvbmcgbGluZSBvZiBjb2RlIChVcnN1bGluKQo+IAo+IENjOiBPc2Nh ciBNYXRlbyA8b3NjYXIubWF0ZW9AaW50ZWwuY29tPgo+IENjOiBNaWNoZWwgVGhpZXJyeSA8bWlj aGVsLnRoaWVycnlAaW50ZWwuY29tPgo+IENjOiBKb29uYXMgTGFodGluZW4gPGpvb25hcy5sYWh0 aW5lbkBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2ls c29uLmNvLnVrPgo+IENjOiBNaWthIEt1b3BwYWxhIDxtaWthLmt1b3BwYWxhQGxpbnV4LmludGVs LmNvbT4KPiBDYzogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGxpbnV4LmludGVsLmNv bT4KPiBTaWduZWQtb2ZmLWJ5OiBZdW53ZWkgWmhhbmcgPHl1bndlaS56aGFuZ0BpbnRlbC5jb20+ Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oICAgICAgICB8ICA0ICsr KysKPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2VuZ2luZV9jcy5jIHwgMjAgKysrKysr KysrKysrKysrKysrKysKPiAgIDIgZmlsZXMgY2hhbmdlZCwgMjQgaW5zZXJ0aW9ucygrKQo+IAo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+IGluZGV4IDFiY2E2OTVmLi40ZjJmNWUxIDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgKPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X3JlZy5oCj4gQEAgLTI2OTEsNiArMjY5MSwxMCBAQCBlbnVtIGk5MTVf cG93ZXJfd2VsbF9pZCB7Cj4gICAjZGVmaW5lICAgR0VOMTBfRjJfU1NfRElTX1NISUZUCQkxOAo+ ICAgI2RlZmluZSAgIEdFTjEwX0YyX1NTX0RJU19NQVNLCQkoMHhmIDw8IEdFTjEwX0YyX1NTX0RJ U19TSElGVCkKPiAgIAo+ICsjZGVmaW5lCUdFTjEwX01JUlJPUl9GVVNFMwkJX01NSU8oMHg5MTE4 KQo+ICsjZGVmaW5lIEdFTjEwX0wzQkFOS19QQUlSX0NPVU5UICAgICA0Cj4gKyNkZWZpbmUgR0VO MTBfTDNCQU5LX01BU0sgICAweDBGCj4gKwo+ICAgI2RlZmluZSBHRU44X0VVX0RJU0FCTEUwCQlf TU1JTygweDkxMzQpCj4gICAjZGVmaW5lICAgR0VOOF9FVV9ESVMwX1MwX01BU0sJCTB4ZmZmZmZm Cj4gICAjZGVmaW5lICAgR0VOOF9FVV9ESVMwX1MxX1NISUZUCQkyNAo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9lbmdpbmVfY3MuYyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2VuZ2luZV9jcy5jCj4gaW5kZXggNGM3OGQxZS4uN2JlN2E3NSAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9lbmdpbmVfY3MuYwo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2VuZ2luZV9jcy5jCj4gQEAgLTgxMSw2ICs4MTEsMjYgQEAg c3RhdGljIHUzMiBjYWxjdWxhdGVfbWNyKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp diwgdTMyIG1jcikKPiAgIHN0YXRpYyB2b2lkIHdhX2luaXRfbWNyKHN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdikKPiAgIHsKPiAgIAl1MzIgbWNyOwo+ICsJY29uc3Qgc3RydWN0IHNz ZXVfZGV2X2luZm8gKnNzZXUgPSAmKElOVEVMX0lORk8oZGV2X3ByaXYpLT5zc2V1KTsKCkFub3Ro ZXIgc3R5bGUgbml0cGljayAtIHNvcnJ5IEkgZGlkIG5vdCBub3RpY2UgaXQgYmVmb3JlIC0gd2Ug dHlwaWNhbGx5IApvcmRlciBhc3NpZ25tZW50cyBmcm9tIGZ1bmN0aW9ucyBhcmd1bWVudHMgdG8g bG9jYWxzIGZpcnN0LCB0aGVuIHB1cmUgCmxvY2Fscy4gQWxzbyB3ZSB0eXBpY2FsbHkgdHJ5IHRv IG1ha2UgdGhlIGRlY2xhcmF0aW9uIGJsb2NrIHN0YXJ0IHdpZGUgCmFuZCB0aGVuIG5hcnJvdy4K Cj4gKwo+ICsJLyogSWYgbW9yZSB0aGFuIG9uZSBzbGljZSBhcmUgZW5hYmxlZCwgTDNCYW5rcyBz aG91bGQgYmUgYWxsIGVuYWJsZWQgKi8KCkwzQmFua3Mgc2hvdWxkIGJlIGFsbCBlbmFibGVkLCBv ciBlbmFibGVkIGZvciBhbGwgZW5hYmxlZCBzbGljZXM/IChUaGF0IApjb21tZW50IGJlbG93IHNh eXMgInNob3VsZCBoYXZlIF9tYXRjaGVkXyIuCgo+ICsJaWYgKGlzX3Bvd2VyX29mXzIoc3NldS0+ c2xpY2VfbWFzaykpIHsKPiArCQkvKgo+ICsJCSAqIFdhUHJvZ3JhbU1nc3JGb3JMM0JhbmtTcGVj aWZpY01taW9SZWFkczoKPiArCQkgKiByZWFkIEZVU0UzIGZvciBlbmFibGVkIEwzIEJhbmsgSURz LCBpZiBMMyBCYW5rIG1hdGNoZXMKPiArCQkgKiBlbmFibGVkIHN1YnNsaWNlLCBubyBuZWVkIHRv IHJlZGlyZWN0IE1DUiBwYWNrZXQKPiArCQkgKi8KClRoaXMgY29tbWVudCBpbXBsaWVzIHRoZXJl IHdpbGwgYmUgc29tZSBhY3Rpb24gdGFrZW4gZGVwZW5kaW5nIG9uIHRoaXMgCmNvbmRpdGlvbmFs IHJlbGF0aW5nIHRvIHRoZSBNQ1IsIGJ1dCB0aGVyZSBpcyBub3RoaW5nIHRoZXJlPwoKSXQgaXMg bm90IGNsZWFyIHRvIG1lIHdoYXQgc2hvdWxkIGFuZCB3aGV0aGVyIHBlcmhhcHMgdGhpcyBjb21t ZW50IApzaG91bGQgYmUgcHVsbGVkIHVwIGFuZCBtZXJnZWQgd2l0aCB0aGUgb25lIGFib3ZlIHRo ZSBjb25kaXRpb25hbC4KCj4gKwkJdTMyIHNsaWNlID0gZmxzKHNzZXUtPnNsaWNlX21hc2spOwo+ ICsJCXUzMiBmdXNlMyA9IEk5MTVfUkVBRChHRU4xMF9NSVJST1JfRlVTRTMpOwo+ICsJCXU4IHNz X21hc2sgPSBzc2V1LT5zdWJzbGljZV9tYXNrW3NsaWNlXTsKCkluc2VydCBibGFuayBsaW5lIGFm dGVyIGRlY2xhcmF0aW9ucy4KCkFsc28sIGlzIGl0IGNvcnJlY3QgdG8gb25seSBjb25zaWRlciB0 aGUgc3Vic2xpY2UgbWFzayBvZiB0aGUgbGFzdCBzbGljZSAKZm9yIHRoaXMgY2hlY2s/Cgo+ICsJ CS8qCj4gKwkJICogUHJvZHVjdGlvbiBzaWxpY29uIHNob3VsZCBoYXZlIG1hdGNoZWQgTDNCYW5r IGFuZAo+ICsJCSAqIHN1YnNsaWNlIGVuYWJsZWQKPiArCQkgKi8KPiArCQlXQVJOX09OKCEoKGZ1 c2UzICYgR0VOMTBfTDNCQU5LX01BU0spICYKPiArCQkJICAoKHNzX21hc2sgfCBzc19tYXNrID4+ IEdFTjEwX0wzQkFOS19QQUlSX0NPVU5UKSAmID4gKwkJCSAgIEdFTjEwX0wzQkFOS19NQVNLKSkp OwoKTWFzayBpbiBmdXNlMyBpcyB0aGUgZGlzYWJsZWQgbWFzayByaWdodCwgc2luY2UgQlNwZWMg Y2FsbHMgdGhlbSAiTDMgCkJhbmsgRGlzYWJsZSBTZWxlY3QiPwoKU2hvdWxkIHlvdSBub3QgYmUg Y2hlY2tpbmcgdGhhdCBub25lIG9mIHRoZSBlbmFibGVkIHNsaWNlcyBoYXZlIEwzQmFuayAKZGlz YWJsZWQsIHdoaWxlIHRoZSBhYm92ZSBsb29rcyBsaWtlIGl0IGNhbiBtaXNzIGEgcGFydGlhbCBt aXNtYXRjaD8gClNvbWV0aGluZyBsaWtlIHRoaXM6Cgp1OCBlbmFibGVkX21hc2sgPSAoc3NfbWFz ayB8IHNzX21hc2sgPj4gNCkgJiAweGY7CnU4IGRpc2FibGVkX21hc2sgPSBmdXNlMyAmIDB4ZjsK CldBUk5fT04oKGVuYWJsZWRfbWFzayAmIGRpc2FibGVkX21hc2spICE9IGVuYWJsZWRfbWFzayk7 Cgo+ICsJfQo+ICAgCj4gICAJbWNyID0gSTkxNV9SRUFEKEdFTjhfTUNSX1NFTEVDVE9SKTsKPiAg IAltY3IgPSBjYWxjdWxhdGVfbWNyKGRldl9wcml2LCBtY3IpOwo+IAoKUmVnYXJkcywKClR2cnRr bwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1n ZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK