From: Markus Elfring Date: Sat, 09 May 2020 08:00:13 +0000 Subject: Re: [PATCH 1/4] fs: btrfs: fix a data race in btrfs_block_group_done() Message-Id: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Jia-Ju Bai , linux-btrfs@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Chris Mason , David Sterba , Josef Bacik > To fix this race, the spinlock cache->lock is used to protect the > access to cache->cached in btrfs_block_group_done(). How do you think about to replace this wording by a variant like the following? Thus use the spin lock “cache->lock” to protect the access to the data structure member “cached” in the implementation of the function “btrfs_block_group_done”. Would you like to add the tag “Fixes” to the change description? Regards, Markus