From: "ordex (Code Review)" Date: Wed, 2 Jul 2025 12:21:36 +0000 In-Reply-To: References: Reply-To: antonio@...2726..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="kT5A8WQMYpA="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Fix new doxygen warnings about using @return in void functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld Cc: plaisthos , openvpn-devel --kT5A8WQMYpA= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/1029?usp=3Demail ) Change subject: Fix new doxygen warnings about using @return in void functi= ons ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: can we drop the part saying "Does not have a return value." ? We are not documenting @return anymore and functions are void. so it's pret= ty redundant -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1029?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia2b3eda18bd6dbce6c470037c7a01097e8147c29 Gerrit-Change-Number: 1029 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld Gerrit-Reviewer: ordex Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Wed, 02 Jul 2025 12:21:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --kT5A8WQMYpA= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld.

Patch set 1:Code-Review -1=

V= iew Change

1 comment:

  • Patchset:

    • Patch Set #1:

      can we drop the part saying "Does not h= ave a return value." ?
      We are not documenting @return anymore and f= unctions are void. so it's pretty redundant

T= o view, visit change 1029. To unsubscribe, or for help writing mail filters, vi= sit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ia2b3eda18bd6dbce6c470037c7a= 01097e8147c29
Gerrit-Change-Number: 1029
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: ordex <antonio@...2726...&= gt;
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Wed, 02 Jul 2025 12:21:36= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--kT5A8WQMYpA=--