Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CBEEBC433EF for ; Wed, 18 May 2022 15:12:22 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 152AD81D8C; Wed, 18 May 2022 17:12:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="IIEJ1QUb"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2566981D8C; Wed, 18 May 2022 17:12:18 +0200 (CEST) Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 921BF80FC8 for ; Wed, 18 May 2022 17:12:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=daniel.schwierzeck@gmail.com Received: by mail-ej1-x633.google.com with SMTP id ck4so184647ejb.8 for ; Wed, 18 May 2022 08:12:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=G5Z0dWOJLvpIp/M9Lf3muvOSkloVKvmT2INa02ouXXU=; b=IIEJ1QUb7hI6pCI51UJLR3kiQYmHveFkbCBXao+Tn/tUOQELfdgoVa+TCr1UTSLuYA YgWHhmLtxTO302+ybza3+GO5kOIoXmv+78QzXM5yqJir6VcDyU5mYY6l1H565DIJhZce DSMdi/NqO5GrxEh+FqyGxBODvQc9kHt7eniLLV76+Ly0QixcrY/7AEXwbAyHu5VspZqU NJ78t8GEpO70JaHtHWnrl+KLPKsbZNhrClvRkjtY+ce3qZ81Qs3mbMczuAAWbdn8m2f6 z1WhsdGV1Bh2w/IE/TqZxcXjReiVEPP7S55P2V5kr0VCNZ6prhPoYQ0VGl9VNsmnoZUQ AU/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=G5Z0dWOJLvpIp/M9Lf3muvOSkloVKvmT2INa02ouXXU=; b=eVUx2kjyY+Pj3Cck6FKayceci9JGD4YPx+Gv6OmDkguZHRTiMucvqcjIIqlI7icNre mdCBvZQqKGemiLAthGYdmdijFBW08PmpSbL/SjlaAxuzxh2sSt+H2aHk6/yVWMUXUX1E mZgwVBN6URIYpR3EkyvNrOkFpl5Zy4PxW3kQh1DFBTDOtFYBA/z6cdT8+W4Kd2IwWTq8 M2a3shJwzbMQX6Cxl3tkBY/R+6QVKNI6X/zBwjQ52Ga7qFXOOiYspyKTWabrVNsJowa+ kgLjgBe/S6r2tmt+7OtrazGKBbm6YXhEM0pDC/YLa+xicFcE58w2AkwmLCZnGRanO8bH fbHQ== X-Gm-Message-State: AOAM530tbkmdU38BXTdpiLCDcqWFMjiN/T36GzZ5rFqcnaDf1vQRPqJn Qq+Vd28ylv3nRisVkrddyx8GvtkuTnw= X-Google-Smtp-Source: ABdhPJzWLECZiye8Dwqz5Gfvtr49fscWARZgDIsqriEMd/vbtizysnr7ZHXgkNY/TxhtejVUXJFxYw== X-Received: by 2002:a17:907:3e90:b0:6f7:f63:78b6 with SMTP id hs16-20020a1709073e9000b006f70f6378b6mr62226ejc.3.1652886735069; Wed, 18 May 2022 08:12:15 -0700 (PDT) Received: from [192.168.10.30] (i5E8607DC.versanet.de. [94.134.7.220]) by smtp.gmail.com with ESMTPSA id k26-20020aa7c39a000000b0042617ba63cbsm1452810edq.85.2022.05.18.08.12.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 May 2022 08:12:14 -0700 (PDT) Message-ID: Date: Wed, 18 May 2022 17:12:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] Kconfig: hide options not intended for users in arch/Kconfig Content-Language: en-US To: Tom Rini Cc: u-boot@lists.denx.de, Masahiro Yamada References: <20220517205353.2653667-1-daniel.schwierzeck@gmail.com> <20220518121849.GV3901321@bill-the-cat> From: Daniel Schwierzeck In-Reply-To: <20220518121849.GV3901321@bill-the-cat> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 18.05.22 14:18, Tom Rini wrote: > On Tue, May 17, 2022 at 10:53:53PM +0200, Daniel Schwierzeck wrote: >> Those options show up in menuconfig when selecting ARM or MIPS which >> is dangerous if a user accidently sets them. This also clutters up the >> menuconfig top-level screen. Because those options should only be set >> by SoC specific or board specific configs, make them invisible. >> >> Signed-off-by: Daniel Schwierzeck >> >> --- >> >> arch/Kconfig | 14 +++++++------- >> 1 file changed, 7 insertions(+), 7 deletions(-) >> >> diff --git a/arch/Kconfig b/arch/Kconfig >> index 12de8a1165..e3e28d0628 100644 >> --- a/arch/Kconfig >> +++ b/arch/Kconfig >> @@ -365,7 +365,7 @@ config SYS_DISABLE_DCACHE_OPS >> this functionality. >> >> config SYS_IMMR >> - hex "Address for the Internal Memory-Mapped Registers (IMMR) window" >> + hex >> depends on PPC || FSL_LSCH2 || FSL_LSCH3 || ARCH_LS1021A >> default 0xFF000000 if MPC8xx >> default 0xF0000000 if ARCH_MPC8313 > > But now these aren't user selectable on the right platforms either. > Maybe we need more menu organization, and so can have sub-menus depend > on PPC, or whatever, and so things aren't cluttered on other > architectures? > my main concern was with SKIP_LOWLEVEL_INIT which definitely should not be selectable by the user. Maybe I was to overambitious with changing the SYS_IMMR option too, I could revert that part ;) BTW: SYS_IMMR seems to be specific for PPC. Maybe it could be moved to arch/powerpc/Kconfig? -- - Daniel