From: "cron2 (Code Review)" Date: Wed, 6 Aug 2025 18:05:50 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="6QTmBo6gt3M="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: buffer: remove unused function buf_write_alloc_prepend List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld , plaisthos Cc: openvpn-devel --6QTmBo6gt3M= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has uploaded a new patch set (#2) to the change originally created by= flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1134?usp=3Demail ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: buffer: remove unused function buf_write_alloc_prepend ...................................................................... buffer: remove unused function buf_write_alloc_prepend Change-Id: I71981e39932cafe3fd68b475fdb81a8f20a3a547 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Message-Id: <20250806144238.11332-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32= 565.html Signed-off-by: Gert Doering --- M src/openvpn/buffer.h 1 file changed, 0 insertions(+), 6 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/34/1134/2 diff --git a/src/openvpn/buffer.h b/src/openvpn/buffer.h index ae783c6..1405667 100644 --- a/src/openvpn/buffer.h +++ b/src/openvpn/buffer.h @@ -643,12 +643,6 @@ } static inline uint8_t * -buf_write_alloc_prepend(struct buffer *buf, int size, bool prepend) -{ - return prepend ? buf_prepend(buf, size) : buf_write_alloc(buf, size); -} - -static inline uint8_t * buf_read_alloc(struct buffer *buf, int size) { uint8_t *ret; -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1134?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I71981e39932cafe3fd68b475fdb81a8f20a3a547 Gerrit-Change-Number: 1134 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-MessageType: newpatchset --6QTmBo6gt3M= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 uploaded patch set #2 to the change originally cr= eated by flichtenheld.

View Change

The following approvals got outd= ated and were removed: Code-Review+2 by cron2

buffer: remove unused function buf_write_alloc_prepe=
nd

Change-Id: I71981e39932cafe3fd68b475fdb81a8f20a3a547
Signed-of= f-by: Frank Lichtenheld <frank@...2641...>
Acked-by: Gert Doering = <gert@...1296...>
Message-Id: <20250806144238.11332-1-gert@...1386...= 296...>
URL: https://www.mail-archive.com/openvpn-devel@...1535...= orge.net/msg32565.html
Signed-off-by: Gert Doering <gert@...1296...&g= t;
---
M src/openvpn/buffer.h
1 file changed, 0 insertions(+), 6 d= eletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/=
changes/34/1134/2
diff --git a/src/openvpn/buffer.h b/src/openvpn/b=
uffer.h
index ae783c6..1405667 100644
--- a= /src/openvpn/buffer.h
+++ b/src/openvpn/buffer.h
= @@ -643,12 +643,6 @@
}

<= span> static inline uint8_t *
-buf_write_alloc_prepend(struct buffer *buf, int size, bool prepend)=
-{
- return prepend ? buf_prepend(buf, siz= e) : buf_write_alloc(buf, size);
-}
--static inline uint8_t *=
buf_read_alloc(struct buffer *buf, int size)
{<= /span>
uint8_t *ret;

To v= iew, visit change 1134. To unsubscribe, or for help writing mail filters, visit= settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I71981e39932cafe3fd68b475fdb= 81a8f20a3a547
Gerrit-Change-Number: 1134
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-MessageType: newpatchset
--6QTmBo6gt3M=--