Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4156FC4338F for ; Fri, 30 Jul 2021 19:11:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 29BC260F36 for ; Fri, 30 Jul 2021 19:11:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231670AbhG3TLr (ORCPT ); Fri, 30 Jul 2021 15:11:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231472AbhG3TLh (ORCPT ); Fri, 30 Jul 2021 15:11:37 -0400 Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69EE2C0613D3 for ; Fri, 30 Jul 2021 12:11:32 -0700 (PDT) Received: by mail-pj1-x102c.google.com with SMTP id mt6so16670584pjb.1 for ; Fri, 30 Jul 2021 12:11:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=android.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=n8Xzq3g5EUvGu5nqxpWUkOTLx58MtbEpXoxV2GjBSeQ=; b=Sv7WsQpzJXuZ2SUhzG2bGjpWNnytpUZdCK8FYoFWF9yOt4mZznLl0b5TaHZC7Qu401 ChnKZAQFWipERZDAB1wdwpm+weuk5ABCbHWmkxILOkO6uCKJuakBpGwrGsxzM1RtC4k0 qEDUu4Tm1UonZUugjieoXPSLmFbmnayCWGU9qqr4S0OtvgXuaf2cCnFTOGNJEwAUxD2h Fgs/r/RrnYyywObNfkOltfO5503+Y0VfrDZbeQRFD+mwxRlPMaMkcjSdc+4lZp7Zt24f nmZmbYDIemJ0fA4/bqoNsQPXYKSEdsi1cEs1Mz0NdOtPsISC4V4z1wpTQbO5d/aUePbg xNbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=n8Xzq3g5EUvGu5nqxpWUkOTLx58MtbEpXoxV2GjBSeQ=; b=aSItgRZNuosUrt3T/ENOwvOUU5IBThtMzCJCGDaF6o641Jsc11QxWhZBGudXjpJLmH fhm94G/2mJOFp5gUZ0SOR6wLJC1/kv1xMmPGooNpCKQrRRbYuxtlv5zJC9BEqteMLoku U2U1V7U03qXhqRnw6/q3wP9wQSA394xz0t09lj+B3BjQ+aQn0X6hMD1emtT7KoMDmmi2 MDL3NfQWnixFaEEFN1jYYxvbZ5Qmvri8AtHj4JOGndD7xkhNcw0Os6eoyCNRAQC5OwjX jNsyzfzzn0/yp66hyHZ55LXJms26xhU6auwY1zocTMySLyxFPp/zj1eZlOcQIDV0fP8Z z3tw== X-Gm-Message-State: AOAM531vBdzwX1pTyuhPpExJ1Re71/2ogoi9Ue9T3y7NR2pg6AnNlYUW vektoYJELT0RFxVeLSUf7Gv0/Q== X-Google-Smtp-Source: ABdhPJyXyX6iKm7qrBPH2IumcnmmX6q4RO4ehWBMCE7OPZk8FXLocXu7ds1yO4SUF+quMbUTidipmQ== X-Received: by 2002:a65:40cc:: with SMTP id u12mr3008779pgp.18.1627672292048; Fri, 30 Jul 2021 12:11:32 -0700 (PDT) Received: from sspatil2.c.googlers.com (226.75.127.34.bc.googleusercontent.com. [34.127.75.226]) by smtp.gmail.com with ESMTPSA id y64sm3625985pgy.32.2021.07.30.12.11.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Jul 2021 12:11:31 -0700 (PDT) Subject: Re: [PATCH 1/1] fs: pipe: wakeup readers everytime new data written is to pipe To: Linus Torvalds Cc: linux-fsdevel , Linux Kernel Mailing List , David Howells , Greg Kroah-Hartman , stable , Android Kernel Team References: <20210729222635.2937453-1-sspatil@android.com> <20210729222635.2937453-2-sspatil@android.com> From: Sandeep Patil Message-ID: Date: Fri, 30 Jul 2021 19:11:29 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On 7/29/21 11:01 PM, Linus Torvalds wrote: > On Thu, Jul 29, 2021 at 3:27 PM Sandeep Patil wrote: >> >> So restore the old behavior to wakeup all readers if any new data is >> written to the pipe. > > Ah-hahh. > > I've had this slightly smaller patch waiting for the better part of a year: > > https://lore.kernel.org/lkml/CAHk-=wgjR7Nd4CyDoi3SH9kPJp_Td9S-hhFJZMqvp6GS1Ww8eg@mail.gmail.com/ > > waiting to see if some broken program actually depends on the bogus > epollet semantics. > > Can you verify that that patch fixes the realm-core brokenness too? Yes, your patch fixes all apps on Android I can test that include this library. fwiw, the library seems to have been fixed. However, I am not sure how long it will be for all apps to take that update :(. - ssp