From: Michel Thierry Subject: Re: [PATCH] drm/i915/guc: Don't make assumptions while getting the lrca offset Date: Tue, 11 Jul 2017 18:01:29 -0700 Message-ID: References: <20170711212939.12185-1-michel.thierry@intel.com> <149981264355.28871.1114774176461935999@mail.alporthouse.com> <149981760221.28871.14164331043471599204@mail.alporthouse.com> <149981806045.28871.3423216070968756838@mail.alporthouse.com> <7886e4fe-533d-ed60-8a2d-d2534467e8c9@intel.com> <149982086896.29488.17819910687816256180@mail.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 770CE897B4 for ; Wed, 12 Jul 2017 01:01:30 +0000 (UTC) In-Reply-To: <149982086896.29488.17819910687816256180@mail.alporthouse.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gNy8xMS8yMDE3IDU6NTQgUE0sIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIE1pY2hl bCBUaGllcnJ5ICgyMDE3LTA3LTEyIDAxOjE0OjQ2KQo+PiBPbiA3LzExLzIwMTcgNTowNyBQTSwg Q2hyaXMgV2lsc29uIHdyb3RlOgo+Pj4gUXVvdGluZyBDaHJpcyBXaWxzb24gKDIwMTctMDctMTIg MDE6MDA6MDIpCj4+Pj4gQWxzbyBmZWVsIGZyZWUgdG8gdHJ5IGFuZCBmaXh1cCB0aGUgb3RoZXIg Y29uZnVzaW9uIGluIGludGVsX2xyYy5jLgo+Pj4+IFBlcmhhcHMgc29tZXRoaW5nIGxpa2U6Cj4+ Pj4KPj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+Pj4+IGluZGV4IGIwNzM4ZDIuLmY0OThh YTYgMTAwNjQ0Cj4+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPj4+ PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+Pj4+IEBAIC0yMDMxLDgg KzIwMzEsOSBAQCBzdGF0aWMgaW50IGV4ZWNsaXN0c19jb250ZXh0X2RlZmVycmVkX2FsbG9jKHN0 cnVjdCBpOTE1X2dlbV9jb250ZXh0ICpjdHgsCj4+Pj4gICAgCj4+Pj4gICAgICAgICAgIGNvbnRl eHRfc2l6ZSA9IHJvdW5kX3VwKGVuZ2luZS0+Y29udGV4dF9zaXplLCBJOTE1X0dUVF9QQUdFX1NJ WkUpOwo+Pj4+ICAgIAo+Pj4+IC0gICAgICAgLyogT25lIGV4dHJhIHBhZ2UgYXMgdGhlIHNoYXJp bmcgZGF0YSBiZXR3ZWVuIGRyaXZlciBhbmQgR3VDICovCj4+Pj4gLSAgICAgICBjb250ZXh0X3Np emUgKz0gUEFHRV9TSVpFICogTFJDX1BQSFdTUF9QTjsKPj4+PiArICAgICAgIC8qIEFkZCBhbiBl eHRyYSBwYWdlIGF0IHRoZSBzdGFydCBmb3Igc2hhcmluZyBkYXRhIHdpdGggdGhlIEd1QyAqLwo+ Pj4+ICsgICAgICAgQlVJTERfQlVHX09OKExSQ19QUEhXU1BfUE4gIT0gMSk7Cj4+Pj4gKyAgICAg ICBjb250ZXh0X3NpemUgKz0gUEFHRV9TSVpFOwo+Pj4+ICAgIAo+Pj4+ICAgICAgICAgICBjdHhf b2JqID0gaTkxNV9nZW1fb2JqZWN0X2NyZWF0ZShjdHgtPmk5MTUsIGNvbnRleHRfc2l6ZSk7Cj4+ Pj4gICAgICAgICAgIGlmIChJU19FUlIoY3R4X29iaikpIHsKPj4+Cj4+PiBPciBiZXR0ZXIKPj4+ Cj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+Pj4gaW5kZXggYjA3MzhkMi4uMGI3ZmIzOCAx MDA2NDQKPj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4+PiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+Pj4gQEAgLTIwMzEsOCArMjAzMSw4 IEBAIHN0YXRpYyBpbnQgZXhlY2xpc3RzX2NvbnRleHRfZGVmZXJyZWRfYWxsb2Moc3RydWN0IGk5 MTVfZ2VtX2NvbnRleHQgKmN0eCwKPj4+ICAgIAo+Pj4gICAgICAgICAgIGNvbnRleHRfc2l6ZSA9 IHJvdW5kX3VwKGVuZ2luZS0+Y29udGV4dF9zaXplLCBJOTE1X0dUVF9QQUdFX1NJWkUpOwo+Pj4g ICAgCj4+PiAtICAgICAgIC8qIE9uZSBleHRyYSBwYWdlIGFzIHRoZSBzaGFyaW5nIGRhdGEgYmV0 d2VlbiBkcml2ZXIgYW5kIEd1QyAqLwo+Pj4gLSAgICAgICBjb250ZXh0X3NpemUgKz0gUEFHRV9T SVpFICogTFJDX1BQSFdTUF9QTjsKPj4+ICsgICAgICAgLyogQWRkIGFuIGV4dHJhIHBhZ2UgYXQg dGhlIHN0YXJ0IGZvciBzaGFyaW5nIGRhdGEgd2l0aCB0aGUgR3VDICovCj4+PiArICAgICAgIGNv bnRleHRfc2l6ZSArPSBMUkNfR1VDU0hSX1BBR0VTICogUEFHRV9TSVpFOwo+IAo+IE9uZSBtb3Jl IHRob3VnaHQgYWJvdXQgdGhpcywgYW5kIHdpdGggYSBsaXR0bGUgY29heGluZyBMUkNfUFBIV1NQ X1BOIG1heQo+IGJlIHRoZSBtb3N0IGFwcHJvcHJpYXRlIGNvbnN0YW50IHRvIHVzZSBoZXJlLgo+ IAo+IC8qIEJlZm9yZSB0aGUgYWN0dWFsIHN0YXJ0IG9mIHRoZSBjb250ZXh0IGltYWdlLCB3ZSBp bnNlcnQgYSBmZXcgcGFnZXMKPiAgICogZm9yIG91ciBvd24gdXNlIGFuZCBmb3Igc2hhcmluZyB3 aXRoIHRoZSBHdUMuCj4gICAqLwo+IGNvbnRleHRfc2l6ZSArPSBMUkNfSEVBREVSX1BBR0VTICog UEFHRV9TSVpFOwo+IAo+Pj4gICAgICAgICAgIGN0eF9vYmogPSBpOTE1X2dlbV9vYmplY3RfY3Jl YXRlKGN0eC0+aTkxNSwgY29udGV4dF9zaXplKTsKPj4+ICAgICAgICAgICBpZiAoSVNfRVJSKGN0 eF9vYmopKSB7Cj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJj LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuaAo+Pj4gaW5kZXggNTJiM2ExZi4u ODQ4Y2EyMSAxMDA2NDQKPj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5o Cj4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuaAo+Pj4gQEAgLTcyLDcg KzcyLDggQEAgaW50IGxvZ2ljYWxfeGNzX3JpbmdfaW5pdChzdHJ1Y3QgaW50ZWxfZW5naW5lX2Nz ICplbmdpbmUpOwo+Pj4gICAgCj4+PiAgICAvKiBPbmUgZXh0cmEgcGFnZSBpcyBhZGRlZCBiZWZv cmUgTFJDIGZvciBHdUMgYXMgc2hhcmVkIGRhdGEgKi8KPj4+ICAgICNkZWZpbmUgTFJDX0dVQ1NI Ul9QTiAgKDApCj4+PiAtI2RlZmluZSBMUkNfUFBIV1NQX1BOICAoTFJDX0dVQ1NIUl9QTiArIDEp Cj4+PiArI2RlZmluZSBMUkNfR1VDU0hSX1BBR0VTIDEKPj4+ICsjZGVmaW5lIExSQ19QUEhXU1Bf UE4gIChMUkNfR1VDU0hSX1BOICsgTFJDX0dVQ1NIUl9QQUdFUykKPj4+ICAgICNkZWZpbmUgTFJD X1NUQVRFX1BOICAgKExSQ19QUEhXU1BfUE4gKyAxKQo+IAo+IGJ1dAo+IAo+IC8qIFdlIGFsbG9j YXRlIGEgaGVhZGVyIGF0IHRoZSBzdGFydCBvZiB0aGUgY29udGV4dCBpbWFnZSBmb3Igb3VyIG93 bgo+ICAgKiB1c2UsIHRoZXJlZm9yZSB0aGUgYWN0dWFsIGxvY2F0aW9uIG9mIHRoZSBsb2dpY2Fs IHN0YXRlIGlzIG9mZnNldAo+ICAgKiBmcm9tIHRoZSBzdGFydCBvZiB0aGUgVk1BLiBUaGUgbGF5 b3V0IGlzCj4gICAqCj4gICAqIHwgW2d1Y10gICAgICAgICAgfCBbaHdzcF0gW2xvZ2ljYWwgc3Rh dGVdIHwKPiAgICogfDwtIG91ciBoZWFkZXIgLT58PC0gY29udGV4dCBpbWFnZSAgICAgIC0+fAo+ ICAgKgo+ICAgKi8KPiAKPiAvKiBPbmUgZXh0cmEgcGFnZSBpcyB1c2VkIGZvciBzaGFyaW5nIHdp dGggdGhlIEd1QyAqLwo+ICNkZWZpbmUgTFJDX0dVQ1NIUl9QTiAgKDApCj4gI2RlZmluZSBMUkNf R1VDU0hSX1BBR0VTIDEKPiAKPiAvKiBBdCB0aGUgc3RhcnQgb2YgdGhlIGNvbnRleHQgaW1hZ2Ug aXMgaXRzIHBlci1wcm9jZXNzIEhXUyBwYWdlICovCj4gI2RlZmluZSBMUkNfUFBIV1NQX1BOICAo TFJDX0dVQ1NIUl9QTiArIExSQ19HVUNTSFJfUEFHRVMpCj4gCj4gLyogRmluYWxseSB3ZSBoYXZl IHRoZSBsb2dpY2FsIHN0YXRlIGZvciB0aGUgY29udGV4dCAqLwo+ICNkZWZpbmUgTFJDX1NUQVRF X1BOICAgKExSQ19QUEhXU1BfUE4gKyAxKQo+IAo+IC8qIEN1cnJlbnRseSB3ZSBpbmNsdWRlIHRo ZSBQUEhXU1AgaW4gX19pbnRlbF9lbmdpbmVfY29udGV4dF9zaXplKCkgc28KPiAgICogdGhlIHNp emUgb2YgdGhlIGhlYWRlciBpcyBzeW5vbnltb3VzIHdpdGggdGhlIHN0YXJ0IG9mIHRoZSBQUEhX U1AuCj4gICAqLwo+ICNkZWZpbmUgTFJDX0hFQURFUl9QQUdFUyBMUkNfUFBIV1NQX1BOCj4gCgpJ dCBjYW5ub3QgYmUgY2xlYXJlciBub3cuCgpUaGUgb25seSBleHRyYSB0aGluZyBJIHdhcyB0aGlu a2luZyBhYm91dCB3YXMgYWxzbyBkZWZpbmluZyB0aGUgJ3NpemUnIAoobGVuZ3RoPykgb2YgdGhl IGd1YyBhbmQgcHBod3NwIHNlY3Rpb25zLCBpbiBjYXNlIHRob3NlICIrIDEiIHdlcmUgbm90IApj bGVhcjoKCgogICNkZWZpbmUgTFJDX0dVQ1NIUl9QTiAgKDApCi0jZGVmaW5lIExSQ19QUEhXU1Bf UE4gIChMUkNfR1VDU0hSX1BOICsgMSkKLSNkZWZpbmUgTFJDX1NUQVRFX1BOICAgKExSQ19QUEhX U1BfUE4gKyAxKQorI2RlZmluZSBMUkNfR1VDU0hSX1NaICAoMSkKKyNkZWZpbmUgTFJDX1BQSFdT UF9QTiAgKExSQ19HVUNTSFJfUE4gKyBMUkNfR1VDU0hSX1NaKQorI2RlZmluZSBMUkNfUFBIV1NQ X1NaICAoMSkKKyNkZWZpbmUgTFJDX1NUQVRFX1BOICAgKExSQ19QUEhXU1BfUE4gKyBMUkNfUFBI V1NQX1NaKQoKPj4+ICAgIAo+Pj4gICAgc3RydWN0IGRybV9pOTE1X3ByaXZhdGU7Cj4+Pgo+Pj4g Tm93aGVyZSBkbyB3ZSB1c2UgTFJDX0dVQ1NIUl9QTi4gSGF2aW5nIGl0IGp1c3QgZ2l2ZXMgdXMg dGhlIG1pcmFnZSBvZgo+Pj4gZmxleGliaWxpdHkuLi4KPj4KPj4gTFJDX0dVQ1NIUl9QTiBpcyBu b3QgdXNlZCBiZWNhdXNlIHBlb3BsZSBhc3N1bWVkIGl0IGlzIGFsd2F5cyBwYWdlIDAgb2YKPj4g dGhlIGtlcm5lbCBjdHggOlMKPj4KPj4gT25lIG1vcmUgdGhpbmcgdG8gZml4LCB1c2UgTFJDX0dV Q1NIUl9QTiBpbiBhbGwgdGhlIHBsYWNlcyB3aGVyZSB0aGlzCj4+IF9zaGFyZWRfIEd1QyBwYWdl IGlzIHVzZWQgKGd1Y19nZ3R0X29mZnNldChjdHgtPmVuZ2luZVtSQ1NdLnN0YXRlKSkKPiAKPiBU aGF0IG1heSBwcm92ZSB2ZXJ5IGhhbmR5Lgo+IC1DaHJpcwo+IApfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVs LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK