From: "ordex (Code Review)" Date: Tue, 28 Jan 2025 14:22:23 +0000 In-Reply-To: References: Reply-To: a@...2181..., arne-openvpn@...1227..., gianmarco@...2726..., openvpn-devel@lists.sourceforge.net, frank@...2641..., gert@...1296... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="Yya6gYv8ucM="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: mroute/management: fix unitialized variable (UNINIT) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: its_Giaan Cc: cron2 , plaisthos , flichtenheld , openvpn-devel --Yya6gYv8ucM= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: cron2, flichtenheld, its_Giaan, plais= thos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/880?usp=3Demail ) Change subject: mroute/management: fix unitialized variable (UNINIT) ...................................................................... Patch Set 1: (1 comment) File src/openvpn/manage.c: http://gerrit.openvpn.net/c/openvpn/+/880/comment/387f5a9f_83884c97 : PS1, Line 573: port, p3); > not sure we should use `p3` here (what if a user sends 'foo'?). [=E2=80= =A6] passing 'foo' will lead to ascii2proto() returning -1, which in turn will l= ead to "no client found", so we won't hit this print -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/880?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I4be0ff4d308213d2ef8ba66bd3178eee1f60fff1 Gerrit-Change-Number: 880 Gerrit-PatchSet: 1 Gerrit-Owner: its_Giaan Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-CC: ordex Gerrit-Attention: plaisthos Gerrit-Attention: cron2 Gerrit-Attention: its_Giaan Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Tue, 28 Jan 2025 14:22:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 Gerrit-MessageType: comment --Yya6gYv8ucM= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: cron2, flichtenheld, its_Giaan, p= laisthos.

View C= hange

1 comment:

    <= li style=3D"margin: 0; padding: 0;">

    File src/openvpn/manage.c:

    • Patch Set #1, Line 573: = = port, p3);

      not sure we should use `p3` here (what if= a user sends 'foo'?). [=E2=80=A6]

      passing 'foo' will lead = to ascii2proto() returning -1, which in turn will lead to "no client f= ound", so we won't hit this print

To vie= w, visit = change 880. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I4be0ff4d308213d2ef8ba66bd31= 78eee1f60fff1
Gerrit-Change-Number: 880
Gerrit-PatchSet: 1
Gerrit-Owner: its_Giaan <gianmarco@...2786...= ..>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-CC: ordex <a@...2181...>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: cron2 <gert@...1296...>= ;
Gerrit-Attention: its_Giaan <gianmarco@...1665...= 726...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Tue, 28 Jan 2025 14:22:23= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2 <gert@...1296...= >
Gerrit-MessageType: comment
--Yya6gYv8ucM=--