Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B26EDC433EF for ; Sun, 20 Mar 2022 18:48:17 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A9DC683981; Sun, 20 Mar 2022 19:48:14 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="m2wXvU2y"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id ECAEF83960; Sun, 20 Mar 2022 19:48:12 +0100 (CET) Received: from mail-qv1-xf35.google.com (mail-qv1-xf35.google.com [IPv6:2607:f8b0:4864:20::f35]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A481C839C6 for ; Sun, 20 Mar 2022 19:48:09 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qv1-xf35.google.com with SMTP id kl29so3830985qvb.2 for ; Sun, 20 Mar 2022 11:48:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ioRxAuMlTap3O9XX4J0Qq38RlmSilam/iRSqQJzzAmk=; b=m2wXvU2yGoK1g1AIBNkIVf47v4RAiy7Gpk6J8QG2HaCFEwTkCFnNDUy8F6QtbEHioB AxnvspT8+mLgQWC63s3N8jXMEpvKWufE4zswkYYDfE6++AJk6RHKtzzH57Smjx/g+Uy4 c+vk2wAFucUb66zoTEbYfAV18KYZVeCug6W3jQ7ELewZFtPGx5msxpsS2PuWd/Mjq/58 PcmFSGBNtgqez6AZQMKNGlXqzn6g/obs5psRDSXQSfRaF0n7byOzyR4vwb/LimUlZ3VZ a9IxBnU1BruptuFrV/exPTr62eDdypONKzalZUhgn3MKRtPGF0/hGaP9/Pks5jT0LXFd S+dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ioRxAuMlTap3O9XX4J0Qq38RlmSilam/iRSqQJzzAmk=; b=v/ScnRZFU9hHd0DGjwwIqpO1yHBrh2WlXBWP+/aTb1oST5jpiG0TCSyEUDvaeUeM5t k1xOc3wf7uLrknZzb4zhY/yOJUH0M+qPRVu+PACfgPu7FIG0E0AUl+RLzTQhL3UMrosB BsGMgRcZXWosUcwzTYGkxypFLmQY55QBuB4l79o/4gYGdHCV31WD/Or23K56NNx7Qi/k qqUYHzYiHEv4CMaf3D244n5V4ZhuJxrajQOfUUXf/2ZmTkcztm20HK96i/zoJI0cfEi/ +T8iZ3DaAQ9THonoC+EIPFxTbCgGfxRRWFoC5tLl4rNlcnsX4jS6vQ4hKxVSN/GpsQBH MWMA== X-Gm-Message-State: AOAM532sTjNwAxHWxfEPsBrhsjLDKMOWz0qy2X7eM3qUPnqf7b1Urofv 0rOfCoZvmBYQuq3FN0uTYSs= X-Google-Smtp-Source: ABdhPJwdXr9WapWkKSj1lqs3RGBaQgABqRUvgAv4i0kX/gzn4mFR4f+yGKX1B8V0gaW6zr3wWTpkrQ== X-Received: by 2002:a05:6214:29ef:b0:440:ce48:e185 with SMTP id jv15-20020a05621429ef00b00440ce48e185mr13680696qvb.40.1647802088336; Sun, 20 Mar 2022 11:48:08 -0700 (PDT) Received: from [192.168.1.201] (pool-108-18-137-133.washdc.fios.verizon.net. [108.18.137.133]) by smtp.googlemail.com with ESMTPSA id 70-20020a370649000000b0067b4cd8ffbasm6795954qkg.60.2022.03.20.11.48.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Mar 2022 11:48:07 -0700 (PDT) Subject: Re: [PATCH v1 4/8] clk: imx: Add i.MXRT11xx pllv3 variant To: Jesse Taube , u-boot@lists.denx.de Cc: sbabic@denx.de, festevam@gmail.com, festevam@denx.de, uboot-imx@nxp.com, giulio.benetti@benettiengineering.com, lukma@denx.de, sjg@chromium.org, jagan@amarulasolutions.com, kever.yang@rock-chips.com, andre.przywara@arm.com, pbrobinson@gmail.com, tharvey@gateworks.com, paul.liu@linaro.org, christianshewitt@gmail.com, samuel@sholland.org References: <20220317183300.315173-1-Mr.Bossman075@gmail.com> <20220317183300.315173-5-Mr.Bossman075@gmail.com> From: Sean Anderson Message-ID: Date: Sun, 20 Mar 2022 14:48:05 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20220317183300.315173-5-Mr.Bossman075@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 3/17/22 2:32 PM, Jesse Taube wrote: > The i.MXRT11 series has two new pll types but are variants of existing. > This patch adds the ability to read one of the pll types' frequency > as it can't be changed unlike the generic pll it also has the > division factors swapped. > > Signed-off-by: Jesse Taube > --- > drivers/clk/imx/clk-pllv3.c | 44 +++++++++++++++++++++++++++++++++++++ > drivers/clk/imx/clk.h | 1 + > 2 files changed, 45 insertions(+) > > diff --git a/drivers/clk/imx/clk-pllv3.c b/drivers/clk/imx/clk-pllv3.c > index 077757efcb..511c973e5c 100644 > --- a/drivers/clk/imx/clk-pllv3.c > +++ b/drivers/clk/imx/clk-pllv3.c > @@ -21,6 +21,7 @@ > #define UBOOT_DM_CLK_IMX_PLLV3_USB "imx_clk_pllv3_usb" > #define UBOOT_DM_CLK_IMX_PLLV3_AV "imx_clk_pllv3_av" > #define UBOOT_DM_CLK_IMX_PLLV3_ENET "imx_clk_pllv3_enet" > +#define UBOOT_DM_CLK_IMX_PLLV3_GENV2 "imx_clk_pllv3_genericv2" > > #define PLL_NUM_OFFSET 0x10 > #define PLL_DENOM_OFFSET 0x20 > @@ -42,6 +43,30 @@ struct clk_pllv3 { > > #define to_clk_pllv3(_clk) container_of(_clk, struct clk_pllv3, clk) > > +static ulong clk_pllv3_genericv2_get_rate(struct clk *clk) > +{ > + struct clk_pllv3 *pll = to_clk_pllv3(dev_get_clk_ptr(clk->dev)); > + unsigned long parent_rate = clk_get_parent_rate(clk); > + > + u32 div = (readl(pll->base) >> pll->div_shift) & pll->div_mask; > + > + return (div == 0) ? parent_rate * 22 : parent_rate * 20; > +} > + > +static ulong clk_pllv3_genericv2_set_rate(struct clk *clk, ulong rate) > +{ > + struct clk_pllv3 *pll = to_clk_pllv3(clk); > + unsigned long parent_rate = clk_get_parent_rate(clk); > + > + u32 div = (readl(pll->base) >> pll->div_shift) & pll->div_mask; > + u32 val = (div == 0) ? parent_rate * 22 : parent_rate * 20; > + > + if (rate == val) > + return 0; > + > + return -EINVAL; > +} > + > static ulong clk_pllv3_generic_get_rate(struct clk *clk) > { > struct clk_pllv3 *pll = to_clk_pllv3(dev_get_clk_ptr(clk->dev)); > @@ -120,6 +145,13 @@ static const struct clk_ops clk_pllv3_generic_ops = { > .set_rate = clk_pllv3_generic_set_rate, > }; > > +static const struct clk_ops clk_pllv3_genericv2_ops = { > + .get_rate = clk_pllv3_genericv2_get_rate, > + .enable = clk_pllv3_generic_enable, > + .disable = clk_pllv3_generic_disable, > + .set_rate = clk_pllv3_genericv2_set_rate, > +}; > + > static ulong clk_pllv3_sys_get_rate(struct clk *clk) > { > struct clk_pllv3 *pll = to_clk_pllv3(clk); > @@ -269,6 +301,11 @@ struct clk *imx_clk_pllv3(enum imx_pllv3_type type, const char *name, > pll->div_shift = 0; > pll->powerup_set = false; > break; > + case IMX_PLLV3_GENERICV2: > + drv_name = UBOOT_DM_CLK_IMX_PLLV3_GENV2; > + pll->div_shift = 0; > + pll->powerup_set = false; > + break; > case IMX_PLLV3_SYS: > drv_name = UBOOT_DM_CLK_IMX_PLLV3_SYS; > pll->div_shift = 0; > @@ -313,6 +350,13 @@ U_BOOT_DRIVER(clk_pllv3_generic) = { > .flags = DM_FLAG_PRE_RELOC, > }; > > +U_BOOT_DRIVER(clk_pllv3_genericv2) = { > + .name = UBOOT_DM_CLK_IMX_PLLV3_GENV2, > + .id = UCLASS_CLK, > + .ops = &clk_pllv3_genericv2_ops, > + .flags = DM_FLAG_PRE_RELOC, > +}; > + > U_BOOT_DRIVER(clk_pllv3_sys) = { > .name = UBOOT_DM_CLK_IMX_PLLV3_SYS, > .id = UCLASS_CLK, > diff --git a/drivers/clk/imx/clk.h b/drivers/clk/imx/clk.h > index 60f287046b..10670252b1 100644 > --- a/drivers/clk/imx/clk.h > +++ b/drivers/clk/imx/clk.h > @@ -10,6 +10,7 @@ > > enum imx_pllv3_type { > IMX_PLLV3_GENERIC, > + IMX_PLLV3_GENERICV2, > IMX_PLLV3_SYS, > IMX_PLLV3_USB, > IMX_PLLV3_USB_VF610, > Acked-by: Sean Anderson