From: Stefan Agner Date: Mon, 07 Jan 2019 17:36:15 +0100 Subject: [U-Boot] [PATCH v1 3/9] configs: colibri_imx7: enable DM for raw NAND devices In-Reply-To: <2c447847dbd0363068822039a531e04c4ccfad68.camel@toradex.com> References: <20190106210049.30918-1-stefan@agner.ch> <20190106210049.30918-4-stefan@agner.ch> <2c447847dbd0363068822039a531e04c4ccfad68.camel@toradex.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 07.01.2019 00:25, Marcel Ziswiler wrote: > On Sun, 2019-01-06 at 22:00 +0100, Stefan Agner wrote: >> From: Stefan Agner >> >> Use DM and device trees for raw NAND devices by default. This >> fixes -74 NAND read errors since it makes sure the ECC settings >> are the same as used in Linux and our downstream U-Boot. >> >> Signed-off-by: Stefan Agner >> --- >> >> configs/colibri_imx7_defconfig | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/configs/colibri_imx7_defconfig >> b/configs/colibri_imx7_defconfig >> index 7441102ed4..3aaf1a417d 100644 >> --- a/configs/colibri_imx7_defconfig >> +++ b/configs/colibri_imx7_defconfig >> @@ -25,6 +25,7 @@ CONFIG_CMD_DFU=y >> CONFIG_CMD_GPIO=y >> CONFIG_CMD_I2C=y >> CONFIG_CMD_MMC=y >> +CONFIG_CMD_MTD=y >> CONFIG_CMD_NAND_TRIMFFS=y >> CONFIG_CMD_NAND_TORTURE=y >> CONFIG_CMD_USB=y >> @@ -50,7 +51,9 @@ CONFIG_DFU_MMC=y >> CONFIG_DM_GPIO=y >> CONFIG_DM_I2C=y >> CONFIG_FSL_ESDHC=y >> +CONFIG_MTD=y >> CONFIG_NAND=y >> +CONFIG_NAND_MXS_DT=y >> CONFIG_MTD_UBI_FASTMAP=y >> CONFIG_PHYLIB=y >> CONFIG_PHY_MICREL=y > > We might want to add the following as well: > > CONFIG_DFU_NAND=y > > Plus I do not understand why we do not use CONFIG_DISTRO_DEFAULTS which would > include a lot of our now manually picked configuration items. Hm, good catch. There is CONFIG_DFU_MMC enabled for some reason, seemed to have slipped in in a Kconfig move. Will fix this. -- Stefan