Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DATE_IN_PAST_06_12, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 878A3C43331 for ; Tue, 31 Mar 2020 12:38:17 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 11539208E4 for ; Tue, 31 Mar 2020 12:38:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="clsOsdxx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 11539208E4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 745DC1660; Tue, 31 Mar 2020 14:37:25 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 745DC1660 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1585658295; bh=sZFOXXvTDxefyCXONcNx7z2eZrg27oYbPnm8Ui/dGOk=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=clsOsdxx4IfqTRo9rwphOAO0DoPeimgpWd4VAbRy5Ii+MH5GCsp8aMS+bk8dm89FF X6Qn8w5R4J9XVxnJGZLDZUDvUGlG6Iu5oOJvjCRJTMsnv1z/MkC5H2hXsrEKLY+qhG Nzy6yOXUqVnf6VxZ6YJxfbTh3oS0OUArrQFkhRfc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 10781F8014F; Tue, 31 Mar 2020 14:37:25 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1F4E1F80157; Tue, 31 Mar 2020 14:37:23 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id F347FF8010C for ; Tue, 31 Mar 2020 14:37:18 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz F347FF8010C IronPort-SDR: oZXMcHHveDeAfbfbFnsQaRBBgHjPw/wwbyhy0N2lxNmGe/xlkbfn/6qZMrFH75bL8KMwqRrNzn LIt8osbPJBeQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2020 04:44:41 -0700 IronPort-SDR: 6NC5DNzzhZzqdYL8y+kWiysUfk9djPWjYH30OVtAoLZ1puj7smnLaSMEDKTL0pHEXLIT8kMrfd zbbDDDAM8csQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,327,1580803200"; d="scan'208";a="240100557" Received: from kmariste-mobl.amr.corp.intel.com (HELO [10.212.248.138]) ([10.212.248.138]) by fmsmga007.fm.intel.com with ESMTP; 31 Mar 2020 04:44:39 -0700 Subject: Re: [PATCH 3/4] ASoC: Intel: bdw-rt5677: Remove ignore_suspend flag from SSP0 dai link To: Hans de Goede , Cezary Rojewski , alsa-devel@alsa-project.org References: <20200319204947.18963-1-cezary.rojewski@intel.com> <20200319204947.18963-4-cezary.rojewski@intel.com> <259cbb60-9e59-1132-8371-83f837577f86@redhat.com> From: Pierre-Louis Bossart Message-ID: Date: Mon, 30 Mar 2020 18:49:30 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <259cbb60-9e59-1132-8371-83f837577f86@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Cc: Kuninori Morimoto , Curtis Malainey , tiwai@suse.com, Dominik Brodowski , lgirdwood@gmail.com, vkoul@kernel.org, broonie@kernel.org, Ben Zhang X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" >> Btw the .ignore_suspend is also set in bytcr_rt5640/51 drivers, so >> wondering if additional devices are broken, or if there's something >> off about Broadwell in general. Hans, have you heard of any >> regressions on Baytrail devices? > > I've just tested 5.6.0 on Bay Trail + a rt5651 codec, > using the bytcr_rt5651 machine driver which sets > ignore_suspend, as well as on a Cherry Trail + rt5645 > device using the chtrt5645 machine driver which does > _not_ set ignore suspend. > > Suspend/resume work fine on both and music playing > before suspend continues playing after suspend. Thanks for testing Hans. I think we should remove those .ignore_suspend from all Baytrail/Cherrytrail drivers, no one ever enabled advanced power management except in very specific Android distributions that are no longer maintained. > > Note that the bytcr_rt5651 machine driver also does: > >         snd_soc_dapm_ignore_suspend(&card->dapm, "Headphone"); >         snd_soc_dapm_ignore_suspend(&card->dapm, "Speaker"); > > Which the bdw-rt5677 seems to not do... On the bytcr_rt5661, these two lines were added in the initial code in 2016, and it's also part of the legacy byt-rt5640, so it's likely a copy/paste more than a feature added on purpose.