Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3FADC433ED for ; Mon, 26 Apr 2021 09:26:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6DC4060FD7 for ; Mon, 26 Apr 2021 09:26:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232295AbhDZJ1h (ORCPT ); Mon, 26 Apr 2021 05:27:37 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:32546 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232078AbhDZJ1g (ORCPT ); Mon, 26 Apr 2021 05:27:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619429214; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vH6PHPNVgW+soUmxRszQomSaWOt8Rjil2he/aOQ/Phk=; b=Co3Q35LPMFYZaaApF0UYuFI1Qgz1inCq2z/dqIrHirZJJv3blpkJ3Iy7vU1vsg6so5QPFf rHU07+QfavA6JH1e5915nVXtoo1M9IDFZXJ7vdVXlddRllK+TwnhEvFxOeMkkc6sMZp/S4 kAOaMz58B/5Faai0Jzi39dK9Lzf/Xuo= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-195-F_dnZytPP02nKoBvr0JL-A-1; Mon, 26 Apr 2021 05:26:52 -0400 X-MC-Unique: F_dnZytPP02nKoBvr0JL-A-1 Received: by mail-ej1-f71.google.com with SMTP id d16-20020a1709066410b0290373cd3ce7e6so9933811ejm.14 for ; Mon, 26 Apr 2021 02:26:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vH6PHPNVgW+soUmxRszQomSaWOt8Rjil2he/aOQ/Phk=; b=jMHyP0DHKj39BHv8HVnDgh/aHKJ7oWmdMjli2Af67Q9LDsMEDTcljhw3vGDxmJ8X+j x56GUagSc5qvQkB9DXJ2qIlXwYOeAswioW90OvhX6wzw/jZMj3ViJ2A0YGUtAZkj7Vy5 xwdeoPkBYHDu8jWtDcUjpfzS5Fazdjv2T2KQcKFi3lc3Xxi+D3tBNGuznKFyUVOafN2Y ed/aFDtkLEWTlQ2/cLupHHAPv/pp3tgcgK6vPX6I6Wyt3dVMjwUtCajJylOQkFoXHAxq CJzK54NkTChGoj7keuY8xS3kE5p1diMHmjuo0SZN3DhsSOPNxc5WlTlYEHr3a72GgRcy g+uA== X-Gm-Message-State: AOAM530F22UXaQrDrk9zYkRg8VpO3XDo+h+o/0XOpg9nqV6zj4/oaWQd 3Yb9Kv8PU/VeJOafTBeOzVy8AM8OZSNCRWJLz7sgxux0KwT6EPcEWqh/bWuRWcsbVxwQfDgM86y +jC3SIyssQVK7 X-Received: by 2002:a17:906:a20c:: with SMTP id r12mr17172408ejy.554.1619429211735; Mon, 26 Apr 2021 02:26:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwIG7lPi5sdNtiMpin1qypwCFkStCx7GpzPsoj3D7lTuaFljiDF8g9+X8i2u+/SseKLlBOPhg== X-Received: by 2002:a17:906:a20c:: with SMTP id r12mr17172399ejy.554.1619429211540; Mon, 26 Apr 2021 02:26:51 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:5e2c:eb9a:a8b6:fd3e? ([2001:b07:6468:f312:5e2c:eb9a:a8b6:fd3e]) by smtp.gmail.com with ESMTPSA id q10sm7410951eds.36.2021.04.26.02.26.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Apr 2021 02:26:51 -0700 (PDT) Subject: Re: [PATCH v3 0/4] KVM: x86: MSR_TSC_AUX fixes and improvements To: Sean Christopherson Cc: Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Reiji Watanabe References: <20210423223404.3860547-1-seanjc@google.com> From: Paolo Bonzini Message-ID: Date: Mon, 26 Apr 2021 11:26:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210423223404.3860547-1-seanjc@google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 24/04/21 00:34, Sean Christopherson wrote: > Fix potential cross-vendor landmines due to Intel and AMD having different > behavior for MSR_TSC_AUX[63:32], unify the logic across SVM and VMX, and > switch MSR_TSC_AUX via user return MSRs on SVM (the original goal). > > v3: > - Fix a comment typo. [Reiji] > - Add patches to add missing guest_cpuid_has() check, drop bits 63:32 on > AMD, and unify VMX and SVM emulation. > - Rebase to kvm/next, commit c4f71901d53b ("Merge tag 'kvmarm-5.13' ... ) > > v2: > - Rebase to kvm/queue (ish), commit 0e91d1992235 ("KVM: SVM: Allocate SEV > command structures on local stack") > - https://lkml.kernel.org/r/20210422001736.3255735-1-seanjc@google.com > > v1: https://lkml.kernel.org/r/20210206003224.302728-1-seanjc@google.com > > > Sean Christopherson (4): > KVM: SVM: Inject #GP on guest MSR_TSC_AUX accesses if RDTSCP > unsupported > KVM: SVM: Clear MSR_TSC_AUX[63:32] on write > KVM: x86: Tie Intel and AMD behavior for MSR_TSC_AUX to guest CPU > model > KVM: SVM: Delay restoration of host MSR_TSC_AUX until return to > userspace > > arch/x86/kvm/svm/svm.c | 58 +++++++++++++++++------------------------- > arch/x86/kvm/svm/svm.h | 7 ----- > arch/x86/kvm/vmx/vmx.c | 13 ---------- > arch/x86/kvm/x86.c | 34 +++++++++++++++++++++++++ > 4 files changed, 58 insertions(+), 54 deletions(-) > Queued 1-2-4 (with fix for patch 2). Paolo