Return-Path: Received: from mga11.intel.com ([192.55.52.93]:57069 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389869AbfETQhc (ORCPT ); Mon, 20 May 2019 12:37:32 -0400 Reply-To: thor.thayer@linux.intel.com Subject: Re: [PATCH 3/3] ARM64: dts: stratix10: Add stmmac ptp_ref clock References: <20190515162058.32368-1-dalon.westergreen@linux.intel.com> <20190515162058.32368-3-dalon.westergreen@linux.intel.com> From: Thor Thayer Message-ID: Date: Mon, 20 May 2019 11:39:40 -0500 MIME-Version: 1.0 In-Reply-To: <20190515162058.32368-3-dalon.westergreen@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org To: Dalon Westergreen , dinguyen@kernel.org, devicetree@vger.kernel.org List-ID: On 5/15/19 11:20 AM, Dalon Westergreen wrote: > Add the default stmmac ptp_ref clock for stratix10. The stmmac > driver defaults the ptp_ref clock to the main stmmac clock > if the ptp_ref clock is not set in the devicetree. This is > inappropriate for the stratix10. The default ptp_ref clock is > STRATIX10_PERI_EMAC_PTP_CLK in the clock manager. > > Signed-off-by: Dalon Westergreen > --- > arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi > index adedd563125a..f464e7ba3402 100644 > --- a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi > +++ b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi > @@ -160,8 +160,8 @@ > mac-address = [00 00 00 00 00 00]; > resets = <&rst EMAC0_RESET>, <&rst EMAC0_OCP_RESET>; > reset-names = "stmmaceth", "stmmaceth-ocp"; > - clocks = <&clkmgr STRATIX10_EMAC0_CLK>; > - clock-names = "stmmaceth"; > + clocks = <&clkmgr STRATIX10_EMAC0_CLK>, <&clkmgr STRATIX10_PERI_EMAC_PTP_CLK>; > + clock-names = "stmmaceth", "ptp_ref"; > tx-fifo-depth = <16384>; > rx-fifo-depth = <16384>; > snps,multicast-filter-bins = <256>; > @@ -176,8 +176,8 @@ > mac-address = [00 00 00 00 00 00]; > resets = <&rst EMAC1_RESET>, <&rst EMAC1_OCP_RESET>; > reset-names = "stmmaceth", "stmmaceth-ocp"; > - clocks = <&clkmgr STRATIX10_EMAC1_CLK>; > - clock-names = "stmmaceth"; > + clocks = <&clkmgr STRATIX10_EMAC1_CLK>, <&clkmgr STRATIX10_PERI_EMAC_PTP_CLK>; > + clock-names = "stmmaceth", "ptp_ref"; > tx-fifo-depth = <16384>; > rx-fifo-depth = <16384>; > snps,multicast-filter-bins = <256>; > @@ -192,8 +192,8 @@ > mac-address = [00 00 00 00 00 00]; > resets = <&rst EMAC2_RESET>, <&rst EMAC2_OCP_RESET>; > reset-names = "stmmaceth", "stmmaceth-ocp"; > - clocks = <&clkmgr STRATIX10_EMAC2_CLK>; > - clock-names = "stmmaceth"; > + clocks = <&clkmgr STRATIX10_EMAC2_CLK>, <&clkmgr STRATIX10_PERI_EMAC_PTP_CLK>; > + clock-names = "stmmaceth", "ptp_ref"; > tx-fifo-depth = <16384>; > rx-fifo-depth = <16384>; > snps,multicast-filter-bins = <256>; > Should STRATIX10_EMAC_PTP_CLK be used instead of STRATIX10_PERI_EMAC_PTP_CLK since this is the gate of the clkgmr?