Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1ojMoy-0006SJ-Ps for mharc-grub-devel@gnu.org; Fri, 14 Oct 2022 11:42:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54762) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ojMoZ-0006KI-Gq for grub-devel@gnu.org; Fri, 14 Oct 2022 11:41:37 -0400 Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]:34246) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ojMoV-0003m1-68 for grub-devel@gnu.org; Fri, 14 Oct 2022 11:41:35 -0400 Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29EFOmHE010402; Fri, 14 Oct 2022 15:41:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : content-transfer-encoding : content-type : mime-version; s=corp-2022-7-12; bh=7l1rdsBMOpsZW5R+uY1A4vnqIYAWBQ0TTWBc+NoLZ/g=; b=WrSItCjZkStEfa2NwFQEDR5+K/zMaSaYZPdsjWJP7LV0qFw+BWtMN5ezOY8Y7d7vJa6/ trZ9Np2hoh34873VTHfyEJgTNEp22TalEcq/C/c6parPlnT13iXZX8ycL2oZQpcYn4GF H1prg6VFOb34AE+h05VLC9SqjpS5e+7Kk2DE4XdP6p4r0FvtmQHk7tLD4nFGhaIfK5dI x8iaY6HAY7jMkNscgJYPFGAEvitSjpR91RIGF8ZlDzSp1zSqkR+R8pc6pKV16ox4h3Ww dfb0ioXgWnrHwzrXyZEuOnB3pvEPbPxuxMdED3Znvmp3xuNrmz+w7SqXUQS2VP1dNitk tQ== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3k799sg8gu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 14 Oct 2022 15:41:26 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 29EEgaN2036407; Fri, 14 Oct 2022 15:41:24 GMT Received: from nam02-bn1-obe.outbound.protection.outlook.com (mail-bn1nam07lp2045.outbound.protection.outlook.com [104.47.51.45]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3k2yne2xny-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 14 Oct 2022 15:41:24 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D85hQovsw06i5Rm8XrqPhkLSnD3m/LbuONEtrKUyrrtq7d6mzIjjRG7d3/NQS99HeUCNcl+J+SNdklMaj/o9LC8D1ZKOMwH4CYqoYyhumqOlDakN0hZuNf6gVndJdj0uKmKqNr8qNNn9PxfisfsTmgH14aEbewRr1O7fT4n7AiNyw+kVWyhVbY34VXn5cd6ubqGbVws1EXuBNPdYOqeWOldRGXwNpWZgiBt46veqEm6mNgS+YZ1HdSVavriH+1A+Bjs1gYoz/EBTLmj4KG8FMT6xkP7v3glQA2Ks4VJ8Z5cQD1wzTcdt0VtVQRTiWWS+p0QyX8OCTBAs36o5fRNkzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7l1rdsBMOpsZW5R+uY1A4vnqIYAWBQ0TTWBc+NoLZ/g=; b=SN/vnhWmYUKKXTn9Q9aNtU9fBS6mZvWiM52XXl4jHBioQa8V7VK+cz3SrqZ7vL4Rsixyg/gF9fbJVS0FZS12BeqfI5ZJTlH0dxEhmNXPamQOCXgnYJ2DiICH+K9Banl1S+pG5KoOVDsdjdCgHU8UFeoAhvajqbx7qtlyS2TivANDenRQezPqM57kZ20iwOMiJhUW/MhatQVp4+LQDOi1wVClYOzNXjz/q9SlTJfGtBBEH9L5QpBJv/qzPkq9rq4IpBDLjln3vtMkpS+3cMSRLCHeJ3pR3Alu+253urL8KbvbhLdSc/oOd5f3s+LYf9UkwBy8miGxJZqRkcA5C8hQzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7l1rdsBMOpsZW5R+uY1A4vnqIYAWBQ0TTWBc+NoLZ/g=; b=YLeHv8xoQaPGxqHPV1oU6mT8TQM8uE4iDLO3qPWCzNCt0t6vBYOERPERrZr39gYYwWbwgcVmqbb20OxNrTtCVbYGSfc7aHDGLrGcjhdVxgQJrM75wZLF0ZEUnoOka4O9vFmsNdpv88o0wQxjDUJj3qL9jSna5dS4qqcjeJTu/5Y= Received: from BLAPR10MB5138.namprd10.prod.outlook.com (2603:10b6:208:322::8) by PH7PR10MB6626.namprd10.prod.outlook.com (2603:10b6:510:209::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Fri, 14 Oct 2022 15:41:22 +0000 Received: from BLAPR10MB5138.namprd10.prod.outlook.com ([fe80::c843:ed24:5250:26c6]) by BLAPR10MB5138.namprd10.prod.outlook.com ([fe80::c843:ed24:5250:26c6%2]) with mapi id 15.20.5723.026; Fri, 14 Oct 2022 15:41:23 +0000 From: Darren Kenny To: grub-devel@gnu.org Cc: Glenn Washburn , Robbie Harwood , Vladimir 'phcoder' Serbinenko , daniel.kiper@oracle.com, darren.kenny@oracle.com Subject: [PATCH 0/2] Fix building with clang Date: Fri, 14 Oct 2022 15:41:10 +0000 Message-Id: X-Mailer: git-send-email 2.31.1 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: SN7PR04CA0091.namprd04.prod.outlook.com (2603:10b6:806:122::6) To BLAPR10MB5138.namprd10.prod.outlook.com (2603:10b6:208:322::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BLAPR10MB5138:EE_|PH7PR10MB6626:EE_ X-MS-Office365-Filtering-Correlation-Id: c4c96429-c299-44ad-6e3f-08daadfa8bda X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fOyjWOzwBNOitqevfmjm2hIM6IpvyGeXvtw5jzcETAN3RZ8OyDN7b3DQgL/SttxurM5f/p1vG2mjtUMCViJa13/L9c5XwVairsMYbZWtZUg2M+2WDmTMGzdoXbIGKNUR4Ip4XGivLh64AFF0/UzvFdSmRBkcheo4Vi/j5HyBfvQiwqdl7e+BGvTqJJs4/JN44hI/7aQc5tEyMr2KA+GwuNl/oD/r8WJrcf+Uc72ZvZr7gRmesChHQWxAIo5PxasdoWIGByTCbfEBi3F4hNCli2ciIsFZbNiUoWy26OylouB7+ei1E9calWSNZnq9FDb9IN58ZX/PhpuZh9P+GZuhN72aGYgR+RnkqvzHVHq8XQTH9h6R4RxUC2ybFFIZMmnL3jTk65HoFgaRL9gQVFFcIxrEquT/yvB6kDb172zevXNg1EdeFwFNLOIpbTA9PU0Z686g0mpRD39S6e+LA8Rwt1MWJcjritJG1yLZFlwFyRaMv8A+Zb9F6mVk5Y9rTPOM79tgBXE/nBFbiLiBXeAl+OjL+0ue29JLaWKPUz4jC6yZRPvbLAgvtdUwgyY89LgRAkR7eKccy8LG4I3qSaA6AyTig6wu7NgbvzAv/Sdrw2+4Jrup4yz+HhCAEiN0/BXOBHSrC5SOzKGCqTeIBUTzxkUczUgf314HPSDjpo5obC4FkKhCuj/nmoBSZH5HAIoP1BvUcEGSnng5w7kcrb+B3qsOS0eBI0NC9KIhnQwvfumOjz+MKG3r1FeAbvZF/grr X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BLAPR10MB5138.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(346002)(136003)(396003)(39860400002)(376002)(366004)(451199015)(36756003)(2616005)(52116002)(6512007)(26005)(186003)(66946007)(316002)(6916009)(66556008)(54906003)(41300700001)(66476007)(86362001)(4326008)(8676002)(8936002)(38350700002)(6666004)(38100700002)(107886003)(6506007)(478600001)(5660300002)(2906002)(6486002)(44832011)(83380400001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?t598ZlPys8Fj5M0gy1/pLRPbr1+SqGZluUpX16lgfSUaLPohGj+40gF30U9y?= =?us-ascii?Q?CmeSw1mBQTwpz0i4BkB2xZNgCSI+F9MjC/jvKFLVEvhDwZVCtnLME388ShfK?= =?us-ascii?Q?0TfknZIAnMF+pGaGshkvixFoyn/MYSX8AtCrcOewtxqdtGAHLYIxQ+VAlafs?= =?us-ascii?Q?h+bH8jN0M+UaTLrjSxjc3qBwH5ux1nax8Gwgs1LHk6Ay5ctMGyLxN+r9XOk9?= =?us-ascii?Q?IORVxmfjIHLan4y5+A3ucr6H+HXiSwssIpIRPQhs/dHQBGUUYCZwknKw/rBy?= =?us-ascii?Q?bqFKaJZnfJoJIv82UfTlsrE9aO87kHLHhrA+RipoPK7+9lL2X6FfwZA9KVkC?= =?us-ascii?Q?o3wVMLkre39h4QaRinnwfaygtuOX5sfjt4Wm0y3ur4PZaLH3ICGtg4Q1Ia8V?= =?us-ascii?Q?pR1BlPuuWHcD/08Wat14DwMMU1EMq99d3iggKDVnrkD3BER+mfM3AvwN2IVe?= =?us-ascii?Q?b5Lm8CCzNApIlasvtKGNn4G7Z3767XTHKrgYhQwdL85l/btjArm0sdgMVURt?= =?us-ascii?Q?qn/wa6tLBJkgCHTWOy9u0mj/pNaanr03bGE+JrzZnsrG2HlddGpDbmgJOUfR?= =?us-ascii?Q?WsL/5BsvKR3sVpkSZwVNP/eroYkKA9lx0vMUjDUAqExGSG2ZaD5R2Mghnlqm?= =?us-ascii?Q?aNgKa2o/K6GA50ofvkHSAE30wVC0XRaGI5dvhm4Luq3sGWdAwRn6VlyKuAvA?= =?us-ascii?Q?gJrIBcaBJhMzqD5xZFgOM9WJbh8f1PLipj+AKqppLiezXYRjVr25jaYLagol?= =?us-ascii?Q?kYyreK2X0rSx34zKYgL/hBNjvzBOEGRo1T1xFciB98iRjDpjv1s0iBedFUOB?= =?us-ascii?Q?kTRlQck8dn2R582KKU/ifFH28NJU9S0oNpaj7GxdHHS3ZRgbWzHk0TQaXcgO?= =?us-ascii?Q?I6EmUdedn9qi6Ve7L6rKO7tqs3ts19mm+7ptPOlrMQvpdKfhvdDg5jqZudap?= =?us-ascii?Q?go/gNdfg2KjwKUI6Kc6jOX0cIWWqG/WDTyz/06lrca5Z50rOHQ70pFQD9OXv?= =?us-ascii?Q?xAbS7dgzr3P+LQx/YdJQnyoErxVIQKtiC2gih+UkBh0zOmBE8G6IFKhkb7mx?= =?us-ascii?Q?pv5f1ijuHjf+Fg3FS+GE9nNsCoIyHgKIw+1NhmEE4RH6VBMLkws9ax/jbcku?= =?us-ascii?Q?d8caYKnDFS9DL/6VSUsjTbVh7hOLEzmeJ84HrAKTr8r9TzgfaugcsOSm9hul?= =?us-ascii?Q?1jrFq60pxP/+FWySZvUIiYrtXOhiFxCuui13j6KMC+Pm1wzydHIfIAMckXgN?= =?us-ascii?Q?o6LQjT4JC0z6lC/hmxoyiuhOZH03D8SPApqBTlMnXcybEnkyN5RLkylkzBKG?= =?us-ascii?Q?ZbwRu6A//AvXoIhCycSXgxMAq5mb1xgfUVf7sXbOkoY6v9fecwMvz9ZJanK+?= =?us-ascii?Q?klrttkA9BwuTXczQ0IC7WWxn2W2mK5+68V87EnOw+mxP1/Q8aXZUVBGo0VHk?= =?us-ascii?Q?f+uY5+SGkpH+dggxO2StVc6roydBHFR4lLHNBtZqVhtOZdi8zkEhSXl8B97l?= =?us-ascii?Q?0WfNaK22Apb2xuugJsOiOQvXgjL0fMUd7a2sybWNskWEmR+UnjYBTQ9dy54p?= =?us-ascii?Q?8F9nADLdEWwMRi4hTIRIuGX4RM++akpAGOlwv3T+0DMkapf+7U05fjyhh+Gc?= =?us-ascii?Q?wg=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: c4c96429-c299-44ad-6e3f-08daadfa8bda X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5138.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 15:41:22.9417 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YaXS6SlcLicDngZpdKvaUELkBFWkCFx+ef95aWS3LZnyWxEt2aVHwkFajtuFD5YM6bdQxiBfELZa5NjGziVwjg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6626 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-10-14_09,2022-10-14_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0 malwarescore=0 suspectscore=0 mlxscore=0 adultscore=0 phishscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2210140086 X-Proofpoint-GUID: wHliI8u6RlO1M3GQcOiLTfHb-CT5MYxb X-Proofpoint-ORIG-GUID: wHliI8u6RlO1M3GQcOiLTfHb-CT5MYxb Received-SPF: pass client-ip=205.220.165.32; envelope-from=darren.kenny@oracle.com; helo=mx0a-00069f02.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Oct 2022 15:41:37 -0000 The abiltiy to build with clang was broken in the last release after the upgrade of gnulib. There were two main issues: - The use of __builtin_trap in the abort() macro. This builtin doesn't exist for clang builds After some discussion between Daniel and Vladimir, it was requested that I should revert some past changes in this area, and re-introduce the use of grub_abort(). - The is some use of variable length arrays (vla) in gnulib's code, and when an attempt was made to resolve this in gnulib itself, I was informed that we shouldn't be building gnulib with -Werror. Rather than totally disabling -Werror, it seemed better to just limit it for the specific case that is causing problems, i.e. vla. Thanks, Darren. Darren Kenny (2): gnulib: Provide abort() implementation for gnulib configure: Fix building with clang config.h.in | 10 ---------- configure.ac | 4 ++++ grub-core/kern/misc.c | 2 +- grub-core/lib/posix_wrap/stdlib.h | 6 ++++++ include/grub/misc.h | 5 +---- 5 files changed, 12 insertions(+), 15 deletions(-) -- 2.31.1