Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C720C4361B for ; Wed, 16 Dec 2020 08:39:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5900523A3B for ; Wed, 16 Dec 2020 08:39:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5900523A3B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=dme.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38416 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kpSKq-0006FH-9P for qemu-devel@archiver.kernel.org; Wed, 16 Dec 2020 03:39:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48534) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpSK0-0005e2-Uh for qemu-devel@nongnu.org; Wed, 16 Dec 2020 03:38:08 -0500 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]:33349) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kpSJz-0004m1-3K for qemu-devel@nongnu.org; Wed, 16 Dec 2020 03:38:08 -0500 Received: by mail-wm1-x335.google.com with SMTP id n16so1458446wmc.0 for ; Wed, 16 Dec 2020 00:38:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dme-org.20150623.gappssmtp.com; s=20150623; h=to:cc:subject:in-reply-to:references:from:date:message-id :mime-version; bh=DiQvKVBDYYiCXAWyMyuOeqNtZ9U770DMk4MyAhDrcl0=; b=E70lOKtyuP3ABJY6HbkJBCRKf0xE+kGkdd/+dXWJ6BlsMXJYoUxqN/7uvIfwqncYb0 4px8ZdJcnQiHUaE2Wm6c9m76pzWabeugfMRaPTstdyYi59XVfPdo8Y7A9wrIPY6gu6Wy NEhb0TmmAd9vHN6imJAnMefsjnkg3eZ+OJuhFoc/0zWVDFi/PcFzZ0UpDiigPfFe+Zo2 4VX87XB7JnD7aXf58P6HjfkFVbH+JPuOUoHq2x0qb+Ss1iB74Gq88dafVuNnv+hhejHy 1DDOhurpQbNM5bzb2gM5/IvnPLP3RyUjRRgMIHh5hbmavkX3wfv06Uv8l2XIC/YVPFie pMOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:subject:in-reply-to:references:from:date :message-id:mime-version; bh=DiQvKVBDYYiCXAWyMyuOeqNtZ9U770DMk4MyAhDrcl0=; b=SQN+E6va2D3enVdXRgG2VEWUe+iKIY33SSNlSoqOuxtdL5kSrb6nhWqBSgWfvwxOOQ kYMrpTJ1phuCTNn1o8XDwr1tBAeKF5WbZ+TB+26XfVauDM4NVi6Yd4iZ3rYVd3pJzvVx HQq9X8iQvNQW0mlj2/Ukwuhbev5re4Bz+tBVnXXXcEo7vKLrgE50ijNRMqt/5BZJFxDd 2xLzenE58EF+jyYxI3as3uh4Ifcir+hPO16q4wVdv6IB8AVUDeuZ+NACT2ltMfHzo9YE PJKuCuytrOVjbkF0mXpP5Lhq4/6D3OtlQcWbS/Z3zQ/OjYnk5+ohdKkHKimeTsTWpG3a VjgA== X-Gm-Message-State: AOAM531ot79CEE/C8rOz4MOvoWxyLFze9XjX657rsUc5kWeFWcsTQxaP 8qhK2TYcitwFWhGR39VK8yXC8A== X-Google-Smtp-Source: ABdhPJzYb8Td+FC+72nwhcx/KfNSPyQ9Qqe4DVM/sVWIHC7DjqOj/BbaL2DELzDqSEGnARWSY7u0UA== X-Received: by 2002:a1c:67c5:: with SMTP id b188mr2165039wmc.147.1608107884944; Wed, 16 Dec 2020 00:38:04 -0800 (PST) Received: from disaster-area.hh.sledj.net (disaster-area.hh.sledj.net. [2001:8b0:bb71:7140:64::1]) by smtp.gmail.com with ESMTPSA id a14sm2076724wrn.3.2020.12.16.00.38.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Dec 2020 00:38:03 -0800 (PST) Received: from localhost (disaster-area.hh.sledj.net [local]) by disaster-area.hh.sledj.net (OpenSMTPD) with ESMTPA id 82d1865a; Wed, 16 Dec 2020 08:38:02 +0000 (UTC) To: Andrew Jones Subject: Re: [PATCH] hw/arm/virt: Remove virt machine state 'smp_cpus' In-Reply-To: <20201216064353.2n4evhicybkkuf7z@kamzik.brq.redhat.com> References: <20201215174815.51520-1-drjones@redhat.com> <20201216064353.2n4evhicybkkuf7z@kamzik.brq.redhat.com> X-HGTTG: zarquon From: David Edmondson Date: Wed, 16 Dec 2020 08:38:02 +0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Received-SPF: neutral client-ip=2a00:1450:4864:20::335; envelope-from=dme@dme.org; helo=mail-wm1-x335.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NEUTRAL=0.779, UNPARSEABLE_RELAY=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fangying1@huawei.com, peter.maydell@linaro.org, salil.mehta@huawei.com, qemu-arm@nongnu.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wednesday, 2020-12-16 at 07:43:53 +01, Andrew Jones wrote: > On Tue, Dec 15, 2020 at 06:20:48PM +0000, David Edmondson wrote: >> On Tuesday, 2020-12-15 at 18:48:15 +01, Andrew Jones wrote: >> >> > static void fdt_add_cpu_nodes(const VirtMachineState *vms) >> > { >> > - int cpu; >> > - int addr_cells = 1; >> > const MachineState *ms = MACHINE(vms); >> > + int smp_cpus = ms->smp.cpus, cpu; >> >> Is it house-style to have initialised and un-initialised local variables >> declared on the same line? >> > > checkpatch.pl doesn't complain and a grep of qemu shows hundreds of other > examples. That said, I only see one other example in hw/arm/virt.c, so if > we'd rather avoid it, I'll repost. Not at all, I was just curious. dme. -- Driving at 90 down those country lanes, singing to "Tiny Dancer".