Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97F381465B0 for ; Mon, 22 Apr 2024 10:34:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713782087; cv=none; b=FBbIIU2riXjlM6xKXrw4J/MWE/soKt0psj7UBgcevoFkajW3cDuHkPv1C7Mg2qqGtFQeanga634WZ0xgYXWGwHKgaOnA9IayqeAv1E4CkxObogjdiM4YKTkspYA/r3J67D8qYpp8LpKBQIN3c54GdGv7secWvEuo3wd7vMa5BRc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713782087; c=relaxed/simple; bh=bss0N4Uo8rzuzH3SlyG0BoCkOkhhaRofD9h7N0UyFYs=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=i0lHO1EDpusZg9c9hEyn4GdsbXzs+63SMG/tNveS3WdisYNnBMPvbc+WfEo+MSwYvpLY80VDPMiylYCbM7EFWLcmDgMY4bdvAUwofSlLbhzcBOFj7YOqKsb8He63N5I4XAetvHiPKixDOVlTckuy6voWDVwYYcsDLoF2MUH2Zx0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=pB2LqA+L; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="pB2LqA+L" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 760F5C3277B; Mon, 22 Apr 2024 10:34:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713782087; bh=bss0N4Uo8rzuzH3SlyG0BoCkOkhhaRofD9h7N0UyFYs=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=pB2LqA+LJYaLiBpsmEWNmwlUnR5p5ynIr/2o3XID/rgDuS7lEs4qEOb4R3x50WCN8 +y2B0yKka7ffVh82ctx+ICHCLvbx2lsBYLiC7X152Zg7bVrCSjmd8UlCkBLdkfZ0Nt ftBBo2yOf4NjrHXlmDHJWrc+tybXOvNFK4WscvFgVJjbVT4RyWiJ/1iSz1yxWz7gCj 6m6wGmy6s6w1jNcuMvcnk1y3RxNUOPNBv2TOfNUd65Bw00YoBfSJLOb8WalO4J+jZV lKoRq9yQaN6j1/HxXqlnz2FbpKWR3bKPfaYJzKFsKoHGwFtDWPAe/W6sUVXr/fNlYj aAXZZvUtOH9yA== Message-ID: Subject: Re: [PATCH bpf-next v4 3/3] selftests/bpf: Support nonblock for send_recv_data From: Geliang Tang To: Matthieu Baerts , Mat Martineau Cc: mptcp@lists.linux.dev Date: Mon, 22 Apr 2024 18:34:39 +0800 In-Reply-To: <0017e477-3fcd-45de-917b-b58b3781ca9b@kernel.org> References: <9cd358958245f8ec87c4f553779aa4243f967a2f.1712729342.git.tanggeliang@kylinos.cn> <12aab271-da72-49b4-ac91-2091b6889856@linux.dev> <9475c2259b3d32774bc1488dd0d6004f7ddfbf13.camel@kernel.org> <52673f90-84c6-4e3d-9967-a3d0a7335c46@kernel.org> <7732f129e5c1c2ff128878be9b865115e1319b85.camel@kernel.org> <0017e477-3fcd-45de-917b-b58b3781ca9b@kernel.org> Autocrypt: addr=geliang@kernel.org; prefer-encrypt=mutual; keydata=mQINBGWKTg4BEAC/Subk93zbjSYPahLCGMgjylhY/s/R2ebALGJFp13MPZ9qWlbVC8O+XlU/4reZtYKQ715MWe5CwJGPyTACILENuXY0FyVyjp/jl2u6XYnpuhw1ugHMLNJ5vbuwkc1I29nNe8wwjyafN5RQV0AXhKdvofSIryqm0GIHIH/+4bTSh5aB6mvsrjUusB5MnNYU4oDv2L8MBJStqPAQRLlP9BWcKKA7T9SrlgAr0VsFLIOkKOQPVTCnYxn7gfKogH52nkPAFqNofVB6AVWBpr0RTY7OnXRBMInMHcjVG4I/NFn8Cc7oaGaWHqX/yHAufJKUsldieQVFd7C/SI8jCUXdkZxR0Tkp0EUzkRc/TS1VwWHav0x3oLSy/LGHfRaIC/MqdGVqgCnm6wapUt7f/JHloyIyKJBGBuHCLMpN6n/kNkSCzyZKV7h6Vw1OL518p0U3Optyakoh95KiJsKzcd3At/eftQGlNn5WDflHV1+oMdW2sRgfVDPrYeEcYI5IkTc3LRO6ucpVCm9/+poZSHSXMI/oJ6iXMJE8k3/aQz+EEjvc2z0p9aASJPzx0XTTC4lciTvGj62z62rGUlmEIvU23wWH37K2EBNoq+4Y0AZsSvMzM+CcTo25hgPaju1/A8ErZsLhP7IyFT17ARj/Et0G46JRsbdlVJ/PvX+XIOc2mpqx/QARAQABtCVHZWxpYW5nIFRhbmcgPGdlbGlhbmcudGFuZ0BsaW51eC5kZXY+iQJUBBMBCgA+FiEEZiKd+VhdGdcosBcafnvtNTGKqCkFAmWKTg4CGwMFCRLMAwAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQfnvtNTGKqCmS+A/9Fec0xGLcrHlpCooiCnNH0RsXOVPsXRp2xQiaOV4vMsvhG5AHaQLb3v0cUr5JpfzMzNpEkaBQ/Y8Oj5hFOORhTyCZD8tY1aROs8WvbxqvbGXHnyVwqy7Ad WelP+0lC0DZW0kPQLeel8XvLnm9Wm3syZgRGxiM/J7PqVcjujUb6SlwfcE3b2opvsHW9AkBNK7v8wGIcmBA3pS1O0/anP/xD5s5L7LIMADVB9MqQdeLdFU+FFdafmKSmcP9A2qKHAvPBUuQo3xoBOZR3DMqXIPkNCBfQGkAx5tm1XYli1u3r5tp5QCRbY5LSkntMNJJh0eWLU8I+zF6NWhqNhHYRD3zc1tiXlG5E0obpX02Dy25SE2zB3abCRdAK30nCI4lMyMCcyaeFqvf6uhiugLiuEPRRRdJDWICOLw6KOFmxWmue1F71k08nj5PQMWQUX3X2K6jiOuoodYwnie/9NsH3DBHIVzVPWASFd6JkZ21i9Ng4ie+iQAveRTCeCCF6VRORJR0R8d7mI9+1eqhNeKzs21gQPVf/KBEIpwPFDjOdTwS/AEQQyhB+5ALeYpNgfKl2p30C20VRfJGBaTc4ReUXh9xbUx5OliV69iq9nIVIyculTUsbrZX81Gz6UlbuSzWc4JclWtXf8/QcOK31wputde7Fl1BTSR4eWJcbE5Iz2yzgQu0IUdlbGlhbmcgVGFuZyA8Z2VsaWFuZ0BrZXJuZWwub3JnPokCVAQTAQoAPhYhBGYinflYXRnXKLAXGn577TUxiqgpBQJlqclXAhsDBQkSzAMABQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEH577TUxiqgpaGkP/3+VDnbu3HhZvQJYw9a5Ob/+z7WfX4lCMjUvVz6AAiM2atDyyUoDIv0fkDDUKvqoU9BLU93oiPjVzaR48a1/LZ+RBE2mzPhZF201267XLMFBylb4dyQZxqbAsEhVc9VdjXd4pHYiRTSAUqKqyamh/geIIpJz/cCcDLvX4sM/Zjwt/iQdvCJ2eBzunMfouzryFwLGcOXzxOwZRMOBgVuXrjGVB52kYu1+K90DtclewEgvzWmS9d057CJztJZMXzvHfFAQMgJC7DX4pa Yt49pNvhcqLKMGNLPsX06OR4G+4ai0JTTzIlwVJXuo+uZRFQyuOaSmlSjEsiQ/WsGdhILldV35RiFKe/ojQNd4B4zREBe3xT+Sf5keyAmO/TG14tIOCoGJarkGImGgYltTTTM6rIk/wwo9FWshgKAmQyEEiSzHTSnXcGbalD3Do89YRmdG+5eP7HQfsG+VWdn8IH6qgIvSt8GOw6RfSP7omMXvXji1VrbWG4LOFYcsKTN+dGDhl8LmU0y44HejkCzYj/b28MvNTiRVfucrmZMGgI8L5A4ZwQ3Inv7jY13GZSvTb7PQIbqMcb1P3SqWJFodSwBg9oSw21b+T3aYG3z3MRCDXDlZAJONELx32rPMdBva8k+8L+K8gc7uNVH4jkMPkP9jPnVPx+2P2cKc7LXXedb/qQ3MuQINBGWKTg4BEADJxiOtR4SC7EHrUDVkp/pJCQC2wxNVEiJOas/q7H62BTSjXnXDc8yamb+HDO+Sncg9SrSRaXIh+bw9G3rvOiC2aQKB6EyIWKMcuDlD7GbkLJGRoPCA5nSfHSzht2PdNvbDizODhtBy8BOQA6Vb21XOb1k/hfD8Wy6OnvkA4Er61cf66BzXeTEFrvAIW+eUeoYTBAeOOc2m4Y0J28lXhoQftpNGV5DxH9HSQilQZxEyWkNj8oomVJ6Db7gSHre0odlt5ZdB7eCJik12aPIdK5W97adXrUDAclipsyYmZoC1oRkfUrHZ3aYVgabfC+EfoHnC3KhvekmEfxAPHydGcp80iqQJPjqneDJBOrk6Y51HDMNKg4HJfPV0kujgbF3Oie2MVTuJawiidafsAjP4r7oZTkP0N+jqRmf/wkPe4xkGQRu+L2GTknKtzLAOMAPSh38JqlReQ59G4JpCqLPr00sA9YN+XP+9vOHT9s4iOu2RKy2v4eVOAfEFLXq2JejUQfXZtzSrS/31ThMbfUmZsRi8CY3HRBAENX224Wcn6IsXj3K6lfYxImRKWGa /4KviLias917DT/pjLw/hE8CYubEDpm6cYpHdeAEmsrt/9dMe6flzcNQZlCBgl9zuErP8Cwq8YNO4jN78vRlLLZ5sqgDTWtGWygi/SUj8AUQHyF677QARAQABiQI7BBgBCgAmFiEEZiKd+VhdGdcosBcafnvtNTGKqCkFAmWKTg4CGwwFCRLMAwAACgkQfnvtNTGKqCkpsw/2MuS0PVhl2iXs+MleEhnN1KjeSYaw+nLbRwd2SdXoVXBquPP9Bgb92T2XilcWObNwfVtD2eDz8eKf3e9aaWIzZRQ3E5BxiQSHXl6bDDNaWJB6I8dd5TW+QnBPLzvqxgLIoYn+2FQ0AtL0wpMOdcFg3Av8MEmMJk6s/AHkL8HselA3+4h8mgoK7yMSh601WGrQAFkrWabtynWxHrq4xGfyIPpq56e5ZFPEPd4Ou8wsagn+XEdjDof/QSSjJiIaenCdDiUYrx1jltLmSlN4gRxnlCBp6JYr/7GlJ9Gf26wk25pb9RD6xgMemYQHFgkUsqDulxoBit8g9e0Jlo0gwxvWWSKBJ83f22kKiMdtWIieq94KN8kqErjSXcpI8Etu8EZsuF7LArAPch/5yjltOR5NgbcZ1UBPIPzyPgcAmZlAQgpy5c2UBMmPzxco/A/JVp4pKX8elTc0pS8W7ne8mrFtG7JL0VQfdwNNn2R45VRf3Ag+0pLSLS7WOVQcB8UjwxqDC2t3tJymKmFUfIq8N1DsNrHkBxjs9m3r82qt64u5rBUH3GIO0MGxaI033P+Pq3BXyi1Ur7p0ufsjEj7QCbEAnCPBTSfFEQIBW4YLVPk76tBXdh9HsCwwsrGC2XBmi8ymA05tMAFVq7a2W+TO0tfEdfAX7IENcV87h2yAFBZkaA== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.0-1 Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2024-04-22 at 12:31 +0200, Matthieu Baerts wrote: > On 22/04/2024 12:04, Geliang Tang wrote:> On Mon, 2024-04-22 at 11:45 > +0200, Matthieu Baerts wrote: >=20 > (...) >=20 > > > I might be wrong, but with MPTCP schedulers, it is different: > > > with > > > non-blocking IO, EAGAIN can be seen, and this case needs to be > > > handled. > > > Actively waiting by retrying directly in the loop in case of > > > EAGAIN > > > is > > > not recommended, but probably OK for the tests (still, might be > > > good > > > to > > > add a comment to recommend polling instead). So here as well, > > > such > > > modifications can stay in our tree for the moment. > > >=20 > > > Also, what is not clear to me is where we set the socket as the > > > non-blocking one. Is it only done for MPTCP servers/clients? > >=20 > > I didn't set the socket as non-block in the end. > >=20 > > EAGAIN will be got no matter non-block flag is set or not. >=20 > That's strange, no? When the userspace sends data with a blocking IO > socket, it should not get EAGAIN, no? >=20 > > In old version like "[mptcp-next,v7,0/5] setsockopt per subflow: > > BPF": > >=20 > > https://patchwork.kernel.org/project/mptcp/cover/cover.1712571740.git.t= anggeliang@kylinos.cn/ > >=20 > > "set_nonblock" is added in patch 2, and invoked in run_subflow() in > > patch 3. >=20 > I see, but the commit message of patch 2 doesn't explain why > set_nonblock() is needed for MPTCP. I see it is used in patch 3, but > is > it really necessary? Maybe it was added for other reasons, that are > no > longer valid today? >=20 > > > > I added a issue #487 to trace this issue. >=20 > Please also note that we didn't have this issue for a while. When we > had > it, it is when KVM was not supported on the CI: >=20 > =C2=A0$ /opt/virtme/virtme-run (...) > =C2=A0Could not access KVM kernel module: No such file or directory > =C2=A0qemu-system-x86_64: failed to initialize kvm: No such file or > directory > =C2=A0qemu-system-x86_64: falling back to tcg >=20 >=20 > Maybe we had this issue because the VM was abnormally too slow, and > we > reached the 3 seconds timeout described by Martin in a previous > message? > If this is due to the "abnormally slow setup", maybe we don't need to > do > anything? >=20 > In other words, can you (easily) reproduce the issue on your side? > With > or without KVM support? It's easy to reproduce by increasing total_bytes: +++ b/tools/testing/selftests/bpf/prog_tests/mptcp.c @@ -46,7 +46,7 @@ #endif #define MPTCP_SCHED_NAME_MAX 16 =20 -static const unsigned int total_bytes =3D 10 * 1024 * 1024; +static const unsigned int total_bytes =3D 200 * 1024 * 1024; Geliang >=20 > Cheers, > Matt