Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3391CC4332F for ; Fri, 2 Dec 2022 05:52:16 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 989E3850D5; Fri, 2 Dec 2022 06:52:14 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="GzgjlIaJ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E6DE785214; Fri, 2 Dec 2022 06:52:12 +0100 (CET) Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9651485023 for ; Fri, 2 Dec 2022 06:52:09 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=d-gole@ti.com Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 2B25q2dx005804; Thu, 1 Dec 2022 23:52:02 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1669960322; bh=FvxGGkKTmhTNe3K3lTnRrIdJM6LUj4UjH2Lil02fAM0=; h=Date:Subject:To:References:From:In-Reply-To; b=GzgjlIaJfyOGTxlSPwnoyevINZvUbf3eAs+GuY9aLAXtw09ve+cmd4k/wTY6C4k83 PR3m8AwEd7NihaYr0TDyND8BV+qYDSX2zaUQmcwQ1pfYtum2nR4CfXmVlEyspArXV7 SzeYac8Ke9AbAFOMmKDEhEvoWYL+tQIprA1JaYvo= Received: from DFLE108.ent.ti.com (dfle108.ent.ti.com [10.64.6.29]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 2B25q20Z081818 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 1 Dec 2022 23:52:02 -0600 Received: from DFLE108.ent.ti.com (10.64.6.29) by DFLE108.ent.ti.com (10.64.6.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Thu, 1 Dec 2022 23:52:02 -0600 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE108.ent.ti.com (10.64.6.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Thu, 1 Dec 2022 23:52:02 -0600 Received: from [10.24.69.26] (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 2B25q0pf032894; Thu, 1 Dec 2022 23:52:00 -0600 Message-ID: Date: Fri, 2 Dec 2022 11:21:59 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2 7/9] am335x-sancloud-bbe-lite: SPI flash is JEDEC compatible To: Paul Barker , , Simon Glass , Tom Rini References: <20221114124243.3719037-1-paul.barker@sancloud.com> <20221114124243.3719037-8-paul.barker@sancloud.com> Content-Language: en-US From: Dhruva Gole In-Reply-To: <20221114124243.3719037-8-paul.barker@sancloud.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Paul, On 14/11/22 18:12, Paul Barker wrote: > Signed-off-by: Paul Barker It is my humble opinion that you add some commit message here and not leave the body blank with just a sign off. > --- > arch/arm/dts/am335x-sancloud-bbe-lite.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/dts/am335x-sancloud-bbe-lite.dts b/arch/arm/dts/am335x-sancloud-bbe-lite.dts > index d6ef19311a91..8ffbc72dc57e 100644 > --- a/arch/arm/dts/am335x-sancloud-bbe-lite.dts > +++ b/arch/arm/dts/am335x-sancloud-bbe-lite.dts > @@ -41,7 +41,7 @@ > #address-cells = <1>; > #size-cells = <0>; > > - compatible = "micron,spi-authenta"; > + compatible = "micron,spi-authenta", "jedec,spi-nor"; > > reg = <0>; > spi-max-frequency = <16000000>; -- Thanks and Regards, Dhruva Gole