Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CDE73C433EF for ; Fri, 27 May 2022 18:41:21 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7540483EFE; Fri, 27 May 2022 20:41:19 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="XWzjkEbU"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3770E84360; Fri, 27 May 2022 20:41:18 +0200 (CEST) Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B352D83EFE for ; Fri, 27 May 2022 20:41:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=alpernebiyasak@gmail.com Received: by mail-ed1-x535.google.com with SMTP id z43so1968492ede.1 for ; Fri, 27 May 2022 11:41:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=ZkpSnUgjr/65BUSKgG6itPV9EAkVNdYA+ExCU5g5zWs=; b=XWzjkEbUYtb1VqciTG/R0Ldrcxg0PjQccY5JBm3TQPcvC9xcRk6oRxr7nMr3Cf9cUl siFarFQ/zUXfDiagkSENF+mUfkgoPhrATc6ayXbgj7iPK8keasvYz7p0El40G+D31IhN Ptfb0CLz1JmO7engHHr8h+App67XQnPUqIx+BnLiYjca7tLbnZ8A6g6LX4X4BNorXLPt jKv6THCuSKe3LOk4V1P+SFcVn7BUrhwQ24eBuQUWfMOOujg05NJHPanEcVYubYHjCi8a u8nu6zFW1TA9evnrYJTmYyhIhjZ8IxP4H78OH4YcLsky2j5FI5CBBCug6gW+njVfqkeG pG+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=ZkpSnUgjr/65BUSKgG6itPV9EAkVNdYA+ExCU5g5zWs=; b=GbcWYwuTFzekDRVuQZYpU7L0plQ1zWOzepljglQ38gCgg+y1UVPT0yvXLHzx2CTNeb /3xTWbLugpenBRx5HEevXHtLi5xWvCS1zy83O8EDAmZdGt232IgqX7svm8so10BofKjr NP75UUF6lZWSDtvLUKT7q71ksrDmSJUeLrjLlUeaC6tIDs9pxQtE8UfQo/ouyH167RAO JkxqjOJqRp1K7y7CSaPawrmxgQp0+sAD8k5rio4kqjJA6W+o+WxgFVnGGvtCTuDA5Xbd puNExMBEZLuuIKOzp+cDUlT1EBdSyrOOIWVDuk7eWXhEmXvethJXgjJ4aFgfnlfrUBRH fBRw== X-Gm-Message-State: AOAM530nEpokWmY3BFX/9hNmkWLC2Z4sgEM5H2DvxLB09YEqhvW2WDqY VtOaGcJd4q4/BoK1nhwjn98= X-Google-Smtp-Source: ABdhPJy1XX7kMvlX8pNnEDxHoK4iNGEYRET+ZieswcRZGDyM/IeZG336LrCF+loIYB48Eci7l5kEqA== X-Received: by 2002:a05:6402:1445:b0:42b:cc8a:a309 with SMTP id d5-20020a056402144500b0042bcc8aa309mr14321918edx.43.1653676870168; Fri, 27 May 2022 11:41:10 -0700 (PDT) Received: from [192.168.0.74] ([178.233.178.185]) by smtp.gmail.com with ESMTPSA id e11-20020a50d4cb000000b0042a5a39ba7esm2459441edj.25.2022.05.27.11.41.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 May 2022 11:41:09 -0700 (PDT) Message-ID: Date: Fri, 27 May 2022 21:41:02 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] imx8mn_evk: Add the missing spl.bin entry Content-Language: en-US To: Fabio Estevam Cc: u-boot@lists.denx.de, uboot-imx@nxp.com, Fabio Estevam , sbabic@denx.de References: <20220503190304.413968-1-festevam@gmail.com> From: Alper Nebi Yasak In-Reply-To: <20220503190304.413968-1-festevam@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 03/05/2022 22:03, Fabio Estevam wrote: > From: Fabio Estevam > > The generated flash.bin does not boot the imx8mn evk LPDDR4 variant > as it misses the spl.bin description in binman. The dtsi file #includes "imx8mn-ddr4-evk-u-boot.dtsi", which provides an 'spl' description. It also provides a 'imx-boot' description for a working 'flash.bin' file. The issue here is the 'flash' description here is overwriting the same file with its own broken definition. You're removing it, so things work fine. > Add its entry to fix the boot on the imx8mn evk LPDDR4 variant. > > Signed-off-by: Fabio Estevam > --- > arch/arm/dts/imx8mn-evk-u-boot.dtsi | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Alper Nebi Yasak > diff --git a/arch/arm/dts/imx8mn-evk-u-boot.dtsi b/arch/arm/dts/imx8mn-evk-u-boot.dtsi > index 3db46d4cbc..593cf06eb9 100644 > --- a/arch/arm/dts/imx8mn-evk-u-boot.dtsi > +++ b/arch/arm/dts/imx8mn-evk-u-boot.dtsi > @@ -58,7 +58,9 @@ > }; > > > - flash { > + spl { > + filename = "spl.bin"; > + > mkimage { > args = "-n spl/u-boot-spl.cfgout -T imx8mimage -e 0x912000"; > You might want to copy 'imx-boot' from "imx8mn-ddr4-evk-u-boot.dtsi" for completeness. But it doesn't really matter.