From: "MaxF (Code Review)" Date: Thu, 15 Jan 2026 15:56:39 +0000 In-Reply-To: References: Reply-To: max@...2606..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., steffan@...1856... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="i5S3h1GRPCE="; charset=UTF-8 Subject: [Openvpn-devel] [XL] Change in openvpn[master]: Add support for Mbed TLS 4 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: flichtenheld , syzzer , plaisthos , openvpn-devel --i5S3h1GRPCE= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos, syzzer. MaxF has posted comments on this change by MaxF. ( http://gerrit.openvpn.ne= t/c/openvpn/+/1441?usp=3Demail ) Change subject: Add support for Mbed TLS 4 ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: > I have added http://gerrit.openvpn. [=E2=80=A6] The reason for the first error is what it says on the tin: Mbed TLS 4 just = doesn't have a function to load Diffie-Hellman moduli from files. I don't k= now what to do about that. Should I make the error non-fatal, log a warning= and ignore the dh file? Or maybe remove the dh option from the Mbed TLS bu= ild and then we can add "ignore-unknown-option dh" to the config? I'll look into the 2nd point, but I don't think stock Mbed TLS 4 can suppor= t external signatures at all... -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1441?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ib251d546d993b96ed3bd8cb9111bcc627cdb0fae Gerrit-Change-Number: 1441 Gerrit-PatchSet: 5 Gerrit-Owner: MaxF Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-CC: syzzer Gerrit-Attention: syzzer Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Thu, 15 Jan 2026 15:56:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld --i5S3h1GRPCE= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: flichtenheld, plaisthos, syzzer.

View = Change

1 comment:

    =
  • Patchset:

    • Patch Set #5:

      I ha= ve added http://gerrit.openvpn. [=E2=80=A6]

      The reason for= the first error is what it says on the tin: Mbed TLS 4 just doesn't ha= ve a function to load Diffie-Hellman moduli from files. I don't know wh= at to do about that. Should I make the error non-fatal, log a warning and i= gnore the dh file? Or maybe remove the dh option from the Mbed TLS build an= d then we can add "ignore-unknown-option dh" to the config?

      I= 'll look into the 2nd point, but I don't think stock Mbed TLS 4 can= support external signatures at all...

To view, v= isit cha= nge 1441. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ib251d546d993b96ed3bd8cb9111= bcc627cdb0fae
Gerrit-Change-Number: 1441
Gerrit-PatchSet: 5
Gerrit-Owner: MaxF <max@...2606...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-CC: syzzer <steffan@...1856...> <= /div>
Gerrit-Attention: syzzer <steffan@...2115...= .>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Thu, 15 Jan 2026 15:56:39= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <frank@...1186...= .2641...>
= --i5S3h1GRPCE=--