From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH] SWDEV-197284 - drm/amdgpu: Only use the peek function in productor side is not correct Date: Mon, 12 Aug 2019 19:00:29 +0200 Message-ID: References: <1565595762-8141-1-git-send-email-Emily.Deng@amd.com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1565595762-8141-1-git-send-email-Emily.Deng-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Emily Deng , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org QW0gMTIuMDguMTkgdW0gMDk6NDIgc2NocmllYiBFbWlseSBEZW5nOgo+IEZvciBzcHNjIHF1ZXVl LCB1c2UgcGVlayBmdW5jdGlvbiB3b3VsZCBjYXVzZSBlcnJvciBpbiBwcm9kdWN0b3Igc2lkZS4K PiBBcyBmb3IgdGhlIGxhc3QgZWxlbWVudCwgd2hlbiB0aGUgcHVzaCBqb2IgaXMgb2NjdXJyaW5n IGR1cmluZyBwb3Agam9iLCB0aGUgcGVlayBmdW5jdGlvbgo+IHdpbGwgbm90IGJlIHVwZGF0ZWQg aW4gdGltZSwgYW5kIGl0IHdpbGwgcmV0dXJuIE5VTEwuCj4KPiBTbyB1c2UgcXVldWUgY291bnQg Zm9yIGRvdWJsZSBjb25maXJtaW5nIHRoZSBqb2IgcXVldWUgaXMgZW1wdHkuCgpGb3IgdGhlIHVw c3RyZWFtIGJyYW5jaCBJJ20gZ29pbmcgdG8gcHVzaCBteSBwYXRjaCB3aGljaCBpcyBub3QgYXMg CmludmFzaXZlIGFzIHRoaXMgb25lLgoKQ2hyaXN0aWFuLgoKPgo+IFNpZ25lZC1vZmYtYnk6IEVt aWx5IERlbmcgPEVtaWx5LkRlbmdAYW1kLmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9z Y2hlZHVsZXIvc2NoZWRfZW50aXR5LmMgfCA0ICsrLS0KPiAgIGluY2x1ZGUvZHJtL3Nwc2NfcXVl dWUuaCAgICAgICAgICAgICAgICAgfCA3ICsrKy0tLS0KPiAgIDIgZmlsZXMgY2hhbmdlZCwgNSBp bnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9zY2hlZHVsZXIvc2NoZWRfZW50aXR5LmMgYi9kcml2ZXJzL2dwdS9kcm0vc2NoZWR1bGVy L3NjaGVkX2VudGl0eS5jCj4gaW5kZXggMzVkZGJlYy4uZTc0ODk0ZiAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vc2NoZWR1bGVyL3NjaGVkX2VudGl0eS5jCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL3NjaGVkdWxlci9zY2hlZF9lbnRpdHkuYwo+IEBAIC05NSw3ICs5NSw3IEBAIHN0YXRp YyBib29sIGRybV9zY2hlZF9lbnRpdHlfaXNfaWRsZShzdHJ1Y3QgZHJtX3NjaGVkX2VudGl0eSAq ZW50aXR5KQo+ICAgCXJtYigpOyAvKiBmb3IgbGlzdF9lbXB0eSB0byB3b3JrIHdpdGhvdXQgbG9j ayAqLwo+ICAgCj4gICAJaWYgKGxpc3RfZW1wdHkoJmVudGl0eS0+bGlzdCkgfHwKPiAtCSAgICBz cHNjX3F1ZXVlX3BlZWsoJmVudGl0eS0+am9iX3F1ZXVlKSA9PSBOVUxMKQo+ICsJICAgICgoc3Bz Y19xdWV1ZV9wZWVrKCZlbnRpdHktPmpvYl9xdWV1ZSkgPT0gTlVMTCkgJiYgIXNwc2NfcXVldWVf Y291bnQoJmVudGl0eS0+am9iX3F1ZXVlKSkpCj4gICAJCXJldHVybiB0cnVlOwo+ICAgCj4gICAJ cmV0dXJuIGZhbHNlOwo+IEBAIC0yODEsNyArMjgxLDcgQEAgdm9pZCBkcm1fc2NoZWRfZW50aXR5 X2Zpbmkoc3RydWN0IGRybV9zY2hlZF9lbnRpdHkgKmVudGl0eSkKPiAgIAkvKiBDb25zdW1wdGlv biBvZiBleGlzdGluZyBJQnMgd2Fzbid0IGNvbXBsZXRlZC4gRm9yY2VmdWxseQo+ICAgCSAqIHJl bW92ZSB0aGVtIGhlcmUuCj4gICAJICovCj4gLQlpZiAoc3BzY19xdWV1ZV9wZWVrKCZlbnRpdHkt PmpvYl9xdWV1ZSkpIHsKPiArCWlmICgoc3BzY19xdWV1ZV9wZWVrKCZlbnRpdHktPmpvYl9xdWV1 ZSkgPT0gTlVMTCkgJiYgIXNwc2NfcXVldWVfY291bnQoJmVudGl0eS0+am9iX3F1ZXVlKSkgewo+ ICAgCQlpZiAoc2NoZWQpIHsKPiAgIAkJCS8qIFBhcmsgdGhlIGtlcm5lbCBmb3IgYSBtb21lbnQg dG8gbWFrZSBzdXJlIGl0IGlzbid0IHByb2Nlc3NpbmcKPiAgIAkJCSAqIG91ciBlbml0eS4KPiBk aWZmIC0tZ2l0IGEvaW5jbHVkZS9kcm0vc3BzY19xdWV1ZS5oIGIvaW5jbHVkZS9kcm0vc3BzY19x dWV1ZS5oCj4gaW5kZXggMTI1ZjA5Ni4uNzgwOTJiOSAxMDA2NDQKPiAtLS0gYS9pbmNsdWRlL2Ry bS9zcHNjX3F1ZXVlLmgKPiArKysgYi9pbmNsdWRlL2RybS9zcHNjX3F1ZXVlLmgKPiBAQCAtNTQs OSArNTQsOCBAQCBzdGF0aWMgaW5saW5lIHZvaWQgc3BzY19xdWV1ZV9pbml0KHN0cnVjdCBzcHNj X3F1ZXVlICpxdWV1ZSkKPiAgIAo+ICAgc3RhdGljIGlubGluZSBzdHJ1Y3Qgc3BzY19ub2RlICpz cHNjX3F1ZXVlX3BlZWsoc3RydWN0IHNwc2NfcXVldWUgKnF1ZXVlKQo+ICAgewo+IC0JcmV0dXJu IHF1ZXVlLT5oZWFkOwo+ICsJcmV0dXJuIFJFQURfT05DRShxdWV1ZS0+aGVhZCk7Cj4gICB9Cj4g LQo+ICAgc3RhdGljIGlubGluZSBpbnQgc3BzY19xdWV1ZV9jb3VudChzdHJ1Y3Qgc3BzY19xdWV1 ZSAqcXVldWUpCj4gICB7Cj4gICAJcmV0dXJuIGF0b21pY19yZWFkKCZxdWV1ZS0+am9iX2NvdW50 KTsKPiBAQCAtNzAsOSArNjksOSBAQCBzdGF0aWMgaW5saW5lIGJvb2wgc3BzY19xdWV1ZV9wdXNo KHN0cnVjdCBzcHNjX3F1ZXVlICpxdWV1ZSwgc3RydWN0IHNwc2Nfbm9kZSAqbgo+ICAgCj4gICAJ cHJlZW1wdF9kaXNhYmxlKCk7Cj4gICAKPiArCWF0b21pY19pbmMoJnF1ZXVlLT5qb2JfY291bnQp Owo+ICAgCXRhaWwgPSAoc3RydWN0IHNwc2Nfbm9kZSAqKilhdG9taWNfbG9uZ194Y2hnKCZxdWV1 ZS0+dGFpbCwgKGxvbmcpJm5vZGUtPm5leHQpOwo+ICAgCVdSSVRFX09OQ0UoKnRhaWwsIG5vZGUp Owo+IC0JYXRvbWljX2luYygmcXVldWUtPmpvYl9jb3VudCk7Cj4gICAKPiAgIAkvKgo+ICAgCSAq IEluIGNhc2Ugb2YgZmlyc3QgZWxlbWVudCB2ZXJpZnkgbmV3IG5vZGUgd2lsbCBiZSB2aXNpYmxl IHRvIHRoZSBjb25zdW1lcgo+IEBAIC05Myw2ICs5Miw3IEBAIHN0YXRpYyBpbmxpbmUgc3RydWN0 IHNwc2Nfbm9kZSAqc3BzY19xdWV1ZV9wb3Aoc3RydWN0IHNwc2NfcXVldWUgKnF1ZXVlKQo+ICAg CS8qIFZlcmlmeSByZWFkaW5nIGZyb20gbWVtb3J5IGFuZCBub3QgdGhlIGNhY2hlICovCj4gICAJ c21wX3JtYigpOwo+ICAgCj4gKwlhdG9taWNfZGVjKCZxdWV1ZS0+am9iX2NvdW50KTsKPiAgIAlu b2RlID0gUkVBRF9PTkNFKHF1ZXVlLT5oZWFkKTsKPiAgIAo+ICAgCWlmICghbm9kZSkKPiBAQCAt MTEzLDcgKzExMyw2IEBAIHN0YXRpYyBpbmxpbmUgc3RydWN0IHNwc2Nfbm9kZSAqc3BzY19xdWV1 ZV9wb3Aoc3RydWN0IHNwc2NfcXVldWUgKnF1ZXVlKQo+ICAgCQl9Cj4gICAJfQo+ICAgCj4gLQlh dG9taWNfZGVjKCZxdWV1ZS0+am9iX2NvdW50KTsKPiAgIAlyZXR1cm4gbm9kZTsKPiAgIH0KPiAg IAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdm eCBtYWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4