Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81A74C4320A for ; Wed, 1 Sep 2021 12:59:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 11CA861058 for ; Wed, 1 Sep 2021 12:59:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 11CA861058 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:47784 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mLPqO-00065A-4u for qemu-devel@archiver.kernel.org; Wed, 01 Sep 2021 08:59:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41002) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLPhp-0005NH-6V for qemu-devel@nongnu.org; Wed, 01 Sep 2021 08:51:05 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:28741) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLPhn-0005rH-MT for qemu-devel@nongnu.org; Wed, 01 Sep 2021 08:51:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630500662; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qUKVhy3DTX3HUn6xlN2hSAUQAG2LA0pXlqtWKW3/UDk=; b=Ao/MTv81ZoPZahxunqjyixcdI+uePVacTfMvqK7GxtvhtIcIRio+DehJLyXuA6KYZPwyoR XqJrm/+F1xTgD6AsnhowzDXKeSZSPA1Vq38+1xBs7oZtgSyduaN38ofKMV7HfbNGh/COBB GlvPsB5pL1j8eEnnMQpPG7B7jHl61fo= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-562-CVGp_ZrYOPaYeetzSQpQUA-1; Wed, 01 Sep 2021 08:51:01 -0400 X-MC-Unique: CVGp_ZrYOPaYeetzSQpQUA-1 Received: by mail-wm1-f71.google.com with SMTP id y24-20020a7bcd98000000b002eb50db2b62so984145wmj.5 for ; Wed, 01 Sep 2021 05:51:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=qUKVhy3DTX3HUn6xlN2hSAUQAG2LA0pXlqtWKW3/UDk=; b=TUzg61xi1eCqYfs0hCiPV/PJULutMxa2U2jpS3srvsuPKwavOxYr0hyMOxTkByVDx8 YvmQtJWTR+NuxptJzLa8VHvqBuHYbjmamZfU2y+P/gcIKETC2E3Wb+zdOFGCPXrBA6Ov zccemF2BHMzaEWu5QkBlOrcKGWiVf2hOx63BtAILlk6Fdciocnq/OnjfBjZvi91pthSh ipEPPgeA3oAFrVmjZAGHgXFCgSerWFoNwBD45nDkcEPYElmk8lOJs3Ikts5dbbLAOdOi SdRIasDbVzdfxh3KAdayUfBOnrc+ZNKNDL7YCxesg4IK+2DUMCKWGqxLlv/QJziVg7CS RQig== X-Gm-Message-State: AOAM533fipoNGx9KWI8EmWsnUwUiBwhB19eVK1YByrJJK4NQEdDfNAcB vGhV79bQ0j3XN5iavDUHjC2GXll5wrlglcLFWcekWJlv30FH+YzVhnKCUq+yhUfzF2XGcAE5yvr GERvb00WBA+gNrJw= X-Received: by 2002:a1c:2042:: with SMTP id g63mr9750098wmg.27.1630500659890; Wed, 01 Sep 2021 05:50:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyzRG+OEsKYt8sp1zBhvpUa60n9k9Ge5WtLkSU7/UVLcGf4LB1vHTYBlHIqAlG8cNzoG4mjbg== X-Received: by 2002:a1c:2042:: with SMTP id g63mr9750086wmg.27.1630500659717; Wed, 01 Sep 2021 05:50:59 -0700 (PDT) Received: from dresden.str.redhat.com ([2a02:908:1e46:160:b272:8083:d5:bc7d]) by smtp.gmail.com with ESMTPSA id o5sm21041632wrw.17.2021.09.01.05.50.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Sep 2021 05:50:59 -0700 (PDT) Subject: Re: [PATCH for-6.2 v3 05/12] job: @force parameter for job_cancel_sync{,_all}() To: Vladimir Sementsov-Ogievskiy , Max Reitz , qemu-block@nongnu.org References: <20210806093859.706464-1-mreitz@redhat.com> <20210806093859.706464-6-mreitz@redhat.com> <4dab108e-0dd4-955a-7877-73895e388413@virtuozzo.com> From: Hanna Reitz Message-ID: Date: Wed, 1 Sep 2021 14:50:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <4dab108e-0dd4-955a-7877-73895e388413@virtuozzo.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=hreitz@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Received-SPF: pass client-ip=170.10.133.124; envelope-from=hreitz@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.392, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.029, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 01.09.21 13:04, Vladimir Sementsov-Ogievskiy wrote: > 06.08.2021 12:38, Max Reitz wrote: >> @@ -726,7 +726,7 @@ static void replication_stop(ReplicationState >> *rs, bool failover, Error **errp) >>            * disk, secondary disk in backup_job_completed(). >>            */ >>           if (s->backup_job) { >> -            job_cancel_sync(&s->backup_job->job); >> +            job_cancel_sync(&s->backup_job->job, false); > > That's not quite correct, as backup is always force cancelled.. Good point.  I think functionally it shouldn’t make a difference, right? – but it’s better to be explicit about it and only use force=false where it actually makes a difference. Hanna