From: "cron2 (Code Review)" Date: Mon, 1 Sep 2025 15:49:20 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="1lo8tb03OBU="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: manage: Make sure various management flags are treated as unsigned List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld , plaisthos Cc: openvpn-devel --1lo8tb03OBU= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has uploaded a new patch set (#11) to the change originally created b= y flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1105?usp=3Demail ) The following approvals got outdated and were removed: Code-Review+2 by plaisthos Change subject: manage: Make sure various management flags are treated as u= nsigned ...................................................................... manage: Make sure various management flags are treated as unsigned The variables that hold them are already unsigned, make sure the flags are as well to avoid spurious conversion warnings. Change-Id: I0937165c5efa95136bd951345a076e33e396f26a Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe Message-Id: <20250826184904.22057-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32= 687.html Signed-off-by: Gert Doering --- M src/openvpn/init.c M src/openvpn/manage.h M src/openvpn/options.h 3 files changed, 41 insertions(+), 41 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/05/1105/11 diff --git a/src/openvpn/init.c b/src/openvpn/init.c index 9dd3b96..39ea8e4 100644 --- a/src/openvpn/init.c +++ b/src/openvpn/init.c @@ -370,7 +370,7 @@ && ((ce->flags >> CE_MAN_QUERY_REMOTE_SHIFT) & CE_MAN_QUERY_REMOTE= _MASK) =3D=3D CE_MAN_QUERY_REMOTE_QUERY) { - int flags =3D 0; + unsigned int flags =3D 0; if (!strcmp(p[1], "ACCEPT")) { flags =3D CE_MAN_QUERY_REMOTE_ACCEPT; diff --git a/src/openvpn/manage.h b/src/openvpn/manage.h index b8892c8..e9e1f95 100644 --- a/src/openvpn/manage.h +++ b/src/openvpn/manage.h @@ -24,24 +24,24 @@ #define MANAGE_H /* management_open flags */ -#define MF_SERVER (1 << 0) -#define MF_QUERY_PASSWORDS (1 << 1) -#define MF_HOLD (1 << 2) -#define MF_SIGNAL (1 << 3) -#define MF_FORGET_DISCONNECT (1 << 4) -#define MF_CONNECT_AS_CLIENT (1 << 5) -#define MF_CLIENT_AUTH (1 << 6) -/* #define MF_CLIENT_PF (1<<7) *REMOVED FEATURE* */ -#define MF_UNIX_SOCK (1 << 8) -#define MF_EXTERNAL_KEY (1 << 9) -#define MF_EXTERNAL_KEY_NOPADDING (1 << 10) -#define MF_EXTERNAL_KEY_PKCS1PAD (1 << 11) -#define MF_UP_DOWN (1 << 12) -#define MF_QUERY_REMOTE (1 << 13) -#define MF_QUERY_PROXY (1 << 14) -#define MF_EXTERNAL_CERT (1 << 15) -#define MF_EXTERNAL_KEY_PSSPAD (1 << 16) -#define MF_EXTERNAL_KEY_DIGEST (1 << 17) +#define MF_SERVER (1u << 0) +#define MF_QUERY_PASSWORDS (1u << 1) +#define MF_HOLD (1u << 2) +#define MF_SIGNAL (1u << 3) +#define MF_FORGET_DISCONNECT (1u << 4) +#define MF_CONNECT_AS_CLIENT (1u << 5) +#define MF_CLIENT_AUTH (1u << 6) +/* #define MF_CLIENT_PF (1u << 7) *REMOVED FEATURE* */ +#define MF_UNIX_SOCK (1u << 8) +#define MF_EXTERNAL_KEY (1u << 9) +#define MF_EXTERNAL_KEY_NOPADDING (1u << 10) +#define MF_EXTERNAL_KEY_PKCS1PAD (1u << 11) +#define MF_UP_DOWN (1u << 12) +#define MF_QUERY_REMOTE (1u << 13) +#define MF_QUERY_PROXY (1u << 14) +#define MF_EXTERNAL_CERT (1u << 15) +#define MF_EXTERNAL_KEY_PSSPAD (1u << 16) +#define MF_EXTERNAL_KEY_DIGEST (1u << 17) #ifdef ENABLE_MANAGEMENT @@ -64,9 +64,9 @@ { unsigned long cid; -#define DAF_CONNECTION_ESTABLISHED (1 << 0) -#define DAF_CONNECTION_CLOSED (1 << 1) -#define DAF_INITIAL_AUTH (1 << 2) +#define DAF_CONNECTION_ESTABLISHED (1u << 0) +#define DAF_CONNECTION_CLOSED (1u << 1) +#define DAF_INITIAL_AUTH (1u << 2) unsigned int flags; unsigned int mda_key_id_counter; @@ -117,23 +117,23 @@ union log_entry_union u; }; -#define LOG_PRINT_LOG_PREFIX (1 << 0) -#define LOG_PRINT_ECHO_PREFIX (1 << 1) -#define LOG_PRINT_STATE_PREFIX (1 << 2) +#define LOG_PRINT_LOG_PREFIX (1u << 0) +#define LOG_PRINT_ECHO_PREFIX (1u << 1) +#define LOG_PRINT_STATE_PREFIX (1u << 2) -#define LOG_PRINT_INT_DATE (1 << 3) -#define LOG_PRINT_MSG_FLAGS (1 << 4) -#define LOG_PRINT_STATE (1 << 5) -#define LOG_PRINT_LOCAL_IP (1 << 6) +#define LOG_PRINT_INT_DATE (1u << 3) +#define LOG_PRINT_MSG_FLAGS (1u << 4) +#define LOG_PRINT_STATE (1u << 5) +#define LOG_PRINT_LOCAL_IP (1u << 6) -#define LOG_PRINT_CRLF (1 << 7) -#define LOG_FATAL_NOTIFY (1 << 8) +#define LOG_PRINT_CRLF (1u << 7) +#define LOG_FATAL_NOTIFY (1u << 8) -#define LOG_PRINT_INTVAL (1 << 9) +#define LOG_PRINT_INTVAL (1u << 9) -#define LOG_PRINT_REMOTE_IP (1 << 10) +#define LOG_PRINT_REMOTE_IP (1u << 10) -#define LOG_ECHO_TO_LOG (1 << 11) +#define LOG_ECHO_TO_LOG (1u << 11) const char *log_entry_print(const struct log_entry *e, unsigned int flags,= struct gc_arena *gc); @@ -175,7 +175,7 @@ { void *arg; -#define MCF_SERVER (1 << 0) /* is OpenVPN being run as a server? */ +#define MCF_SERVER (1u << 0) /* is OpenVPN being run as a server? */ unsigned int flags; void (*status)(void *arg, const int version, struct status_output *so); @@ -253,9 +253,9 @@ int client_gid; /* flags for handling the management interface "signal" command */ -#define MANSIG_IGNORE_USR1_HUP (1 << 0) -#define MANSIG_MAP_USR1_TO_HUP (1 << 1) -#define MANSIG_MAP_USR1_TO_TERM (1 << 2) +#define MANSIG_IGNORE_USR1_HUP (1u << 0) +#define MANSIG_MAP_USR1_TO_HUP (1u << 1) +#define MANSIG_MAP_USR1_TO_TERM (1u << 2) unsigned int mansig; }; diff --git a/src/openvpn/options.h b/src/openvpn/options.h index 44f3fc9..bb2c052 100644 --- a/src/openvpn/options.h +++ b/src/openvpn/options.h @@ -147,14 +147,14 @@ int explicit_exit_notification; /* Explicitly tell peer when we are ex= iting via OCC_EXIT or [RESTART] message */ -#define CE_DISABLED (1 << 0) -#define CE_MAN_QUERY_PROXY (1 << 1) +#define CE_DISABLED (1u << 0) +#define CE_MAN_QUERY_PROXY (1u << 1) #define CE_MAN_QUERY_REMOTE_UNDEF 0 #define CE_MAN_QUERY_REMOTE_QUERY 1 #define CE_MAN_QUERY_REMOTE_ACCEPT 2 #define CE_MAN_QUERY_REMOTE_MOD 3 #define CE_MAN_QUERY_REMOTE_SKIP 4 -#define CE_MAN_QUERY_REMOTE_MASK (0x07) +#define CE_MAN_QUERY_REMOTE_MASK (0x07u) #define CE_MAN_QUERY_REMOTE_SHIFT (2) unsigned int flags; -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1105?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I0937165c5efa95136bd951345a076e33e396f26a Gerrit-Change-Number: 1105 Gerrit-PatchSet: 11 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-MessageType: newpatchset --1lo8tb03OBU= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 uploaded patch set #11 to the change originally c= reated by flichtenheld.

View Change

The following approvals got out= dated and were removed: Code-Review+2 by plaisthos

manage: Make sure various management flags are t=
reated as unsigned

The variables that hold them are already unsigned= , make sure
the flags are as well to avoid spurious conversion warnings.=

Change-Id: I0937165c5efa95136bd951345a076e33e396f26a
Signed-off-= by: Frank Lichtenheld <frank@...2641...>
Acked-by: Arne Schwabe &l= t;arne-openvpn@...1227...>
Message-Id: <20250826184904.22057-1-ger= t@...1296...>
URL: https://www.mail-archive.com/openvpn-devel@...1096...= ourceforge.net/msg32687.html
Signed-off-by: Gert Doering <gert@...1826...= 6...>
---
M src/openvpn/init.c
M src/openvpn/manage.h
M src/= openvpn/options.h
3 files changed, 41 insertions(+), 41 deletions(-)
=
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/05/1105=
/11
diff --git a/src/openvpn/init.c b/src/openvpn/init.c
= index 9dd3b96..39ea8e4 100644
--- a/src/openvpn/init.= c
+++ b/src/openvpn/init.c
@@ -370,7 +370,7= @@
&& ((ce->flags >> CE_MAN_QUER= Y_REMOTE_SHIFT) & CE_MAN_QUERY_REMOTE_MASK)
= =3D=3D CE_MAN_QUERY_REMOTE_QUERY)
{
- int flags =3D 0;
= + unsigned int flags =3D= 0;
if (!strcmp(p[1], "ACCEPT"))<= br> {
flags =3D CE_MAN_QUERY_REM= OTE_ACCEPT;
diff --git a/src/openvpn/manage.h b/src/openvpn= /manage.h
index b8892c8..e9e1f95 100644
---= a/src/openvpn/manage.h
+++ b/src/openvpn/manage.h@@ -24,24 +24,24 @@
#define MANAGE_H

/* management_open flags */
-#define MF_SERVER (1 << 0= )
-#define MF_QUERY_PAS= SWORDS (1 << 1)
-#define MF_HOLD (1 << 2)
-#define MF_SIGNAL (1 <= < 3)
-#define MF_FOR= GET_DISCONNECT (1 << 4)
-#define MF_CONNECT_AS_CLIENT (1 << 5)
-#define MF_CLIENT_AUTH (= 1 << 6)
-/* #defi= ne MF_CLIENT_PF (1<<7) *REMOVED FEATURE* */
-#define MF_UNIX_SOCK (1 &l= t;< 8)
-#define MF_E= XTERNAL_KEY (1 << 9)
-#define MF_EXTERNAL_KEY_NOPADDING (1 << 10)
= -#define MF_EXTERNAL_KEY_PKCS1PAD= (1 << 11)
-#def= ine MF_UP_DOWN (1 << 12)
-#define MF_QUERY_REMOTE (1 << 13)
-#define MF_QUERY_PROXY = (1 << 14)
-#define MF_EXTERNAL_CERT (1 << 15)
-#define MF_EXTERNAL_KEY_PSSPAD (1 <&= lt; 16)
-#define MF_EXT= ERNAL_KEY_DIGEST (1 << 17)
+#define MF_SERVER (1u << 0)+#define MF_QUERY_PASSWORDS = (1u << 1)
= +#define MF_HOLD (1u << 2)
+#define MF_SIGNAL (1u <&l= t; 3)
+#define MF_FOR= GET_DISCONNECT (1u << 4)
+#define MF_CONNECT_AS_CLIENT (1u << 5)+#define MF_CLIENT_AUTH = (1u << 6)
= +/* #define MF_CLIENT_PF (1u << 7) *REMOVED FEATURE* */<= /span>
+#define MF_UNIX_SOCK= (1u << 8)
+#define MF_EXTERNAL_KEY (1u << 9)
+#define MF_EXTERNAL_KEY_NOPADDING (= 1u << 10)

+#def= ine MF_EXTERNAL_KEY_PKCS1PAD (1u << 11)
+#define MF_UP_DOWN (1u << 1= 2)
+#define MF_QUERY_= REMOTE (1u << 13)
+#define MF_QUERY_PROXY (1u << 14)
= +#define MF_EXTERNAL_CERT = (1u << 15)
= +#define MF_EXTERNAL_KEY_PSSPAD (1u << 16)
+#define MF_EXTERNAL_KEY_DIGEST (1u <= ;< 17)


#ifdef ENABL= E_MANAGEMENT
@@ -64,9 +64,9 @@
{ unsigned long cid;

-#define DAF_CONNECTION_ESTABLISHED (1 << 0= )
-#define DAF_CONNECTI= ON_CLOSED (1 << 1)
-#define DAF_INITIAL_AUTH (1 << 2)
+#define DAF_CONNECTION_ESTABLISHED (1= u << 0)
+#defin= e DAF_CONNECTION_CLOSED (1u << 1)
+#define DAF_INITIAL_AUTH (1u << 2)=
unsigned int flags;

unsigned int mda_key_id_counter;

@@ -117,23 +117,23 @= @
union log_entry_union u;
};<= br>
-#define LOG= _PRINT_LOG_PREFIX (1 << 0)
-#define LOG_PRINT_ECHO_PREFIX (1 << 1)
-#define LOG_PRINT_STATE_PREFIX (1 <= < 2)
+#define LOG_= PRINT_LOG_PREFIX (1u << 0)
+#define LOG_PRINT_ECHO_PREFIX (1u << 1)
+#define LOG_PRINT_STATE_PREFIX (1= u << 2)

-#define LOG_PRINT_INT_DATE (1 << 3)
-#define LOG_PRINT_MSG_FLAGS (1 << 4)<= /span>
-#define LOG_PRINT_STAT= E (1 << 5)
-#= define LOG_PRINT_LOCAL_IP (1 << 6)
+#define LOG_PRINT_INT_DATE (1u << 3)+#define LOG_PRINT_MSG_FLAGS (= 1u << 4)
+#defi= ne LOG_PRINT_STATE (1u << 5)
+#define LOG_PRINT_LOCAL_IP (1u << 6)

-#define LOG_PRIN= T_CRLF (1 << 7)
-#define LOG_FATAL_NOTIFY (1 << 8)
+#define LOG_PRINT_CRLF (1u << 7)
+#define LOG_FATAL_NOTIFY (1u <= ;< 8)

-#define LOG_PRINT_INTVAL (1 << 9)
+#define LOG_PRINT_INTVAL (1u << 9)
-#define LOG_P= RINT_REMOTE_IP (1 << 10)
+#define LOG_PRINT_REMOTE_IP (1u << 10)

-#define LOG_ECHO_TO_LOG= (1 << 11)
+#de= fine LOG_ECHO_TO_LOG (1u << 11)

co= nst char *log_entry_print(const struct log_entry *e, unsigned int flags, st= ruct gc_arena *gc);

@@ -175,7 +175,7 @@
{
void *arg;
<= br>-#define MCF_SERVER (1 <<= ; 0) /* is OpenVPN being run as a server? */
+#define MCF_SERVER (1u << 0) /* is OpenVPN b= eing run as a server? */
unsigned int flags;
void (*status)(void *arg, const int version, = struct status_output *so);
@@ -253,9 +253,9 @@
int client_gid;


/* flags for ha= ndling the management interface "signal" command */
-#define MANSIG_IGNORE_USR1_HUP (1 = << 0)

-#define MA= NSIG_MAP_USR1_TO_HUP (1 << 1)
-#define MANSIG_MAP_USR1_TO_TERM (1 << 2)
+#define MANSIG_IGNORE_USR1_HUP (= 1u << 0)
+#defi= ne MANSIG_MAP_USR1_TO_HUP (1u << 1)
+#define MANSIG_MAP_USR1_TO_TERM (1u << 2)
unsigned int mansig;
};
=
diff --git a/src/openvpn/options.h b/src/openvpn/options.h=
index 44f3fc9..bb2c052 100644
--- a/src/op= envpn/options.h
+++ b/src/openvpn/options.h
@@ -147,14 +147,14 @@

int explicit_exit_notification;= /* Explicitly tell peer when we are exiting via OCC_EXIT or
[RESTART] message */

-#define CE_DISAB= LED (1 << 0)
-#define CE_MAN_QUERY_PROXY (1 << 1)
+#define CE_DISABLED = (1u << 0)
+#d= efine CE_MAN_QUERY_PROXY (1u << 1)
#define C= E_MAN_QUERY_REMOTE_UNDEF 0
#define CE_MAN_QUERY_REMOTE_QU= ERY 1
#define CE_MAN_QUERY_REMOTE_ACCEPT 2
#define CE_MAN_QUERY_REMOTE_MOD 3
#define CE_MAN_QUE= RY_REMOTE_SKIP 4
-#de= fine CE_MAN_QUERY_REMOTE_MASK (0x07)
+#define CE_MAN_QUERY_REMOTE_MASK (0x07u)
#define CE_MAN_QUERY_REMOTE_SHIFT (2)
unsigned in= t flags;


To view, vis= it chang= e 1105. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0937165c5efa95136bd951345a0= 76e33e396f26a
Gerrit-Change-Number: 1105
Gerrit-PatchSet: 11
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-MessageType: newpatchset
--1lo8tb03OBU=--