From: Chris Wilson Subject: Re: [Glamor] [PATCH v3] uxa/glamor: Create glamor pixmap by default. Date: Mon, 16 Jan 2012 10:54:33 +0000 Message-ID: References: <1326353415-30914-1-git-send-email-zhigang.gong@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1326353415-30914-1-git-send-email-zhigang.gong@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: zhigang.gong@linux.intel.com Cc: intel-gfx@lists.freedesktop.org, glamor@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, 12 Jan 2012 15:30:15 +0800, zhigang.gong@linux.intel.com wrote: > From: Zhigang Gong > > Chris, > > According to your previous comments. The X server will not die when > fail to get a dri buffer for a glamor pixmap, instead it will return > a BadAlloc. Your previous advice is to pass a BadMatch to the client, > and I traced into X's dri2 module and found current code can only > return a BadAlloc. IMHO, this should be ok. Right? That looks to be the best solution in line with the existing failure mechanisms along that path. > Another change is to disable the reuse of bo for glamor textured > pixmap. > > The last change is reduce the performance gain. ;), I just found > another 10-20% is come from my latest glamor patchset. Hmm, that does suggest that non-native glamor pixmaps were still in use and that they were not being marked non-reusable i.e. they weren't DRI pixmaps. The patch looks good to me, so I've pushed it to master, thanks. -Chris -- Chris Wilson, Intel Open Source Technology Centre