Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 826ABC4332F for ; Thu, 29 Dec 2022 11:27:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230284AbiL2L1t (ORCPT ); Thu, 29 Dec 2022 06:27:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229919AbiL2L1s (ORCPT ); Thu, 29 Dec 2022 06:27:48 -0500 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC2BF13DCE; Thu, 29 Dec 2022 03:27:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672313267; x=1703849267; h=message-id:date:mime-version:subject:to:references:from: in-reply-to:content-transfer-encoding; bh=izooh+aJOq0y9ZY7bsO6ygU34U8zhrGdVSoaIebW5LI=; b=iJkknKiY/uwtGE6fAzcqbWT3Yf42bDd8ODErIVUb8HM3P+DCdix5puf/ 5/rkOw1T+0CCwOo5rvh6IfmwtEx10Y56+el7CQdVfiqKXPFet78/OinyH S148Y8ZvhPubBjGMkRDcy8Ce76D3Wql+4NqBiN0YpCs+TumlmYmitOzTI AyqRagcSuIPcwoQ3RUqCGJCZ/ZEuqdP21pnxNeXplHDR+ksofrtoa0SQ/ x9Eb+aD8NEnJ0JxZdim6ZCkBpsIrUBfoLplHLcWq+XCnV4MojZaN9Kdg+ 9thj/RDX2VbWWV2SNHQosBPPm9qVB9KbpTm8w9uYTQ7V0fsHg89R1LyQM Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10574"; a="383324171" X-IronPort-AV: E=Sophos;i="5.96,283,1665471600"; d="scan'208";a="383324171" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Dec 2022 03:27:46 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10574"; a="653581106" X-IronPort-AV: E=Sophos;i="5.96,283,1665471600"; d="scan'208";a="653581106" Received: from ahunter6-mobl1.ger.corp.intel.com (HELO [10.0.2.15]) ([10.252.63.128]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Dec 2022 03:27:44 -0800 Message-ID: Date: Thu, 29 Dec 2022 13:27:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.6.1 Subject: Re: [PATCH] perf tools: Fix resources leak in perf_data__open_dir Content-Language: en-US To: Miaoqian Lin , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Alexey Bayduraev , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221229090903.1402395-1-linmq006@gmail.com> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki In-Reply-To: <20221229090903.1402395-1-linmq006@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org On 29/12/22 11:09, Miaoqian Lin wrote: > In perf_data__open_dir(), opendir() opens the directory stream. > Add missing closedir() to release it after use. > > Fixes: eb6176709b23 ("perf data: Add perf_data__open_dir_data function") > Signed-off-by: Miaoqian Lin Reviewed-by: Adrian Hunter > --- > tools/perf/util/data.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/perf/util/data.c b/tools/perf/util/data.c > index a7f68c309545..fc16299c915f 100644 > --- a/tools/perf/util/data.c > +++ b/tools/perf/util/data.c > @@ -132,6 +132,7 @@ int perf_data__open_dir(struct perf_data *data) > file->size = st.st_size; > } > > + closedir(dir); > if (!files) > return -EINVAL; > > @@ -140,6 +141,7 @@ int perf_data__open_dir(struct perf_data *data) > return 0; > > out_err: > + closedir(dir); > close_dir(files, nr); > return ret; > }