From: Dan Magenheimer Subject: RE: [PATCH 8/9] tmem: invocations of tmem code fromexisting xen code Date: Fri, 6 Feb 2009 06:25:04 -0800 (PST) Message-ID: References: <498C0B95.76E4.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=Windows-1252 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <498C0B95.76E4.0078.0@novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org > You use do_tmem_op() directly for 32-on-64 mode, which I=20 > think is wrong > given the definition of the interface structure (you'd=20 > minimally have to use > XEN_GUEST_HANDLE_64 in order for this to be correct). But=20 > even if it was > right (or if you make it so), it would in my opinion be a=20 > requirement to > assure it is by adding a respective entry to xen/include/xlat.lst. I have to admit I am baffled by all aspects of XEN_GUEST_HANDLE and just hacked on it until the code worked. I would be grateful for either an explanation of xen/include/xlat.lst or a pointer to an explanation... or, even better, hints on how to fix my code to properly use XEN_GUEST_HANDLE_64. I would like the code to definitely support 32-on-64 and 64-on-64. 32-on-32 is optional; because of xenheap limitations it is largely a toy, but still useful for testing. All of this works today, but possibly only due to hackery, which I am eager to fix properly if told how. Thanks, Dan