References: <20200519220004.25136-1-arne@...1227...> <20200519220004.25136-5-arne@...1227...> From: David Sommerseth Message-ID: Date: Wed, 27 May 2020 23:10:06 +0200 MIME-Version: 1.0 In-Reply-To: <20200519220004.25136-5-arne@...1227...> Content-Language: en-US Subject: Re: [Openvpn-devel] [PATCH v3 4/5] Implement sending AUTH_PENDING challenges to clients List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: Arne Schwabe , openvpn-devel@lists.sourceforge.net On 20/05/2020 00:00, Arne Schwabe wrote: > This implements sending AUTH_PENDING and INFO_PRE messages to clients > that indicate that the clients should be continue authentication with > a second factor. This can currently be out of band (openurl) or a normal > challenge/response two like TOTP (CR_TEXT). > > Unfortunately this patch spend so much time in review in openvpn2 that > the corosponding IV_SSO commit in openvpn3 (34a3f264) already made its > way to released products so changing this right now is difficult. > > https://github.com/OpenVPN/openvpn3/commit/34a3f264f56bd050d9b26d2e7163f88af9a559e2 > > Signed-off-by: Arne Schwabe > --- > doc/management-notes.txt | 86 ++++++++++++++++++++++++++++++++++++++++ > src/openvpn/manage.c | 46 +++++++++++++++++++++ > src/openvpn/manage.h | 3 ++ > src/openvpn/multi.c | 19 +++++++++ > src/openvpn/push.c | 24 +++++++++++ > src/openvpn/push.h | 7 ++++ > 6 files changed, 185 insertions(+) > [...] Only compile tested, as I've done quite some testing earlier. Requested changes are in, with the exception of IV_SSO which we can't change now. Acked-By: David Sommerseth -- kind regards, David Sommerseth OpenVPN Inc