From: "kallisti5 (Code Review)" Date: Tue, 28 Jan 2025 01:50:29 +0000 References: Reply-To: alex@...2837..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="bD7A+58zXvQ="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Haiku: change del to delete in route command. del is undocumented List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos , flichtenheld Cc: openvpn-devel --bD7A+58zXvQ= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/690?usp=3Demail to review the following change. Change subject: Haiku: change del to delete in route command. del is undocu= mented ...................................................................... Haiku: change del to delete in route command. del is undocumented Change-Id: Ieca0f8aa07413682d39e73dd3ed21a0038d41f49 --- M src/openvpn/route.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/90/690/1 diff --git a/src/openvpn/route.c b/src/openvpn/route.c index d17b285..12d6c07 100644 --- a/src/openvpn/route.c +++ b/src/openvpn/route.c @@ -2359,8 +2359,8 @@ #elif defined(TARGET_HAIKU) - /* ex: route del /dev/net/ipro1000/0 inet 192.168.0.0 gw 192.168.1.1 n= etmask 255.255.0.0 */ - argv_printf(&argv, "%s del %s inet %s gw %s netmask %s", + /* ex: route delete /dev/net/ipro1000/0 inet 192.168.0.0 gw 192.168.1.= 1 netmask 255.255.0.0 */ + argv_printf(&argv, "%s delete %s inet %s gw %s netmask %s", ROUTE_PATH, rgi->iface, network, @@ -2551,8 +2551,8 @@ "on connect only and will clean up automatically."); #elif defined(TARGET_HAIKU) - /* ex: route del /dev/net/ipro1000/0 inet6 :: gw beef::cafe prefixlen = 64 */ - argv_printf(&argv, "%s del %s inet6 %s gw %s prefixlen %d", + /* ex: route delete /dev/net/ipro1000/0 inet6 :: gw beef::cafe prefixl= en 64 */ + argv_printf(&argv, "%s delete %s inet6 %s gw %s prefixlen %d", ROUTE_PATH, r6->iface, network, -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/690?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ieca0f8aa07413682d39e73dd3ed21a0038d41f49 Gerrit-Change-Number: 690 Gerrit-PatchSet: 1 Gerrit-Owner: kallisti5 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-MessageType: newchange --bD7A+58zXvQ= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos.

kallisti5 would like plaisthos and flichtenheld to review this change.

Vi= ew Change

Haiku: change del to delete in route command. del is undocume=
nted

Change-Id: Ieca0f8aa07413682d39e73dd3ed21a0038d41f49
---
= M src/openvpn/route.c
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/90/690=
/1
diff --git a/src/openvpn/route.c b/src/openvpn/route.cindex d17b285..12d6c07 100644
--- a/src/openvpn/rout= e.c
+++ b/src/openvpn/route.c
@@ -2359,8 +2= 359,8 @@

#elif defined(TARGET_HAIKU)

- /* = ex: route del /dev/net/ipro1000/0 inet 192.168.0.0 gw 192.168.1.1 netmask 2= 55.255.0.0 */
- argv= _printf(&argv, "%s del %s inet %s gw %s netmask %s",+ /* ex: route delete /dev= /net/ipro1000/0 inet 192.168.0.0 gw 192.168.1.1 netmask 255.255.0.0 */
+ argv_printf(&arg= v, "%s delete %s inet %s gw %s netmask %s",
= ROUTE_PATH,
rgi->iface,
network,
@@ -2551,8 +2551,8 @= @
"on connect only and will clean up automati= cally.");
#elif defined(TARGET_HAIKU)

- /* ex: route de= l /dev/net/ipro1000/0 inet6 :: gw beef::cafe prefixlen 64 */
- argv_printf(&argv, "%s = del %s inet6 %s gw %s prefixlen %d",

+ /* ex: route delete /dev/net/ipro1000/0 inet6 :: = gw beef::cafe prefixlen 64 */
+ argv_printf(&argv, "%s delete %s inet6 %s gw %s pref= ixlen %d",
ROUTE_PATH,
r6->iface,

network,<= /span>

To view, visit change 690. To unsubscribe, o= r for help writing mail filters, visit settings.

=
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ieca0f8aa07413682d39e73dd3ed= 21a0038d41f49
Gerrit-Change-Number: 690
Gerrit-PatchSet: 1
Gerrit-Owner: kallisti5 <alex@...2837...>= ;
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-MessageType: newchange
--bD7A+58zXvQ=--