From: "ordex (Code Review)" Date: Thu, 4 Jan 2024 23:17:56 +0000 In-Reply-To: References: Reply-To: a@...2181..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., gert@...1296... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="qSEgS3qbhZk="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Make it more explicit and visible when pkg-config is not found List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: cron2 , flichtenheld , openvpn-devel --qSEgS3qbhZk= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/465?usp=3Demail ) Change subject: Make it more explicit and visible when pkg-config is not fo= und ...................................................................... Patch Set 3: Code-Review-1 (3 comments) Patchset: PS3: Other than the two comments I added in the code, the patch does what it say= s and it makes very straightforward understanding that pkg-config is now no= t installed. Tested a couple of cases on my lovely gentoo and it just worked. File configure.ac: http://gerrit.openvpn.net/c/openvpn/+/465/comment/a58bb3dc_c4b892a1 : PS3, Line 385: pkg_config_found=3D"(not found)" am I wrong or there is some indentation havoc here? The line above uses 8bl= anks tab, but the lines before have 4 spaces indentation? I think we uses tabs everywhere else. http://gerrit.openvpn.net/c/openvpn/+/465/comment/5512845f_c09de864 : PS3, Line 387: pkg_config_found=3D"(using ${PKG_CONFIG})" many error messages already contain 'using pkg-config', therefore the text = above will lead to 'using using', which sounds weird. How about changing 'using' with 'path:'? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/465?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Iebaa35a23e217a4cd7739af229cbfc08a3d8854a Gerrit-Change-Number: 465 Gerrit-PatchSet: 3 Gerrit-Owner: plaisthos Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: ordex Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Thu, 04 Jan 2024 23:17:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --qSEgS3qbhZk= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos.

Patch set 3:Code-Review -1=

Vi= ew Change

3 comments:

  • Patchset:

    • Patch Set #3:

      Other than the two comments I added in the co= de, the patch does what it says and it makes very straightforward understan= ding that pkg-config is now not installed.
      Tested a couple of cases on m= y lovely gentoo and it just worked.

  • File configure.ac:

    • Patch Set #3, Line 385: pkg_config_found=3D"(not found)"

      <= p style=3D"white-space: pre-wrap; word-wrap: break-word;">am I wrong or the= re is some indentation havoc here? The line above uses 8blanks tab, but the= lines before have 4 spaces indentation?

      I think we uses tabs everywhere else.

    • <= li style=3D"margin: 0; padding: 0 0 0 16px;">

      Patch Set #3, Line 387: pkg_config_found=3D"(using ${PKG_CONFIG})"

      many error message= s already contain 'using pkg-config', therefore the text above will= lead to 'using using', which sounds weird.
      How about changing &= #39;using' with 'path:'?

To view, vis= it change= 465. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Iebaa35a23e217a4cd7739af229c= bfc08a3d8854a
Gerrit-Change-Number: 465
Gerrit-PatchSet: 3
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: ordex <a@...2181...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Thu, 04 Jan 2024 23:17:56= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--qSEgS3qbhZk=--