From: Dhinakaran Pandiyan Subject: Re: [PATCH 1/4] drm/i915/psr: Always wait for idle state when disabling PSR Date: Mon, 08 Oct 2018 15:43:29 -0700 Message-ID: References: <20181005233542.2939-1-jose.souza@intel.com> Reply-To: dhinakaran.pandiyan@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id F2A7789F24 for ; Mon, 8 Oct 2018 22:43:34 +0000 (UTC) In-Reply-To: <20181005233542.2939-1-jose.souza@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?ISO-8859-1?Q?Jos=E9?= Roberto de Souza , intel-gfx@lists.freedesktop.org, Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= Cc: Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCAyMDE4LTEwLTA1IGF0IDE2OjM1IC0wNzAwLCBKb3PDqSBSb2JlcnRvIGRlIFNvdXph IHdyb3RlOgo+IEl0IHNob3VsZCBhbHdheXMgd2FpdCBmb3IgaWRsZSBzdGF0ZSB3aGVuIGRpc2Fi bGluZyBQU1IgYmVjYXVzZSBQU1IKPiBjb3VsZCBiZSBpbmFjdGl2ZSBkdWUgYSBjYWxsIHRvIGlu dGVsX3Bzcl9leGl0KCkgYW5kIHdoaWxlIFBTUiBpcwo+IHN0aWxsIGJlaW5nIGRpc2FibGVkIGFz eW5jaHJvbm91c2x5IHVzZXJzcGFjZSBjb3VsZCBjaGFuZ2UgdGhlCj4gbW9kZXNldCBjYXVzaW5n IGEgY2FsbCB0byBwc3JfZGlzYWJsZSgpIHRoYXQgd2lsbCBub3Qgd2FpdCBmb3IgUFNSCj4gaWRs ZSBhbmQgdGhlbiBQU1Igd2lsbCBiZSBlbmFibGVkIGFnYWluIHdoaWxlIFBTUiBpcyBzdGlsbCBu b3QgaWRsZS4KQWdyZWVkLgoKPiAKPiBDYzogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50 ZWwuY29tPgo+IENjOiBEaGluYWthcmFuIFBhbmRpeWFuIDxkaGluYWthcmFuLnBhbmRpeWFuQGlu dGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBKb3PDqSBSb2JlcnRvIGRlIFNvdXphIDxqb3NlLnNv dXphQGludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMg fCA0MyArKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0KPiAtLQo+ICAxIGZpbGUgY2hhbmdl ZCwgMjAgaW5zZXJ0aW9ucygrKSwgMjMgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jCj4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9wc3IuYwo+IGluZGV4IDQyM2NkZjg0MDU5Yy4uY2Q5YTYwZDFlZmExIDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jCj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfcHNyLmMKPiBAQCAtNjYxLDQwICs2NjEsMzcgQEAgc3RhdGljIHZvaWQK PiAgaW50ZWxfcHNyX2Rpc2FibGVfc291cmNlKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApCj4g IHsKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGRwX3RvX2k5MTUoaW50 ZWxfZHApOwo+ICsJaTkxNV9yZWdfdCBwc3Jfc3RhdHVzOwo+ICsJdTMyIHBzcl9zdGF0dXNfbWFz azsKPiAgCj4gIAlpZiAoZGV2X3ByaXYtPnBzci5hY3RpdmUpIHsKPiAtCQlpOTE1X3JlZ190IHBz cl9zdGF0dXM7Cj4gLQkJdTMyIHBzcl9zdGF0dXNfbWFzazsKPiAtCj4gLQkJaWYgKGRldl9wcml2 LT5wc3IucHNyMl9lbmFibGVkKSB7Cj4gLQkJCXBzcl9zdGF0dXMgPSBFRFBfUFNSMl9TVEFUVVM7 Cj4gLQkJCXBzcl9zdGF0dXNfbWFzayA9IEVEUF9QU1IyX1NUQVRVU19TVEFURV9NQVNLOwo+IC0K PiArCQlpZiAoZGV2X3ByaXYtPnBzci5wc3IyX2VuYWJsZWQpCj4gIAkJCUk5MTVfV1JJVEUoRURQ X1BTUjJfQ1RMLAo+IC0JCQkJICAgSTkxNV9SRUFEKEVEUF9QU1IyX0NUTCkgJgo+IC0JCQkJICAg fihFRFBfUFNSMl9FTkFCTEUgfAo+IEVEUF9TVV9UUkFDS19FTkFCTEUpKTsKPiAtCj4gLQkJfSBl bHNlIHsKPiAtCQkJcHNyX3N0YXR1cyA9IEVEUF9QU1JfU1RBVFVTOwo+IC0JCQlwc3Jfc3RhdHVz X21hc2sgPSBFRFBfUFNSX1NUQVRVU19TVEFURV9NQVNLOwo+IC0KPiArCQkJCSAgIEk5MTVfUkVB RChFRFBfUFNSMl9DVEwpICYKPiB+RURQX1BTUjJfRU5BQkxFKTsKCklzIHRoZXJlIGEgd2F5IHRv IHJldXNlIHBzcl9leGl0KCkgYW5kIG1vdmUgcmVzdCBvZiB0aGUgc3R1ZmYgdG8gdGhlCmNhbGxl cj8gV2Ugd29uJ3Qgbm90IG5lZWQgZGlzYWJsZV9zb3VyY2UoKSBpZiB0aGF0IGNhbiBiZSBkb25l PwoKCgo+ICsJCWVsc2UKPiAgCQkJSTkxNV9XUklURShFRFBfUFNSX0NUTCwKPiAgCQkJCSAgIEk5 MTVfUkVBRChFRFBfUFNSX0NUTCkgJgo+IH5FRFBfUFNSX0VOQUJMRSk7Cj4gLQkJfQo+IC0KPiAt CQkvKiBXYWl0IHRpbGwgUFNSIGlzIGlkbGUgKi8KPiAtCQlpZiAoaW50ZWxfd2FpdF9mb3JfcmVn aXN0ZXIoZGV2X3ByaXYsCj4gLQkJCQkJICAgIHBzcl9zdGF0dXMsCj4gcHNyX3N0YXR1c19tYXNr LCAwLAo+IC0JCQkJCSAgICAyMDAwKSkKPiAtCQkJRFJNX0VSUk9SKCJUaW1lZCBvdXQgd2FpdGlu ZyBmb3IgUFNSIElkbGUKPiBTdGF0ZVxuIik7Cj4gLQo+IC0JCWRldl9wcml2LT5wc3IuYWN0aXZl ID0gZmFsc2U7Cj4gIAl9IGVsc2Ugewo+ICAJCWlmIChkZXZfcHJpdi0+cHNyLnBzcjJfZW5hYmxl ZCkKPiAgCQkJV0FSTl9PTihJOTE1X1JFQUQoRURQX1BTUjJfQ1RMKSAmCj4gRURQX1BTUjJfRU5B QkxFKTsKPiAgCQllbHNlCj4gIAkJCVdBUk5fT04oSTkxNV9SRUFEKEVEUF9QU1JfQ1RMKSAmCj4g RURQX1BTUl9FTkFCTEUpOwo+ICAJfQo+ICsKPiArCWlmIChkZXZfcHJpdi0+cHNyLnBzcjJfZW5h YmxlZCkgewo+ICsJCXBzcl9zdGF0dXMgPSBFRFBfUFNSMl9TVEFUVVM7Cj4gKwkJcHNyX3N0YXR1 c19tYXNrID0gRURQX1BTUjJfU1RBVFVTX1NUQVRFX01BU0s7Cj4gKwl9IGVsc2Ugewo+ICsJCXBz cl9zdGF0dXMgPSBFRFBfUFNSX1NUQVRVUzsKPiArCQlwc3Jfc3RhdHVzX21hc2sgPSBFRFBfUFNS X1NUQVRVU19TVEFURV9NQVNLOwo+ICsJfQo+ICsKPiArCS8qIFdhaXQgdGlsbCBQU1IgaXMgaWRs ZSAqLwo+ICsJaWYgKGludGVsX3dhaXRfZm9yX3JlZ2lzdGVyKGRldl9wcml2LCBwc3Jfc3RhdHVz LAo+IHBzcl9zdGF0dXNfbWFzaywgMCwKPiArCQkJCSAgICAyMDAwKSkKPiArCQlEUk1fRVJST1Io IlRpbWVkIG91dCB3YWl0aW5nIGZvciBQU1IgSWRsZSBTdGF0ZVxuIik7Cj4gKwo+ICsJZGV2X3By aXYtPnBzci5hY3RpdmUgPSBmYWxzZTsKPiAgfQo+ICAKPiAgc3RhdGljIHZvaWQgaW50ZWxfcHNy X2Rpc2FibGVfbG9ja2VkKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApCgoKCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK