Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id EA58918BC78 for ; Mon, 11 Jul 2022 06:12:39 +0000 (UTC) Message-ID: Date: Mon, 11 Jul 2022 11:42:34 +0530 MIME-Version: 1.0 Content-Language: en-US To: Karthik B S , igt-dev@lists.freedesktop.org References: <20220706085746.32363-1-karthik.b.s@intel.com> From: "Sharma, Swati2" In-Reply-To: <20220706085746.32363-1-karthik.b.s@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_cursor_crc: Move output check to the beginning List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: LGTM Reviewed-by: Swati Sharma On 06-Jul-22 2:27 PM, Karthik B S wrote: > This test is failing on headless configurations as the check to verify > if the output is present is at the end of the fixture after other checks. > Move output check to the beginning of the fixture to avoid this failure > and skip the test gracefully. > > Signed-off-by: Karthik B S > --- > tests/kms_cursor_crc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c > index 5c90537b..51bd3c8e 100644 > --- a/tests/kms_cursor_crc.c > +++ b/tests/kms_cursor_crc.c > @@ -873,6 +873,9 @@ igt_main > igt_fixture { > data.drm_fd = drm_open_driver_master(DRIVER_ANY); > > + igt_display_require(&data.display, data.drm_fd); > + igt_display_require_output(&data.display); > + > ret = drmGetCap(data.drm_fd, DRM_CAP_CURSOR_WIDTH, &cursor_width); > igt_assert(ret == 0 || errno == EINVAL); > /* Not making use of cursor_height since it is same as width, still reading */ > @@ -882,9 +885,6 @@ igt_main > kmstest_set_vt_graphics_mode(); > > igt_require_pipe_crc(data.drm_fd); > - > - igt_display_require(&data.display, data.drm_fd); > - igt_display_require_output(&data.display); > } > > data.cursor_max_w = cursor_width; -- ~Swati Sharma