Received: by 2002:a17:907:c68a:b0:84d:2074:29bb with SMTP id ue10csp1493548ejc; Mon, 16 Jan 2023 07:20:08 -0800 (PST) X-Google-Smtp-Source: AMrXdXvr9bkMTXkx0cIMLFsYzkOzNvLftKF5iib/xd7tag30IYKbg25MsaxN2EQ4xjSbR+Oa1T2U X-Received: by 2002:a67:bb02:0:b0:3cf:222a:c432 with SMTP id m2-20020a67bb02000000b003cf222ac432mr11934227vsn.19.1673882408531; Mon, 16 Jan 2023 07:20:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673882408; cv=none; d=google.com; s=arc-20160816; b=aFjjyeINk3uQvn98oCuugPh9W5G+U43cCPxNJp0aZFfAOWt9mqGLWvlW/WoeQRbKLa HRwzzdGRcrijrJMqTCF4AWVoIbzXugEHETIMhXCcGT/BbicAlAHcRMKozhbN2FAqhXvl jZHxIEOrXsvHiSJzMzIkSgLXH7btDxc5OT5PxrM3epcQkOy5KOkjvoWanHci8r915613 aYWe20B1nbKTcznojrAV3gjBAXcp2wCYohra3w6AmwEBljqvE01Uh3OZPFA5W/K0jiKI XQ3pXauhYBfd2hBsED5uorCrWkDEjsaYP9gN/bp5nWtfZzgo+lKMLsCIp0pTGFy7e/cX mEfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :in-reply-to:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:dkim-signature:dkim-filter; bh=Mmwbj8+DX6iQDBlbEOQlcM7mW/eeiXMLStuoVmG8PiY=; b=ATtZrn98haoJ36hFBLRNaJi2RG8Y+qGhHWVjrS7g90V5nlVU7S7t0LrmVVYLrB1Sed ik5AmqLssaSkwr/V7wRQ2zePeu1t/ixCMYWAb3MDRZmwgiD41DDWF4MS71cPOp35KbIn fryfWZ/VBe/NsffwNDWr0aa5U1fG1F8fj//ZHEEszlQTAnckJmTvDZ66ShkVtgAolBNG hj9zc7fG6yJhjBrfN8WKtVoh2oHJhomnPQngRbyBIrFaZCWgwPFaOMds3QAtqoOYkfOf rBZn3lWgvkOJnTzYzKHesIk9ys3DtgY81Y0SO8ru0pMh8Kb/bL7w3WFLc6El8qyT5IfH DEIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=KGPASYhM; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id k1-20020a05620a414100b006e043ac205asi19771179qko.744.2023.01.16.07.20.08 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 16 Jan 2023 07:20:08 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=KGPASYhM; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pHRH1-0006BR-DX; Mon, 16 Jan 2023 10:19:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHRGr-00069s-2f; Mon, 16 Jan 2023 10:19:43 -0500 Received: from linux.microsoft.com ([13.77.154.182]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pHRGp-0006MB-Dl; Mon, 16 Jan 2023 10:19:36 -0500 Received: from [192.168.0.20] (unknown [77.64.253.186]) by linux.microsoft.com (Postfix) with ESMTPSA id 6DFB620DFE75; Mon, 16 Jan 2023 07:19:30 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 6DFB620DFE75 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1673882371; bh=Mmwbj8+DX6iQDBlbEOQlcM7mW/eeiXMLStuoVmG8PiY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=KGPASYhMnekUUzcBZDAd1bV1+7nPkOjYL/1HHlCuDE+4kJ0ze2LdDtiPfXjJSEukv RUmbKInCw9HwIKM9VHgXXZuCwFbB/bbLjcBCgSqcjZpQizh3l67QRlYl4BdXS1xNWG KuIQpyCSMmu32ngxTVBlgTaa/WN/zImLcpfDX0DE= Message-ID: Date: Mon, 16 Jan 2023 16:19:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 3/3] target/arm: allow writes to SCR_EL3.HXEn bit when FEAT_HCX is enabled To: Peter Maydell Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, qemu-stable References: <20230105221251.17896-1-eiakovlev@linux.microsoft.com> <20230105221251.17896-4-eiakovlev@linux.microsoft.com> Content-Language: en-US From: Evgeny Iakovlev In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=13.77.154.182; envelope-from=eiakovlev@linux.microsoft.com; helo=linux.microsoft.com X-Spam_score_int: -198 X-Spam_score: -19.9 X-Spam_bar: ------------------- X-Spam_report: (-19.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, NICE_REPLY_A=-0.097, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: f5VOxaIg1V4t On 1/13/2023 14:20, Peter Maydell wrote: > On Thu, 5 Jan 2023 at 22:13, Evgeny Iakovlev > wrote: >> ARM trusted firmware, when built with FEAT_HCX support, sets SCR_EL3.HXEn bit >> to allow EL2 to modify HCRX_EL2 register without trapping it in EL3. Qemu >> uses a valid mask to clear unsupported SCR_EL3 bits when emulating SCR_EL3 >> write, and that mask doesn't include SCR_EL3.HXEn bit even if FEAT_HCX is >> enabled and exposed to the guest. As a result EL3 writes of that bit are >> ignored. >> >> Signed-off-by: Evgeny Iakovlev >> --- >> target/arm/helper.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/target/arm/helper.c b/target/arm/helper.c >> index bac2ea62c4..962affdd52 100644 >> --- a/target/arm/helper.c >> +++ b/target/arm/helper.c >> @@ -1844,6 +1844,9 @@ static void scr_write(CPUARMState *env, const ARMCPRegInfo *ri, uint64_t value) >> if (cpu_isar_feature(aa64_sme, cpu)) { >> valid_mask |= SCR_ENTP2; >> } >> + if (cpu_isar_feature(aa64_hcx, cpu)) { >> + valid_mask |= SCR_HXEN; >> + } >> } else { >> valid_mask &= ~(SCR_RW | SCR_ST); >> if (cpu_isar_feature(aa32_ras, cpu)) { >> -- > Oops. This is worth > Cc: qemu-stable@nongnu.org > > I think. > > Reviewed-by: Peter Maydell > > I'll take this 3rd patch into target-arm.next now; I've left > review comments for the other 2. > > thanks > -- PMM Thanks, Peter! I'll be addressing the comments today and post a v2 with changes for the first 2.