From: Maarten Lankhorst Subject: Re: [PATCH 1/2] drm/i915: Relocate SKL+ NV12 src width w/a Date: Tue, 23 Oct 2018 15:25:03 +0200 Message-ID: References: <20181018195921.9898-1-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 12FE86E081 for ; Tue, 23 Oct 2018 13:25:05 +0000 (UTC) In-Reply-To: <20181018195921.9898-1-ville.syrjala@linux.intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T3AgMTgtMTAtMTggb20gMjE6NTkgc2NocmVlZiBWaWxsZSBTeXJqYWxhOgo+IEZyb206IFZpbGxl IFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4KPiBUaGUgU0tMKyBO VjEyIHNyYyB3aWR0aCBhbGlnbm1lbnQgdy9hIGlzIHN0aWxsIGxpdmluZyBpbiBhbiBvZGQgcGxh Y2UuCj4gRXZlcnl0aGluZyBlbHNlIHdhcyBhbHJlYWR5IHJlbG9jYXRlZCBjbG9zZXIgdG8gdGhl IG1haW4gcGxhbmUgY2hlY2sKPiBmdW5jdGlvbi4gTW92ZSB0aGlzIHdvcmthcm91bmQgYXMgd2Vs bC4KPgo+IEFzIGEgYm9udXMgd2UgYXZvaWQgdGhlIGZ1bmt5IHJvdGF0ZWQgdnMuIG5vdCBtZXNz IHdpdGggdGhlIHNyYwo+IGNvb3JkaW5hdGVzIGFzIHRoaXMgbm93IGdldHMgY2hlY2tlZCBiZWZv cmUgd2Ugcm90YXRlIHRoZSBjb29yZGluYXRlcy4KPgo+IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5 cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDI1IC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMgIHwgMjEgKysrKysrKysr KysrKysrKysrKysrCj4gIDIgZmlsZXMgY2hhbmdlZCwgMjEgaW5zZXJ0aW9ucygrKSwgMjUgZGVs ZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlz cGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gaW5kZXggZmM3 ZTNiMGJkOTVjLi45NDBkNTE0Y2Y5ZDcgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlz cGxheS5jCj4gQEAgLTMwNDksMjggKzMwNDksNiBAQCBzdGF0aWMgaW50IHNrbF9jaGVja19tYWlu X3N1cmZhY2Uoc3RydWN0IGludGVsX3BsYW5lX3N0YXRlICpwbGFuZV9zdGF0ZSkKPiAgCXJldHVy biAwOwo+ICB9Cj4gIAo+IC1zdGF0aWMgaW50Cj4gLXNrbF9jaGVja19udjEyX3N1cmZhY2Uoc3Ry dWN0IGludGVsX3BsYW5lX3N0YXRlICpwbGFuZV9zdGF0ZSkKPiAtewo+IC0JLyogRGlzcGxheSBX QSAjMTEwNiAqLwo+IC0JaWYgKHBsYW5lX3N0YXRlLT5iYXNlLnJvdGF0aW9uICE9Cj4gLQkgICAg KERSTV9NT0RFX1JFRkxFQ1RfWCB8IERSTV9NT0RFX1JPVEFURV85MCkgJiYKPiAtCSAgICBwbGFu ZV9zdGF0ZS0+YmFzZS5yb3RhdGlvbiAhPSBEUk1fTU9ERV9ST1RBVEVfMjcwKQo+IC0JCXJldHVy biAwOwo+IC0KPiAtCS8qCj4gLQkgKiBzcmMgY29vcmRpbmF0ZXMgYXJlIHJvdGF0ZWQgaGVyZS4K PiAtCSAqIFdlIGNoZWNrIGhlaWdodCBidXQgcmVwb3J0IGl0IGFzIHdpZHRoCj4gLQkgKi8KPiAt CWlmICgoKGRybV9yZWN0X2hlaWdodCgmcGxhbmVfc3RhdGUtPmJhc2Uuc3JjKSA+PiAxNikgJSA0 KSAhPSAwKSB7Cj4gLQkJRFJNX0RFQlVHX0tNUygic3JjIHdpZHRoIG11c3QgYmUgbXVsdGlwbGUg Igo+IC0JCQkgICAgICAib2YgNCBmb3Igcm90YXRlZCBOVjEyXG4iKTsKPiAtCQlyZXR1cm4gLUVJ TlZBTDsKPiAtCX0KPiAtCj4gLQlyZXR1cm4gMDsKPiAtfQo+IC0KPiAgc3RhdGljIGludCBza2xf Y2hlY2tfbnYxMl9hdXhfc3VyZmFjZShzdHJ1Y3QgaW50ZWxfcGxhbmVfc3RhdGUgKnBsYW5lX3N0 YXRlKQo+ICB7Cj4gIAljb25zdCBzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYiA9IHBsYW5lX3N0 YXRlLT5iYXNlLmZiOwo+IEBAIC0zMTUzLDkgKzMxMzEsNiBAQCBpbnQgc2tsX2NoZWNrX3BsYW5l X3N1cmZhY2Uoc3RydWN0IGludGVsX3BsYW5lX3N0YXRlICpwbGFuZV9zdGF0ZSkKPiAgCSAqIHRo ZSBtYWluIHN1cmZhY2Ugc2V0dXAgZGVwZW5kcyBvbiBpdC4KPiAgCSAqLwo+ICAJaWYgKGZiLT5m b3JtYXQtPmZvcm1hdCA9PSBEUk1fRk9STUFUX05WMTIpIHsKPiAtCQlyZXQgPSBza2xfY2hlY2tf bnYxMl9zdXJmYWNlKHBsYW5lX3N0YXRlKTsKPiAtCQlpZiAocmV0KQo+IC0JCQlyZXR1cm4gcmV0 Owo+ICAJCXJldCA9IHNrbF9jaGVja19udjEyX2F1eF9zdXJmYWNlKHBsYW5lX3N0YXRlKTsKPiAg CQlpZiAocmV0KQo+ICAJCQlyZXR1cm4gcmV0Owo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9zcHJpdGUuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nwcml0 ZS5jCj4gaW5kZXggN2NkNTllZWU1Y2FkLi4wZmU2YzY2NGU4M2MgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9zcHJpdGUuYwo+IEBAIC0xMzQyLDYgKzEzNDIsMjMgQEAgc3RhdGljIGludCBz a2xfcGxhbmVfY2hlY2tfZHN0X2Nvb3JkaW5hdGVzKGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0 YXRlICpjcnRjX3MKPiAgCXJldHVybiAwOwo+ICB9Cj4gIAo+ICtzdGF0aWMgaW50IHNrbF9wbGFu ZV9jaGVja19udjEyX3JvdGF0aW9uKGNvbnN0IHN0cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZSAqcGxh bmVfc3RhdGUpCj4gK3sKPiArCWNvbnN0IHN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiID0gcGxh bmVfc3RhdGUtPmJhc2UuZmI7Cj4gKwl1bnNpZ25lZCBpbnQgcm90YXRpb24gPSBwbGFuZV9zdGF0 ZS0+YmFzZS5yb3RhdGlvbjsKPiArCWludCBzcmNfdyA9IGRybV9yZWN0X3dpZHRoKCZwbGFuZV9z dGF0ZS0+YmFzZS5zcmMpID4+IDE2Owo+ICsKPiArCS8qIERpc3BsYXkgV0EgIzExMDYgKi8KPiAr CWlmIChmYi0+Zm9ybWF0LT5mb3JtYXQgPT0gRFJNX0ZPUk1BVF9OVjEyICYmIHNyY193ICYgMyAm JgpDb3VsZCB3ZSBwdXQgbW9yZSBudjEyIGNoZWNrcyBoZXJlPyBJIHdhbnQgdG8gcHVsbCB0aGUg c2NhbGVyIFNSQyBXL0ggY2hlY2tzIGluIGFzIHdlbGwuLgoKUHJvYmFibHkgc3R5bGl6ZSBpdCBh IGJpdCB3aXRoIGFuIGVhcmx5IHJldHVybiBmb3IgIU5WMTIsIHNvIGFsbCBjaGVja3MgY29tZSBh ZnRlciB0aGF0LiA6KQoKfk1hYXJ0ZW4KCk90aGVyIHRoYW4gdGhhdCBwYXRjaCAxLTIgbG9vayBn b29kLCBzbyBoYXZlIGEgci1iIHdpdGggb3Igd2l0aG91dCB0aG9zZSBzdWdnZXN0ZWQgY2hhbmdl cy4KPiArCSAgICAocm90YXRpb24gPT0gRFJNX01PREVfUk9UQVRFXzI3MCB8fAo+ICsJICAgICBy b3RhdGlvbiA9PSAoRFJNX01PREVfUkVGTEVDVF9YIHwgRFJNX01PREVfUk9UQVRFXzkwKSkpIHsK PiArCQlEUk1fREVCVUdfS01TKCJzcmMgd2lkdGggbXVzdCBiZSBtdWx0aXBsZSBvZiA0IGZvciBy b3RhdGVkIE5WMTJcbiIpOwo+ICsJCXJldHVybiAtRUlOVkFMOwo+ICsJfQo+ICsKPiArCXJldHVy biAwOwo+ICt9Cj4gKwo+ICBzdGF0aWMgaW50IHNrbF9wbGFuZV9jaGVjayhzdHJ1Y3QgaW50ZWxf Y3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSwKPiAgCQkJICAgc3RydWN0IGludGVsX3BsYW5lX3N0YXRl ICpwbGFuZV9zdGF0ZSkKPiAgewo+IEBAIC0xMzgwLDYgKzEzOTcsMTAgQEAgc3RhdGljIGludCBz a2xfcGxhbmVfY2hlY2soc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUsCj4gIAlp ZiAocmV0KQo+ICAJCXJldHVybiByZXQ7Cj4gIAo+ICsJcmV0ID0gc2tsX3BsYW5lX2NoZWNrX252 MTJfcm90YXRpb24ocGxhbmVfc3RhdGUpOwo+ICsJaWYgKHJldCkKPiArCQlyZXR1cm4gcmV0Owo+ ICsKPiAgCXJldCA9IHNrbF9jaGVja19wbGFuZV9zdXJmYWNlKHBsYW5lX3N0YXRlKTsKPiAgCWlm IChyZXQpCj4gIAkJcmV0dXJuIHJldDsKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9pbnRlbC1nZngK