From: "cron2 (Code Review)" Date: Tue, 28 Jan 2025 19:06:11 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., alex@...2837..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="jQuh7bfjtkA="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Haiku: Fix short interface path length List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: kallisti5 , plaisthos , flichtenheld Cc: openvpn-devel --jQuh7bfjtkA= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has uploaded a new patch set (#2) to the change originally created by= kallisti5. ( http://gerrit.openvpn.net/c/openvpn/+/689?usp=3Demail ) The following approvals got outdated and were removed: Code-Review+2 by flichtenheld Change subject: Haiku: Fix short interface path length ...................................................................... Haiku: Fix short interface path length * Haiku uses full paths for interface names, 16 characters isn't enough. Change-Id: I6de60ed5c03ea45e1d7a3f7777bfc8ed5075e84d Signed-off-by: Alexander von Gluck Acked-by: Frank Lichtenheld Message-Id: <20250128124026.108992-1-frank@...2641...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg30= 654.html Signed-off-by: Gert Doering --- M src/openvpn/route.h 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/89/689/2 diff --git a/src/openvpn/route.h b/src/openvpn/route.h index 421e7d2..69b06b8 100644 --- a/src/openvpn/route.h +++ b/src/openvpn/route.h @@ -155,6 +155,8 @@ /* gateway interface */ #ifdef _WIN32 DWORD adapter_index; /* interface or ~0 if undefined */ +#elif defined(TARGET_HAIKU) + char iface[PATH_MAX]; /* iface names are full /dev path with driver na= me */ #else char iface[16]; /* interface name (null terminated), may be empty */ #endif @@ -186,8 +188,13 @@ #else /* non linux platform don't have this constant defined */ #ifndef IFNAMSIZ +#if defined(TARGET_HAIKU) +/* iface names are full /dev path with driver name */ +#define IFNAMSIZ PATH_MAX +#else #define IFNAMSIZ 16 #endif +#endif char iface[IFNAMSIZ]; /* interface name (null terminated), may be empt= y */ #endif -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/689?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I6de60ed5c03ea45e1d7a3f7777bfc8ed5075e84d Gerrit-Change-Number: 689 Gerrit-PatchSet: 2 Gerrit-Owner: kallisti5 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-MessageType: newpatchset --jQuh7bfjtkA= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 uploaded patch set #2 to the change originally cr= eated by kallisti5.

View Change

The following approvals got outdated= and were removed: Code-Review+2 by flichtenheld

Haiku: Fix short interface path length
* Haiku uses full paths for interface names, 16 characters
isn't = enough.

Change-Id: I6de60ed5c03ea45e1d7a3f7777bfc8ed5075e84d
Sign= ed-off-by: Alexander von Gluck <alex@...2837...>
Acked-by: Frank L= ichtenheld <frank@...2641...>
Message-Id: <20250128124026.10899= 2-1-frank@...2641...>
URL: https://www.mail-archive.com/openvpn-devel= @lists.sourceforge.net/msg30654.html
Signed-off-by: Gert Doering <ger= t@...1296...>
---
M src/openvpn/route.h
1 file changed, 7 inser= tions(+), 0 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/=
openvpn refs/changes/89/689/2
diff --git a/src/openvpn/route.h b/sr=
c/openvpn/route.h
index 421e7d2..69b06b8 100644
<= span>--- a/src/openvpn/route.h
+++ b/src/openvpn/route.h
@@ -155,6 +155,8 @@
/* gateway interface= */
#ifdef _WIN32
DWORD adapter_index= ; /* interface or ~0 if undefined */
+#elif defined(TARGET_HAIKU)
+ char iface[PATH_MAX]; /* iface names are full = /dev path with driver name */
#else
c= har iface[16]; /* interface name (null terminated), may be empty */<= br> #endif
@@ -186,8 +188,13 @@
#els= e
/* non linux platform don't have this constant d= efined */
#ifndef IFNAMSIZ
+#if defined(TARGET_HAIKU)
+/* iface names are full /dev path with driver= name */
+#define IFN= AMSIZ PATH_MAX
+#else=
#define IFNAMSIZ 16
#endif
+#endif

char = iface[IFNAMSIZ]; /* interface name (null terminated), may be empty */
#endif


To= view, visit change 689. To unsubscribe, or for help writing mail filters, visit= settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6de60ed5c03ea45e1d7a3f7777b= fc8ed5075e84d
Gerrit-Change-Number: 689
Gerrit-PatchSet: 2
Gerrit-Owner: kallisti5 <alex@...2837...>= ;
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-MessageType: newpatchset
--jQuh7bfjtkA=--