Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49A54C07E95 for ; Sun, 4 Jul 2021 07:51:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 19D8261357 for ; Sun, 4 Jul 2021 07:51:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229529AbhGDHyT (ORCPT ); Sun, 4 Jul 2021 03:54:19 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:20402 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229492AbhGDHyS (ORCPT ); Sun, 4 Jul 2021 03:54:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625385103; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wFeANVjBL3oUSMOrf3SAKuL3KkWOGgb1KQrWoBxR6aQ=; b=ZOtxdVOR52ccUdAlndy7qfJYADktdeMgBKEBLvx3p7RT3zpVy3V1Gp7UQmLS6E6eqFmbHj tkFn90A0cGCw2sZ6zm54NAhgztsqZMTgf9hC16ANp4vElHjE8K55ZCAatmIESTAPa7Z94t aydvXMizKWlQ/nTlTBbFFZqySTTefYQ= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-98-Ztgn2413M1mUKWx6DXvDGg-1; Sun, 04 Jul 2021 03:51:42 -0400 X-MC-Unique: Ztgn2413M1mUKWx6DXvDGg-1 Received: by mail-wm1-f69.google.com with SMTP id y14-20020a1c7d0e0000b02901edd7784928so8194830wmc.2 for ; Sun, 04 Jul 2021 00:51:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=wFeANVjBL3oUSMOrf3SAKuL3KkWOGgb1KQrWoBxR6aQ=; b=ENGUsbEM65Mzf4ujfnKd3sMDZFgdCw0ce4PBgipApn/TQiM0ECpFjTiMZdGQVtd9lf 7RJWyFATpKdHa9aCdvTkFPbeL9OIIRsvuwXBTlrq7X8xgIDfqs7Sb5aYuBvoE7CE8nOR UYMJoHeUQlBPYWS+CgxqjhYUUrKs4RovgAt/hEj+5EGrbv7ieFdg9VSFn+oKYgKqQL2z ApCpOrvl8YESVkxNtg8esEQ1t2sj27axqS6fr/LrUx26iSEjqcvwi0p7ACIPnZabkOkg gZcQsfl4AQgtWigInj6mr2rH5NeiFkZ/zmxWthOHHvTqz91gyzclalRdz+xoTc32//5j +Wxw== X-Gm-Message-State: AOAM533x/inrHE2QjXJIKHTaa3ElFM/F+ppV3ubRxFY2ywvOr7kXfnz8 A+KXCq200TjsoI5oiiPlG2vDvJfTWsyEFSFsdtvW/IdMdYMrWZfyvueBH2jbsr21IZaLtZfPpmR EdbmIyTbkmnqXqoKxybjVKw== X-Received: by 2002:a5d:4f02:: with SMTP id c2mr9010906wru.229.1625385101004; Sun, 04 Jul 2021 00:51:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyYk520209EH2QolTz3Mrr1WNyunXDavMaqdnxg9rca1IBxuGO+U/S3ZzwKrAOcI+hQkkVFNQ== X-Received: by 2002:a5d:4f02:: with SMTP id c2mr9010899wru.229.1625385100868; Sun, 04 Jul 2021 00:51:40 -0700 (PDT) Received: from thuth.remote.csb (p5791d89b.dip0.t-ipconnect.de. [87.145.216.155]) by smtp.gmail.com with ESMTPSA id w9sm8531985wmc.19.2021.07.04.00.51.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 04 Jul 2021 00:51:40 -0700 (PDT) Subject: Re: [kvm-unit-tests PATCH 3/5] lib: s390x: uv: Int type cleanup To: Janosch Frank , kvm@vger.kernel.org Cc: linux-s390@vger.kernel.org, imbrenda@linux.ibm.com, david@redhat.com, cohuck@redhat.com References: <20210629133322.19193-1-frankja@linux.ibm.com> <20210629133322.19193-4-frankja@linux.ibm.com> From: Thomas Huth Message-ID: Date: Sun, 4 Jul 2021 09:51:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210629133322.19193-4-frankja@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-s390@vger.kernel.org On 29/06/2021 15.33, Janosch Frank wrote: > These structs have largely been copied from the kernel so they still > have the old uint short types which we want to avoid in favor of the > uint*_t ones. > > Signed-off-by: Janosch Frank > --- > lib/s390x/asm/uv.h | 142 +++++++++++++++++++++++---------------------- > 1 file changed, 72 insertions(+), 70 deletions(-) > > diff --git a/lib/s390x/asm/uv.h b/lib/s390x/asm/uv.h > index dc3e02d..96a2a7e 100644 > --- a/lib/s390x/asm/uv.h > +++ b/lib/s390x/asm/uv.h > @@ -12,6 +12,8 @@ > #ifndef _ASMS390X_UV_H_ > #define _ASMS390X_UV_H_ > > +#include > + > #define UVC_RC_EXECUTED 0x0001 > #define UVC_RC_INV_CMD 0x0002 > #define UVC_RC_INV_STATE 0x0003 > @@ -68,73 +70,73 @@ enum uv_cmds_inst { > }; > > struct uv_cb_header { > - u16 len; > - u16 cmd; /* Command Code */ > - u16 rc; /* Response Code */ > - u16 rrc; /* Return Reason Code */ > + uint16_t len; > + uint16_t cmd; /* Command Code */ > + uint16_t rc; /* Response Code */ > + uint16_t rrc; /* Return Reason Code */ > } __attribute__((packed)) __attribute__((aligned(8))); Hmm, for files that are more or less a copy from the corresponding kernel header, I'm not sure whether it makes sense to convert them to the stdint.h types? It might be better to keep the kernel types so that updates to this header can be ported more easily to the kvm-unit-tests later? Thomas