Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F99BC43461 for ; Thu, 17 Sep 2020 11:43:14 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 09B1621D7F for ; Thu, 17 Sep 2020 11:43:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=suse.com header.i=@suse.com header.b="mMVl53cH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 09B1621D7F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kIsJY-0006Di-Rd; Thu, 17 Sep 2020 11:43:00 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kIsJY-0006Dd-0S for xen-devel@lists.xenproject.org; Thu, 17 Sep 2020 11:43:00 +0000 X-Inumbo-ID: 6a15c8be-5dda-4249-917c-c00d3b7facc9 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6a15c8be-5dda-4249-917c-c00d3b7facc9; Thu, 17 Sep 2020 11:42:59 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=cantorsusede; t=1600342978; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=owwiD+PmtcEPe+5U1Jb9rAgsD8BVM/ZWnOV7Ow7w8kY=; b=mMVl53cHi1I//D/PEIFzNg9hSG5mJvVtyXqIHC/eORv3hmqZuBnhZ+kWdx3kmyRPCTiUAn 5/wLGA3XcTP4Hs7Cwpby+gGjgLmLwbS4UhJJuPwtnTJ5ZSlzR25eVdN5JKAaBIWNnT+e1m +jF3dQX0cG/FCaxG9mmwdfY+weGaAPXH0MkFwZ9q+4RxyJvoYKy/KjMg5D6tCd2pcPIFDJ L4eoQX5IQpfcvr1si1DCicZqFYwD6w+qKEdq3IRSHm/6ljSY2QjMvPoe82nelD3E+GtNfU C7+QLdlz8z+VAXdrLzdK2snHWMU5DIFpF2m1D/tS3s0BYTfrVlmgSwpcTcPwjQ== Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 4EA7FB350; Thu, 17 Sep 2020 11:43:32 +0000 (UTC) Subject: Re: [PATCH] EFI: some easy constification To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , Stefano Stabellini , Julien Grall , Trammell Hudson References: <20200917114027.GD19254@Air-de-Roger> From: Jan Beulich Message-ID: Date: Thu, 17 Sep 2020 13:42:59 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200917114027.GD19254@Air-de-Roger> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 17.09.2020 13:40, Roger Pau Monné wrote: > On Thu, Sep 17, 2020 at 01:27:12PM +0200, Jan Beulich wrote: >> Inspired by some of Trammell's suggestions, this harvests some low >> hanging fruit, without needing to be concerned about the definitions of >> the EFI interfaces themselves. >> >> Signed-off-by: Jan Beulich > > This is purely a non-functional change AFAICT? > > Acked-by: Roger Pau Monné Indeed. Merely adding const with no other changes hardly can have any functional effect, I think. Unless it broke the build in some way, in which case I wouldn't [knowingly] have sent the patch. Jan