Return-Path: Return-Path: Subject: Re: [PATCH 5/5] remoteproc: Introduce prepare and unprepare for subdevices References: <20180515205345.8090-1-elder@linaro.org> <20180515205345.8090-6-elder@linaro.org> <3580eff5-56ef-c2a0-c8eb-c27850598587@st.com> From: Alex Elder Message-ID: Date: Tue, 29 May 2018 06:51:57 -0500 MIME-Version: 1.0 In-Reply-To: <3580eff5-56ef-c2a0-c8eb-c27850598587@st.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit To: Arnaud Pouliquen , ohad@wizery.com, bjorn.andersson@linaro.org Cc: linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: On 05/29/2018 04:16 AM, Arnaud Pouliquen wrote: . . . >> +unroll_preparation: >> + list_for_each_entry_continue_reverse(subdev, &rproc->subdevs, node) { >> + if (subdev->unprepare) >> + subdev->unprepare(subdev); >> + } > Here you could call rproc_unprepare_subdevices instead of duplicating > the code. I thought the same thing, but it won't work because we only want to unprepare those devices that were successfully prepared. Here we are unwinding the work that was partially done; in rproc_unprepare_subdevices() *all* subdevices have their unprepare function called. -Alex