From: "d12fk (Code Review)" Date: Tue, 9 Jan 2024 14:39:14 +0000 In-Reply-To: References: Reply-To: heiko@...515..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., gert@...1296... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="o3/HWXLwMuo="; charset=UTF-8 Subject: [Openvpn-devel] [L] Change in openvpn[master]: Windows: enforce 'block-local' with WFP filters List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: flichtenheld , cron2 , plaisthos , openvpn-devel --o3/HWXLwMuo= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: cron2, flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/489?usp=3Demail ) Change subject: Windows: enforce 'block-local' with WFP filters ...................................................................... Patch Set 2: (1 comment) File src/openvpn/init.c: http://gerrit.openvpn.net/c/openvpn/+/489/comment/536482e0_0434a02b : PS1, Line 1971: /* Fortify 'redirect-gateway block-local' with fire= wall rules? */ > I think there's even more duplicate code before. [=E2=80=A6] Okay there's not much to gain with respect to breaking out run_up_down, as = that one requires too much special handling between the up and down cases. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/489?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ic9bf797bfc7e2d471998a84cb0f071db3e4832ba Gerrit-Change-Number: 489 Gerrit-PatchSet: 2 Gerrit-Owner: d12fk Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: cron2 Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: cron2 Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Tue, 09 Jan 2024 14:39:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld Comment-In-Reply-To: d12fk Gerrit-MessageType: comment --o3/HWXLwMuo= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: cron2, flichtenheld, plaisthos. <= /p>

View C= hange

1 comment:

    <= li style=3D"margin: 0; padding: 0;">

    File src/openvpn/init.c:

    • Patch Set #1, Line 1971: <= code style=3D"font-family:monospace,monospace"> /* Fortify 'redi= rect-gateway block-local' with firewall rules? */

      I think there's even more duplicate code before. [=E2=80=A6]

      Okay ther= e's not much to gain with respect to breaking out run_up_down, as that = one requires too much special handling between the up and down cases.

To view, visit change 489. To unsubscribe, or for help writ= ing mail filters, visit sett= ings.

<= link itemprop=3D"url" href=3D"http://gerrit.openvpn.net/c/openvpn/+/489?usp= =3Demail"/>
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ic9bf797bfc7e2d471998a84cb0f= 071db3e4832ba
Gerrit-Change-Number: 489
Gerrit-PatchSet: 2
Gerrit-Owner: d12fk <heiko@...515...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: cron2 <gert@...1296...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: cron2 <gert@...1296...>= ;
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Tue, 09 Jan 2024 14:39:14= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <frank@...1186...= .2641...>
Comment-In-Reply-To: d12fk <heiko@...515...= >
Gerrit-MessageType: comment
--o3/HWXLwMuo=--