From: Dhinakaran Pandiyan Subject: Re: [PATCH 2/2] drm/i915/psr: Remove wait_for_idle() for PSR2 Date: Wed, 15 Aug 2018 18:35:15 -0700 Message-ID: References: <20180810004135.11569-1-dhinakaran.pandiyan@intel.com> <20180810004135.11569-2-dhinakaran.pandiyan@intel.com> <20180813165729.GF24245@intel.com> <7b65a70857d4510251a5fcb4cac325813084b417.camel@intel.com> Reply-To: dhinakaran.pandiyan@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id DCFFB6E173 for ; Thu, 16 Aug 2018 01:35:27 +0000 (UTC) In-Reply-To: <7b65a70857d4510251a5fcb4cac325813084b417.camel@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Vivi, Rodrigo" , "Vyas, Tarun" , =?ISO-8859-1?Q?Jos=E9?= Roberto de Souza Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCAyMDE4LTA4LTEzIGF0IDE4OjEwICswMDAwLCBQYW5kaXlhbiwgRGhpbmFrYXJhbiB3 cm90ZToKPiBPbiBNb24sIDIwMTgtMDgtMTMgYXQgMDk6NTcgLTA3MDAsIFJvZHJpZ28gVml2aSB3 cm90ZToKPiA+IE9uIFRodSwgQXVnIDA5LCAyMDE4IGF0IDA1OjQxOjM1UE0gLTA3MDAsIERoaW5h a2FyYW4gUGFuZGl5YW4KPiA+IHdyb3RlOgo+ID4gPiBDSSBydW5zIHNob3cgUFNSMiBkb2VzIG5v dCBnbyB0byBJRExFIHdpdGggc2VsZWN0aXZlIHVwZGF0ZQo+ID4gPiBlbmFibGVkCj4gPiA+IG9u Cj4gPiA+IGFsbCBQU1IgZXhpdCB0cmlnZ2Vycy4gU3BlY2lmaWNhbGx5LCBsb2dzIGluZGljYXRl IHRoZSBoYXJkd2FyZQo+ID4gPiBlbnRlcnMKPiA+ID4gIlNMRUVQIFNlbGVjdGl2ZSBVcGRhdGUi IGFuZCBub3QgIklETEUgUmVzZXQgc3RhdGUnIGxpa2UgdGhlCj4gPiA+IGtlcm5lbAo+ID4gPiBl eHBlY3RzLiBUaGlzIGNoZWNrIHdhcyBhZGRlZCBmb3IgUFNSMSBidXQgaW5jb3JyZWN0bHkgZXh0 ZW5kZWQKPiA+ID4gdG8KPiA+ID4gUFNSMiwKPiA+ID4gcmVtb3ZlIHRoaXMgY2hlY2sgZm9yIFBT UjIgYXMgdGhlcmUgaXMgYSBwbGFuIHRvIHRlc3Qgb25seSBQU1IxCj4gPiA+IG9uCj4gPiA+IFBT UjIKPiA+ID4gcGFuZWxzLgo+ID4gPiAKPiA+ID4gQWxzbyBhZGQgYnNwZWMgcmVmZXJlbmNlIHRv IHRoZSBjb21tZW50IGFib3V0IGlkbGUgdGltZW91dC4KPiA+ID4gCj4gPiA+IENjOiBUYXJ1biBW eWFzIDx0YXJ1bi52eWFzQGludGVsLmNvbT4KPiA+ID4gQ2M6IEpvc8OpIFJvYmVydG8gZGUgU291 emEgPGpvc2Uuc291emFAaW50ZWwuY29tPgo+ID4gPiBDYzogUm9kcmlnbyBWaXZpIDxyb2RyaWdv LnZpdmlAaW50ZWwuY29tPgo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBEaGluYWthcmFuIFBhbmRpeWFu IDxkaGluYWthcmFuLnBhbmRpeWFuQGludGVsLmNvbQo+ID4gPiA+Cj4gPiA+IC0tLQo+ID4gPiAg ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMgfCAzOSArKysrKysrKysrKystLS0tLS0t LS0tLS0tLQo+ID4gPiAtLS0tLS0KPiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCAxNCBpbnNlcnRpb25z KCspLCAyNSBkZWxldGlvbnMoLSkKPiA+ID4gCj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9wc3IuYwo+ID4gPiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X3Bzci5jCj4gPiA+IGluZGV4IDU2ODZkZGFhNmE3Mi4uMDliZTliZmVlMmJlIDEwMDY0NAo+ID4g PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYwo+ID4gPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYwo+ID4gPiBAQCAtNzIyLDM3ICs3MjIsMjYgQEAg aW50IGludGVsX3Bzcl93YWl0X2Zvcl9pZGxlKGNvbnN0IHN0cnVjdAo+ID4gPiBpbnRlbF9jcnRj X3N0YXRlICpuZXdfY3J0Y19zdGF0ZSwKPiA+ID4gIHsKPiA+ID4gIAlzdHJ1Y3QgaW50ZWxfY3J0 YyAqY3J0YyA9IHRvX2ludGVsX2NydGMobmV3X2NydGNfc3RhdGUtCj4gPiA+ID4gYmFzZS5jcnRj KTsKPiA+ID4gCj4gPiA+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9f aTkxNShjcnRjLQo+ID4gPiA+IGJhc2UuZGV2KTsKPiA+ID4gCj4gPiA+IC0JaTkxNV9yZWdfdCBy ZWc7Cj4gPiA+IC0JdTMyIG1hc2s7Cj4gPiA+IC0KPiA+ID4gLQlpZiAoIW5ld19jcnRjX3N0YXRl LT5oYXNfcHNyKQo+ID4gPiAtCQlyZXR1cm4gMDsKPiA+ID4gIAo+ID4gPiAgCS8qCj4gPiA+IC0J ICogVGhlIHNvbGUgdXNlciByaWdodCBub3cgaXMgaW50ZWxfcGlwZV91cGRhdGVfc3RhcnQoKSwK PiA+ID4gLQkgKiB3aGljaCB3b24ndCByYWNlIHdpdGggcHNyX2VuYWJsZS9kaXNhYmxlLCB3aGlj aCBpcwo+ID4gPiAtCSAqIHdoZXJlIHBzcjJfZW5hYmxlZCBpcyB3cml0dGVuIHRvLiBTbywgd2Ug ZG9uJ3QgbmVlZAo+ID4gPiAtCSAqIHRvIGFjcXVpcmUgdGhlIHBzci5sb2NrLiBNb3JlIGltcG9y dGFudGx5LCB3ZSB3YW50Cj4gPiA+IHRoZQo+ID4gPiAtCSAqIGxhdGVuY3kgaW5zaWRlIGludGVs X3BpcGVfdXBkYXRlX3N0YXJ0KCkgdG8gYmUgYXMgbG93Cj4gPiA+IC0JICogYXMgcG9zc2libGUs IHNvIG5vIG5lZWQgdG8gYWNxdWlyZSBwc3IubG9jayB3aGVuIGl0Cj4gPiA+IGlzCj4gPiA+IC0J ICogbm90IG5lZWRlZCBhbmQgd2lsbCBpbmR1Y2UgbGF0ZW5jaWVzIGluIHRoZSBhdG9taWMKPiA+ ID4gLQkgKiB1cGRhdGUgcGF0aC4KPiA+ID4gKwkgKiBUaGUgc29sZSB1c2VyIHJpZ2h0IG5vdyBp cyBpbnRlbF9waXBlX3VwZGF0ZV9zdGFydCgpLAo+ID4gPiB3aGljaCB3b24ndAo+ID4gPiArCSAq IHJhY2Ugd2l0aCBwc3JfZW5hYmxlL2Rpc2FibGUgd2hlcmUgcHNyMl9lbmFibGVkIGlzCj4gPiA+ IHdyaXR0ZW4gdG8uIFNvLCB3ZQo+ID4gPiArCSAqIGRvbid0IG5lZWQgdG8gYWNxdWlyZSB0aGUg cHNyLmxvY2suIE1vcmUgaW1wb3J0YW50bHksCj4gPiA+IHdlIHdhbnQgdGhlCj4gPiA+ICsJICog bGF0ZW5jeSBpbnNpZGUgaW50ZWxfcGlwZV91cGRhdGVfc3RhcnQoKSB0byBiZSBhcyBsb3cKPiA+ ID4gYXMgcG9zc2libGUsIHNvCj4gPiA+ICsJICogbm8gbmVlZCB0byBhY3F1aXJlIHBzci5sb2Nr IHdoZW4gaXQgaXMgbm90IG5lZWRlZCBhbmQKPiA+ID4gd2lsbCBpbmR1Y2UKPiA+ID4gKwkgKiBs YXRlbmNpZXMgaW4gdGhlIGF0b21pYyB1cGRhdGUgcGF0aC4KPiA+ID4gIAkgKi8KPiA+IAo+ID4g SSB0aGluayB3ZSBzaG91bGRuJ3QgY2hhbmdlIHRoaXMgZm9ybWF0IGhlcmUgdG8ga2VlcCBwYXRj aAo+ID4gY2xlYW5lci4uLgo+ID4gaWYgdGhlcmUgaXMgYW55IGNoYW5nZSBoZXJlIEkgY291bGRu J3Qgc2VlIGJlY2F1c2UgaXQgaXMgY2hhbmdpbmcKPiA+IGFsbAo+ID4gbGluZXMgYW5kIGlmIHRo ZXJlIGlzIG5vIGNoYW5nZSBJIHRoaW5rIGl0IGlzIGJldHRlciBub3QgdG8gdG91Y2gKPiA+IGJl Y2F1c2UKPiA+IGl0IHJlbW92ZXMgdGhlIGZvY3VzIG9mIHRoZSByZWFsIGNoYW5nZXMuCj4gCj4g T2theS4KPiA+IAo+ID4gPiAtCWlmIChkZXZfcHJpdi0+cHNyLnBzcjJfZW5hYmxlZCkgewo+ID4g PiAtCQlyZWcgPSBFRFBfUFNSMl9TVEFUVVM7Cj4gPiA+IC0JCW1hc2sgPSBFRFBfUFNSMl9TVEFU VVNfU1RBVEVfTUFTSzsKPiA+ID4gLQl9IGVsc2Ugewo+ID4gPiAtCQlyZWcgPSBFRFBfUFNSX1NU QVRVUzsKPiA+ID4gLQkJbWFzayA9IEVEUF9QU1JfU1RBVFVTX1NUQVRFX01BU0s7Cj4gPiA+IC0J fQo+ID4gPiArCWlmICghbmV3X2NydGNfc3RhdGUtPmhhc19wc3IgfHwgUkVBRF9PTkNFKGRldl9w cml2LQo+ID4gPiA+IHBzci5wc3IyX2VuYWJsZWQpKQo+ID4gCj4gPiBJIG5vdyBzZWUgdGhhdCB3 ZSBhcmUgcmVtb3ZpbmcgcHNyMiBvZiB0aGUgcGljdHVyZSwgYnV0IEkgZG9uJ3Qgc2VlCj4gPiBo b3cgd2UgYXJlCj4gPiBpbXByb3ZpbmcgcHNyMiBzaXR1YXRpb24gaGVyZS4KPiA+IHdoYXQgYW0g SSBtaXNzaW5nPwo+ID4gCj4gCj4gV2hlbiB0aGUgcGF0Y2ggd2FzIHdyaXR0ZW4sIHdlIGRpZCBu b3QgaGF2ZSBzdWZmaWNpZW50IHRlc3RzIHRvIHRlbGwKPiB1cwo+IHRoZSB3YWl0X2Zvcl9pZGxl IGNvbmRpdGlvbiB3YXMgd3JvbmcgZm9yIFBTUjIuIEl0IHdhcyBub3Qga25vd24KPiB3aGV0aGVy IHRoZSB3YWl0IHdhcyAqbmVjZXNzYXJ5KiBmb3IgUFNSMiwgdGhpbmsgb2YgdGhpcyBhcyBhIHBh cnRpYWwKPiByZXZlcnQuIE5vdyB0aGF0IENJIGhhcyBwb2ludGVkIG91dCwgKGFuZCBJIGNoZWNr ZWQgd2l0aCBhIFBTUjIKPiBwYW5lbCkKPiB0aGF0IHRoZSBjb25kaXRpb24gaXMgd3JvbmcsIHdl IHNob3VsZCBiZSByZW1vdmluZyBpdCBmb3IgUFNSMi4gSWYKPiB5b3UKPiB0aGluayBhYm91dCBp dCwgaXQgZG9lcyBpbXByb3ZlIFBTUjIgbXkgcmVtb3ZpbmcgaXJyZWxldmFudCBjb2RlLgo+IApJ J2xsIHN1Ym1pdCBhIG5ldyB2ZXJzaW9uIHdpdGhvdXQgdGhlIGNvbW1lbnQgZGlmZiBpZiB5b3Ug YXJlIHNhdGlzZmllZAp3aXRoIHRoZSBhYm92ZSByZWFzb25pbmcuCgo+IAo+ID4gPiArCQlyZXR1 cm4gMDsKPiA+ID4gIAo+ID4gPiAgCS8qCj4gPiA+IC0JICogTWF4IHRpbWUgZm9yIFBTUiB0byBp ZGxlID0gSW52ZXJzZSBvZiB0aGUgcmVmcmVzaAo+ID4gPiByYXRlCj4gPiA+ICsKPiA+ID4gLQkg KiA2IG1zIG9mIGV4aXQgdHJhaW5pbmcgdGltZSArIDEuNSBtcyBvZiBhdXggY2hhbm5lbAo+ID4g PiAtCSAqIGhhbmRzaGFrZS4gNTAgbXNlYyBpcyBkZWZlc2l2ZSBlbm91Z2ggdG8gY292ZXIKPiA+ ID4gZXZlcnl0aGluZy4KPiA+ID4gKwkgKiBGcm9tIEJzcGVjIFBhbmVsIFNlbGYgUmVmcmVzaCAo QkRXKyk6Cj4gPiAKPiA+IFRoaXMgaXMgYW5vdGhlciBjYXNlLCBpZiB3ZSBkaWRuJ3QgY2hhbmdl IHRoZSBmb3JtYXQgb25seSB0aGlzIGxpbmUKPiA+IF4KPiA+IHdvdWxkIGJlIGluIHRoZSBwYXRj aCBhbmQgaXQgd291bGQgYmUgY2xlYW5lciBhbmQgZWFzaWVyIHRvIHJldmlldwo+ID4gdGhlCj4g PiBjaGFuZ2VzLgo+ID4gCj4gPiBidXQgbXkgYmlnZ2VzdCBjb25jZXJuIHdpdGggdGhpcyBwYXRj aCBpcyBob3cgZG8gd2UgY2hlY2sgbm93Cj4gPiB3YWl0X3BzcjIgaWRsZQo+ID4gCj4gPiA+ICsJ ICogTWF4LiB0aW1lIGZvciBQU1IgdG8gaWRsZSA9IGludmVyc2Ugb2YgdGhlIHJlZnJlc2gKPiA+ ID4gcmF0ZQo+ID4gPiArIDYgbXMgb2YKPiA+ID4gKwkgKiBleGl0IHRyYWluaW5nIHRpbWUgKyAx LjUgbXMgb2YgYXV4IGNoYW5uZWwgaGFuZHNoYWtlLgo+ID4gPiA1MCBtcyBpcwo+ID4gPiArCSAq IGRlZmVuc2l2ZSBlbm91Z2ggdG8gY292ZXIgZXZlcnl0aGluZy4KPiA+ID4gIAkgKi8KPiA+ID4g LQo+ID4gPiAtCXJldHVybiBfX2ludGVsX3dhaXRfZm9yX3JlZ2lzdGVyKGRldl9wcml2LCByZWcs IG1hc2ssCj4gPiA+ICsJcmV0dXJuIF9faW50ZWxfd2FpdF9mb3JfcmVnaXN0ZXIoZGV2X3ByaXYs Cj4gPiA+IEVEUF9QU1JfU1RBVFVTLAo+ID4gPiArCQkJCQkgRURQX1BTUl9TVEFUVVNfU1RBVEVf TUEKPiA+ID4gU0sKPiA+ID4gLAo+ID4gPiAgCQkJCQkgRURQX1BTUl9TVEFUVVNfU1RBVEVfSUQK PiA+ID4gTEUKPiA+ID4gLCAyLCA1MCwKPiA+ID4gIAkJCQkJIG91dF92YWx1ZSk7Cj4gPiA+ICB9 Cj4gPiA+IC0tIAo+ID4gPiAyLjE3LjEKPiA+ID4gCj4gPiA+IF9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gPiA+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QK PiA+ID4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gPiBodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo+IAo+IF9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxp bmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeApfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0 CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK