Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 42F8AC433EF for ; Thu, 16 Jun 2022 13:45:33 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C211783C0C; Thu, 16 Jun 2022 15:45:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="MrEhIVmw"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id AD95B84328; Thu, 16 Jun 2022 15:45:29 +0200 (CEST) Received: from mail-qv1-xf2c.google.com (mail-qv1-xf2c.google.com [IPv6:2607:f8b0:4864:20::f2c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1F6B383AB5 for ; Thu, 16 Jun 2022 15:45:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qv1-xf2c.google.com with SMTP id i19so2085233qvu.13 for ; Thu, 16 Jun 2022 06:45:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=T+cvkDV+/j338jgIbgv/0XE7gVVMiwoKRu72U3DhDBQ=; b=MrEhIVmwcQPC3N/WubZMUGC3YXM4AZh9MfzQpIAIQFZV8yPSGzttnFtscaPDQqPcpW lMEuD73J61rKa9m2GeaWt90jUVF/5r0+4BbOfvJoEIItt6Hr0Y51mJzXECD7CPZ5cWVH YcHSXH4RfDppbE4VNsZIzu7z7njrxY+aIUrelHFqDjCU19UJi4wSAEwZgCK7BkjRv6LS kUof3k4SDy45gRYEIgv/SY0tKN5BOclrViDDOUoUfHRRQzVQ5+PDD1oYhkYZcvZsnroR vK5ufUNHY7M+tNYvmzO+VxQfv8aCP3iPyT+BsCiJLweP28W6du1pLoAEQ9zsVDtQ6ExD 240w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=T+cvkDV+/j338jgIbgv/0XE7gVVMiwoKRu72U3DhDBQ=; b=yXXjlhwwQqaP33meDNtbigiSK6EDIBfuU5neSW921ZzXVtCQVxwIazPJEup0cT6Hzl ngwac1gdUf8MySvZ3fkyczNwyC4rsqVyXk+zVnzATQFqUvOyBuTxok3fOC2QUiv0vrWk 5HA0JliodvaEob2lIzCMjy2tDv7iIoG5qwQtN4taerVkMer5/Y47wAAsO8ZV0klqVDjF Yyj4E+Vgjt+JU3Q1PhGUVMUKCAErgVEUk6nI5A0YiAyaGkYZN3s47dJFEVILZee0sGki w8V3aJpqXHSKoh3L/idQEVWS6FenfK6Kmenln45x6V4FzcpKk09XoD1F/jIDAiYf0g2N Iksw== X-Gm-Message-State: AJIora8RpiQ1WI2DzIfJh01FD4/RhkNJU9iJxqXZs5v/4NwpEzhvsNC6 B0dGnj2cO4Klb76SU+Hua9U/3afmWOmAH8Ng X-Google-Smtp-Source: AGRyM1trWuovCTm/FF69gNadY5+dYA5+wEUug6MBZndu2kocadqdeYbcUmO2c0OFQISICROVa9sOVw== X-Received: by 2002:a05:622a:60a:b0:306:6575:603d with SMTP id z10-20020a05622a060a00b003066575603dmr3974332qta.511.1655387125594; Thu, 16 Jun 2022 06:45:25 -0700 (PDT) Received: from [192.168.1.201] (pool-173-73-95-180.washdc.fios.verizon.net. [173.73.95.180]) by smtp.gmail.com with ESMTPSA id s26-20020a05622a1a9a00b00304fd53de4csm1983885qtc.47.2022.06.16.06.45.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Jun 2022 06:45:25 -0700 (PDT) Subject: Re: [PATCH v2 05/14] doc: mkimage: Use subsection macro To: Heinrich Schuchardt Cc: Simon Glass , u-boot@lists.denx.de References: <20220612221411.1608406-1-seanga2@gmail.com> <20220612221411.1608406-6-seanga2@gmail.com> <111550e2-b353-dcf8-7392-b7da892a35c8@gmx.de> From: Sean Anderson Message-ID: Date: Thu, 16 Jun 2022 09:45:24 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <111550e2-b353-dcf8-7392-b7da892a35c8@gmx.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 6/16/22 6:08 AM, Heinrich Schuchardt wrote: > On 6/13/22 00:14, Sean Anderson wrote: >> The options are divided up into several subsections. Use the appropria= te >> macro. While we're at it, rename the headings to better reflect the >> contents of their sections. >> >> Signed-off-by: Sean Anderson >> --- >> >> Changes in v2: >> - Rename first subsection to "General options" >> - Use paired quotation marks >> >> =C2=A0 doc/mkimage.1 | 8 +++----- >> =C2=A0 1 file changed, 3 insertions(+), 5 deletions(-) >> >> diff --git a/doc/mkimage.1 b/doc/mkimage.1 >> index 4074715fe5..8b96011f90 100644 >> --- a/doc/mkimage.1 >> +++ b/doc/mkimage.1 >> @@ -51,7 +51,7 @@ supports verified boot. >> =C2=A0 . >> =C2=A0 .SH OPTIONS >> =C2=A0 . >> -.B List image information: >> +.SS General options >> =C2=A0 . >> =C2=A0 .TP >> =C2=A0 .BI \-l " uimage-file-name" >> @@ -67,8 +67,7 @@ Without this option image type is autodetected. >> =C2=A0 .B \-q >> =C2=A0 Quiet. Don't print the image header on successful verification.= >> =C2=A0 . >> -.P >> -.B Create old legacy image: >> +.SS Options for creating legacy or \(lqauto\(rq images > An image type (IH_TYPE_SUNXI_TOC0) introduced in 2022 cannot be legacy.= > Please, remove this misleading and derogatory term. I guess you mean > anything but FIT.=20 This is really Simon's usage. I agree that it doesn't really apply. > Should the whole paragraph be move down below the > descriptions of the creation of FIT images? Then you could say "Options= > for creating other image types". >=20 > I have no clue what an "auto" image might refer to. The man-page is not= > of any help here. See the documentation for -f The problem is that we really should have an image type of "fit" and -n should be used instead of -f. But what's done is done. --Sean > Best regards >=20 > Heinrich >=20 >> =C2=A0 . >> =C2=A0 .TP >> =C2=A0 .BI \-A " architecture" >> @@ -151,8 +150,7 @@ just the header, everything but the image data, or= nothing at all. >> =C2=A0 .B \-v >> =C2=A0 Verbose. Print file names as they are added to the image. >> =C2=A0 . >> -.P >> -.B Create FIT image: >> +.SS Options for creating FIT images >> =C2=A0 . >> =C2=A0 .TP >> =C2=A0 .BI \-b " device-tree-file" >=20