Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 85837C433EF for ; Thu, 5 May 2022 16:58:56 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BDD0683FD3; Thu, 5 May 2022 18:58:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=xs4all.nl Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id B8F3083FC8; Thu, 5 May 2022 18:58:51 +0200 (CEST) Received: from sibelius.xs4all.nl (80-61-163-207.fixed.kpn.net [80.61.163.207]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 82E458186D for ; Thu, 5 May 2022 18:58:49 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=xs4all.nl Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=mark.kettenis@xs4all.nl Received: from localhost (bloch.sibelius.xs4all.nl [local]) by bloch.sibelius.xs4all.nl (OpenSMTPD) with ESMTPA id 7d8d6596; Thu, 5 May 2022 18:58:48 +0200 (CEST) Date: Thu, 5 May 2022 18:58:48 +0200 (CEST) From: Mark Kettenis To: Heinrich Schuchardt Cc: kettenis@openbsd.org, sjg@chromium.org, u-boot@lists.denx.de In-Reply-To: <0b3a73bf-746c-4538-04f8-1ff048d86899@gmx.de> (message from Heinrich Schuchardt on Thu, 5 May 2022 16:55:24 +0200) Subject: Re: [PATCH] Makefile: Avoid non-portable GNU sed extension References: <20220505144223.58012-1-kettenis@openbsd.org> <0b3a73bf-746c-4538-04f8-1ff048d86899@gmx.de> Message-ID: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean > Date: Thu, 5 May 2022 16:55:24 +0200 > From: Heinrich Schuchardt > > On 5/5/22 16:42, Mark Kettenis wrote: > > Use [:space:] instead of \s and \S in regular expression that > > determines the sandbox target architecture. Fixes the build > > failure on OpenBSD introduced with commit 4e65ca00f3a3 > > ("efi_loader: bootmgr: add booting from removable media"). > > > > Fixes: f7691a6d73 ("sandbox: allow cross-compiling sandbox") > nits, use 12 first digits of hash > > Fixes: f7691a6d736b ("sandbox: allow cross-compiling sandbox") Hmm, checkpatch didn't catch that one. Is this something I should do a resubmit for? > > Signed-off-by: Mark Kettenis > > Reviewed-by: Heinrich Schuchardt > > > --- > > Makefile | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Makefile b/Makefile > > index ea80f00716..6eceeb35b4 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -21,7 +21,7 @@ include include/host_arch.h > > ifeq ("", "$(CROSS_COMPILE)") > > MK_ARCH="${shell uname -m}" > > else > > - MK_ARCH="${shell echo $(CROSS_COMPILE) | sed -n 's/^\s*\([^\/]*\/\)*\([^-]*\)-\S*/\2/p'}" > > + MK_ARCH="${shell echo $(CROSS_COMPILE) | sed -n 's/^[[:space:]]*\([^\/]*\/\)*\([^-]*\)-[^[:space:]]*/\2/p'}" > > endif > > unexport HOST_ARCH > > ifeq ("x86_64", $(MK_ARCH)) > >